Skip to content

bsd-user upstreaming: read, write and exit

Warner Losh qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 2 repliesIn review
  2. v16 patches 13 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6bsd-user/freebsd/os-syscall.c: lock_iovecbsd-user/freebsd/os-syscall.c+102 -00 replies
2/6bsd-user/freebsd/os-syscall.c: unlock_iovecbsd-user/freebsd/os-syscall.c+14 -00 replies
3/6bsd-user/freebsd/os-syscall.c: Tracing and error boilerplatebsd-user/freebsd/os-syscall.c+40 -40 replies
4/6bsd-user/bsd-file.h: Add implementations for read, pread, readv and preadvbsd-user/bsd-file.h bsd-user/freebsd/os-syscall.c+107 -00 replies
5/6bsd-user/bsd-file.h: Meat of the write system callsbsd-user/bsd-file.h bsd-user/freebsd/os-syscall.c+106 -00 replies
6/6bsd-user/freebsd/os-syscall.c: Implement exitbsd-user/bsd-proc.h bsd-user/freebsd/os-syscall.c+50 -01 reply

Reviews trailers per patch

1 of 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchKyle EvansRichard Henderson
SeriesR-b
1/6
2/6
3/6
4/6
5/6
6/6R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/6] bsd-user upstreaming: read, write and exit

This series of patches continues the effort to get system calls working upstream. This series was cleaved off a prior series to give me time to rework based on the feedback from the first time I posted these.

o bsd-user/freebsd/os-syscall.c: lock_iovec
I rewored to use g_try_new, as well as fixing bugs in the 'after a FAULT handling code' Created a common routine to cleanup after errors that can be used for the unlock_iovec.

o bsd-user/freebsd/os-syscall.c: unlock_iovec
Fixed the error handling to be consistent with a normal unlock_iovec.

o bsd-user/freebsd/os-syscall.c: Tracing and error boilerplate
Created the wrapper function as suggested in prior reviews.

V2: Use g_try_new0 and simplify based on not needing to initialize things to zero that are already zero. Only affects the 'lock_iovec' hunk.

V2: Remove inline tags from do_bsd_* routines.

V2: Clean up logging a little

Now all the patches, except the last one, need to be reviewed.

Warner Losh (6):
bsd-user/freebsd/os-syscall.c: lock_iovec bsd-user/freebsd/os-syscall.c: unlock_iovec bsd-user/freebsd/os-syscall.c: Tracing and error boilerplate bsd-user/bsd-file.h: Add implementations for read, pread, readv and
preadv
bsd-user/bsd-file.h: Meat of the write system calls bsd-user/freebsd/os-syscall.c: Implement exit

 bsd-user/bsd-file.h           | 163 +++++++++++++++++++++++++
 bsd-user/bsd-proc.h           |  43 +++++++
 bsd-user/freebsd/os-syscall.c | 217 +++++++++++++++++++++++++++++++++-
 3 files changed, 419 insertions(+), 4 deletions(-)
 create mode 100644 bsd-user/bsd-proc.h
Signature · 1 line
2.33.1