cpuidle,rcu: Clean up the mess
Status from this message: The following commit has been merged into the sched/core branch of tip:
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest51 patches 15 repliesApplied
- v244 patches 45 repliesSuperseded
- v136 patches 68 repliesSuperseded
Changes in v3 from the cover letter
- rebased to v6.2-rc3; as available at:
git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/idle
- folded: https://lkml.kernel.org/r/[email protected]
which makes the ARM cpuidle index 0 consistently not use CPUIDLE_FLAG_RCU_IDLE, as requested by Ulf.
- added a few more __always_inline to empty stub functions as found by the robot.
- Used _RET_IP_ instead of _THIS_IP_ in a few placed because of:
https://github.com/ClangBuiltLinux/linux/issues/263
- Added new patches to address various robot reports:
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/51 | x86/perf/amd: Remove tracing from perf_lopwr_cb()arch/ arch/ | +6 | 0 replies | |
| 2/51 | x86/idle: Replace x86_idle with a static_callarch/ | +28 | 0 replies | |
| 3/51 | cpuidle/poll: Ensure IRQ state is invariantdrivers/ | +3 | 0 replies | |
| 4/51 | cpuidle: Move IRQ state validationdrivers/ | +5 | 0 replies | |
| 5/51 | cpuidle,riscv: Push RCU-idle into driverdrivers/ | +5 | 0 replies | |
| 6/51 | cpuidle,tegra: Push RCU-idle into driverdrivers/ | +16 | 0 replies | |
| 7/51 | cpuidle,psci: Push RCU-idle into driverdrivers/ | +5 | 2 replies | |
| 8/51 | cpuidle,imx6: Push RCU-idle into driverarch/ | +4 | 0 replies | |
| 9/51 | cpuidle,omap3: Push RCU-idle into driverarch/ | +16 | 0 replies | |
| 10/51 | cpuidle,armada: Push RCU-idle into driverdrivers/ | +7 | 0 replies | |
| 11/51 | cpuidle,omap4: Push RCU-idle into driverarch/ | +18 | 0 replies | |
| 12/51 | cpuidle,dt: Push RCU-idle into driverdrivers/ drivers/ drivers/ +1 more | +11 | 0 replies | |
| 13/51 | cpuidle: Fix ct_idle_*() usagearch/ arch/ arch/ +12 more | +86 | 0 replies | |
| 14/51 | cpuidle,cpu_pm: Remove RCU fiddling from cpu_pm_{enter,exit}()kernel/ | +0 | 0 replies | |
| 15/51 | acpi_idle: Remove tracingdrivers/ | +8 | 0 replies | |
| 16/51 | cpuidle: Annotate poll_idle()drivers/ | +5 | 3 replies | |
| 17/51 | objtool/idle: Validate __cpuidle code as noinstrarch/ arch/ arch/ +29 more | +27 | 0 replies | |
| 18/51 | cpuidle,intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE *again*drivers/ | +1 | 0 replies | |
| 19/51 | cpuidle,intel_idle: Fix CPUIDLE_FLAG_INIT_XSTATEarch/ arch/ arch/ | +5 | 0 replies | |
| 20/51 | cpuidle,intel_idle: Fix CPUIDLE_FLAG_IBRSarch/ drivers/ | +3 | 0 replies | |
| 21/51 | arch/idle: Change arch_cpu_idle() IRQ behaviourarch/ arch/ arch/ +24 more | +29 | 0 replies | |
| 22/51 | x86/tdx: Remove TDX_HCALL_ISSUE_STIarch/ arch/ arch/ | +4 | 0 replies | |
| 23/51 | arm,smp: Remove trace_.*_rcuidle() usagearch/ | +3 | 0 replies | |
| 24/51 | arm64,smp: Remove trace_.*_rcuidle() usagearch/ | +2 | 0 replies | |
| 25/51 | printk: Remove trace_.*_rcuidle() usagekernel/ | +1 | 0 replies | |
| 26/51 | time/tick-broadcast: Remove RCU_NONIDLE usagekernel/ | +12 | 0 replies | |
| 27/51 | cpuidle,sched: Remove annotations from TIF_{POLLING_NRFLAG,NEED_RESCHED}include/ include/ | +47 | 0 replies | |
| 28/51 | cpuidle,mwait: Make noinstr cleanarch/ arch/ | +7 | 0 replies | |
| 29/51 | cpuidle,tdx: Make tdx noinstr cleanarch/ arch/ arch/ | +6 | 0 replies | |
| 30/51 | cpuidle,xenpv: Make more PARAVIRT_XXL noinstr cleanarch/ arch/ arch/ +3 more | +21 | 0 replies | |
| 31/51 | cpuidle,nospec: Make noinstr cleanarch/ | +1 | 0 replies | |
| 32/51 | cpuidle,acpi: Make noinstr cleanarch/ drivers/ include/ | +5 | 0 replies | |
| 33/51 | trace: Remove trace_hardirqs_{on,off}_caller()kernel/ | +0 | 0 replies | |
| 34/51 | trace: WARN on rcuidleinclude/ kernel/ | +16 | 0 replies | |
| 35/51 | trace,hardirq: No moar _rcuidle() tracingkernel/ | +13 | 4 replies | |
| 36/51 | cpuidle,omap3: Use WFI for omap3_pm_idle()arch/ | +1 | 0 replies | |
| 37/51 | cpuidle,omap3: Push RCU-idle into omap_sram_idle()arch/ arch/ arch/ | +12 | 0 replies | |
| 38/51 | cpuidle,omap4: Push RCU-idle into omap4_enter_lowpower()arch/ arch/ arch/ +1 more | +18 | 0 replies | |
| 39/51 | arm,omap2: Use WFI for omap2_pm_idle()arch/ | +2 | 0 replies | |
| 40/51 | cpuidle,powerdomain: Remove trace_.*_rcuidle()arch/ drivers/ | +17 | 0 replies | |
| 41/51 | cpuidle,clk: Remove trace_.*_rcuidle()drivers/ | +4 | 1 reply | |
| 42/51 | ubsan: Fix objtool UACCESS warnslib/ tools/ | +5 | 0 replies | |
| 43/51 | intel_idle: Add force_irq_on module paramdrivers/ | +6 | 0 replies | |
| 44/51 | entry,kasan,x86: Disallow overriding mem*() functionsarch/ arch/ arch/ +3 more | +53 | 0 replies | |
| 45/51 | sched: Always inline __this_cpu_preempt_check()include/ | +1 | 0 replies | |
| 46/51 | arm64,riscv,perf: Remove RCU_NONIDLE() usagedrivers/ drivers/ | +2 | 0 replies | |
| 47/51 | cpuidle: Ensure ct_cpuidle_enter() is always called from noinstr/__cpuidledrivers/ | +28 | 0 replies | |
| 48/51 | cpuidle,arch: Mark all ct_cpuidle_enter() callers __cpuidlearch/ arch/ arch/ +9 more | +33 | 0 replies | |
| 49/51 | cpuidle,arch: Mark all regular cpuidle_state::enter methods __cpuidlearch/ arch/ arch/ +4 more | +15 | 0 replies | |
| 50/51 | cpuidle: Comments about noinstr/__cpuidledrivers/ include/ | +22 | 0 replies | |
| 51/51 | context_tracking: Fix noinstr vs KASANkernel/ | +6 | 0 replies |
Reviews trailers per patch
45 of 51 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 19 reviewers.
Cover letter [PATCH v3 00/51] cpuidle,rcu: Clean up the mess
Hi All!
The (hopefully) final respin of cpuidle vs rcu cleanup patches. Barring any objections I'll be queueing these patches in tip/sched/core in the next few days.
v2: https://lkml.kernel.org/r/[email protected]
These here patches clean up the mess that is cpuidle vs rcuidle.
At the end of the ride there's only on RCU_NONIDLE user left:
arch/arm64/kernel/suspend.c: RCU_NONIDLE(__cpu_suspend_exit());
And I know Mark has been prodding that with something sharp.
The last version was tested by a number of people and I'm hoping to not have broken anything in the meantime ;-)
Changes since v2:
- rebased to v6.2-rc3; as available at:
git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/idle
- folded: https://lkml.kernel.org/r/[email protected]
which makes the ARM cpuidle index 0 consistently not use CPUIDLE_FLAG_RCU_IDLE, as requested by Ulf.
- added a few more __always_inline to empty stub functions as found by the robot.
- Used _RET_IP_ instead of _THIS_IP_ in a few placed because of:
https://github.com/ClangBuiltLinux/linux/issues/263
- Added new patches to address various robot reports:
#35: trace,hardirq: No moar _rcuidle() tracing
#47: cpuidle: Ensure ct_cpuidle_enter() is always called from noinstr/__cpuidle
#48: cpuidle,arch: Mark all ct_cpuidle_enter() callers __cpuidle
#49: cpuidle,arch: Mark all regular cpuidle_state::enter methods __cpuidle
#50: cpuidle: Comments about noinstr/__cpuidle
#51: context_tracking: Fix noinstr vs KASAN--- arch/alpha/kernel/process.c | 1 - arch/alpha/kernel/vmlinux.lds.S | 1 - arch/arc/kernel/process.c | 3 ++ arch/arc/kernel/vmlinux.lds.S | 1 - arch/arm/include/asm/vmlinux.lds.h | 1 - arch/arm/kernel/cpuidle.c | 4 +- arch/arm/kernel/process.c | 1 - arch/arm/kernel/smp.c | 6 +-- arch/arm/mach-davinci/cpuidle.c | 4 +- arch/arm/mach-gemini/board-dt.c | 3 +- arch/arm/mach-imx/cpuidle-imx5.c | 4 +- arch/arm/mach-imx/cpuidle-imx6q.c | 8 ++-- arch/arm/mach-imx/cpuidle-imx6sl.c | 4 +- arch/arm/mach-imx/cpuidle-imx6sx.c | 9 ++-- arch/arm/mach-imx/cpuidle-imx7ulp.c | 4 +- arch/arm/mach-omap2/common.h | 6 ++- arch/arm/mach-omap2/cpuidle34xx.c | 16 ++++++- arch/arm/mach-omap2/cpuidle44xx.c | 29 +++++++------ arch/arm/mach-omap2/omap-mpuss-lowpower.c | 12 +++++- arch/arm/mach-omap2/pm.h | 2 +- arch/arm/mach-omap2/pm24xx.c | 51 +--------------------- arch/arm/mach-omap2/pm34xx.c | 14 +++++-- arch/arm/mach-omap2/pm44xx.c | 2 +- arch/arm/mach-omap2/powerdomain.c | 10 ++--- arch/arm/mach-s3c/cpuidle-s3c64xx.c | 5 +-- arch/arm64/kernel/cpuidle.c | 2 +- arch/arm64/kernel/idle.c | 1 - arch/arm64/kernel/smp.c | 4 +- arch/arm64/kernel/vmlinux.lds.S | 1 - arch/csky/kernel/process.c | 1 - arch/csky/kernel/smp.c | 2 +- arch/csky/kernel/vmlinux.lds.S | 1 - arch/hexagon/kernel/process.c | 1 - arch/hexagon/kernel/vmlinux.lds.S | 1 - arch/ia64/kernel/process.c | 1 + arch/ia64/kernel/vmlinux.lds.S | 1 - arch/loongarch/kernel/idle.c | 1 + arch/loongarch/kernel/vmlinux.lds.S | 1 - arch/m68k/kernel/vmlinux-nommu.lds | 1 - arch/m68k/kernel/vmlinux-std.lds | 1 - arch/m68k/kernel/vmlinux-sun3.lds | 1 - arch/microblaze/kernel/process.c | 1 - arch/microblaze/kernel/vmlinux.lds.S | 1 - arch/mips/kernel/idle.c | 14 +++---- arch/mips/kernel/vmlinux.lds.S | 1 - arch/nios2/kernel/process.c | 1 - arch/nios2/kernel/vmlinux.lds.S | 1 - arch/openrisc/kernel/process.c | 1 + arch/openrisc/kernel/vmlinux.lds.S | 1 - arch/parisc/kernel/process.c | 2 - arch/parisc/kernel/vmlinux.lds.S | 1 - arch/powerpc/kernel/idle.c | 5 +-- arch/powerpc/kernel/vmlinux.lds.S | 1 - arch/riscv/kernel/process.c | 1 - arch/riscv/kernel/vmlinux-xip.lds.S | 1 - arch/riscv/kernel/vmlinux.lds.S | 1 - arch/s390/kernel/idle.c | 1 - arch/s390/kernel/vmlinux.lds.S | 1 - arch/sh/kernel/idle.c | 1 + arch/sh/kernel/vmlinux.lds.S | 1 - arch/sparc/kernel/leon_pmc.c | 4 ++ arch/sparc/kernel/process_32.c | 1 - arch/sparc/kernel/process_64.c | 3 +- arch/sparc/kernel/vmlinux.lds.S | 1 - arch/um/kernel/dyn.lds.S | 1 - arch/um/kernel/process.c | 1 - arch/um/kernel/uml.lds.S | 1 - arch/x86/boot/compressed/vmlinux.lds.S | 1 + arch/x86/coco/tdx/tdcall.S | 15 +------ arch/x86/coco/tdx/tdx.c | 25 ++++------- arch/x86/events/amd/brs.c | 13 +++--- arch/x86/include/asm/fpu/xcr.h | 4 +- arch/x86/include/asm/irqflags.h | 11 ++--- arch/x86/include/asm/mwait.h | 14 +++---- arch/x86/include/asm/nospec-branch.h | 2 +- arch/x86/include/asm/paravirt.h | 6 ++- arch/x86/include/asm/perf_event.h | 2 +- arch/x86/include/asm/shared/io.h | 4 +- arch/x86/include/asm/shared/tdx.h | 1 - arch/x86/include/asm/special_insns.h | 8 ++-- arch/x86/include/asm/xen/hypercall.h | 2 +- arch/x86/kernel/cpu/bugs.c | 2 +- arch/x86/kernel/fpu/core.c | 4 +- arch/x86/kernel/paravirt.c | 14 ++++++- arch/x86/kernel/process.c | 65 ++++++++++++++-------------- arch/x86/kernel/vmlinux.lds.S | 1 - arch/x86/lib/memcpy_64.S | 5 +-- arch/x86/lib/memmove_64.S | 4 +- arch/x86/lib/memset_64.S | 4 +- arch/x86/xen/enlighten_pv.c | 2 +- arch/x86/xen/irq.c | 2 +- arch/xtensa/kernel/process.c | 1 + arch/xtensa/kernel/vmlinux.lds.S | 1 - drivers/acpi/processor_idle.c | 28 ++++++++----- drivers/base/power/runtime.c | 24 +++++------ drivers/clk/clk.c | 8 ++-- drivers/cpuidle/cpuidle-arm.c | 4 +- drivers/cpuidle/cpuidle-big_little.c | 12 ++++-- drivers/cpuidle/cpuidle-mvebu-v7.c | 13 ++++-- drivers/cpuidle/cpuidle-psci.c | 26 +++++------- drivers/cpuidle/cpuidle-qcom-spm.c | 4 +- drivers/cpuidle/cpuidle-riscv-sbi.c | 19 +++++---- drivers/cpuidle/cpuidle-tegra.c | 31 +++++++++----- drivers/cpuidle/cpuidle.c | 70 ++++++++++++++++++++++--------- drivers/cpuidle/dt_idle_states.c | 2 +- drivers/cpuidle/poll_state.c | 10 ++++- drivers/idle/intel_idle.c | 19 ++++----- drivers/perf/arm_pmu.c | 11 +---- drivers/perf/riscv_pmu_sbi.c | 8 +--- include/asm-generic/vmlinux.lds.h | 9 ++-- include/linux/clockchips.h | 4 +- include/linux/compiler_types.h | 18 +++++++- include/linux/cpu.h | 3 -- include/linux/cpuidle.h | 32 ++++++++++++++ include/linux/cpumask.h | 4 +- include/linux/percpu-defs.h | 2 +- include/linux/sched/idle.h | 40 +++++++++++++----- include/linux/thread_info.h | 18 +++++++- include/linux/tracepoint.h | 15 ++++++- kernel/context_tracking.c | 12 +++--- kernel/cpu_pm.c | 9 ---- kernel/printk/printk.c | 2 +- kernel/sched/idle.c | 47 ++++++--------------- kernel/time/tick-broadcast-hrtimer.c | 29 ++++++------- kernel/time/tick-broadcast.c | 6 ++- kernel/trace/trace.c | 3 ++ kernel/trace/trace_preemptirq.c | 50 ++++++---------------- lib/ubsan.c | 5 ++- mm/kasan/kasan.h | 4 ++ mm/kasan/shadow.c | 38 +++++++++++++++++ tools/objtool/check.c | 17 ++++++++ 131 files changed, 617 insertions(+), 523 deletions(-)