Skip to content

MSG_ZEROCOPY fixes & improvements

Leonardo Bras qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 16 repliesIn review
  2. v32 patches 2 repliesSuperseded
  3. v22 patches 6 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4QIOChannelSocket: Introduce assert and reduce ifdefs to improve readabilityio/channel-socket.c+9 -52 replies
2/4QIOChannelSocket: Fix zero-copy send so socket flush worksio/channel-socket.c+5 -02 replies
3/4migration: zero-copy flush only at the end of bitmap scanningmigration/multifd.c migration/multifd.h migration/ram.c+41 -257 replies
4/4migration: Change zero_copy_send from migration parameter to migration capabilitymigration/migration.c monitor/hmp-cmds.c qapi/migration.json+28 -635 replies

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchDaniel P. BerrangéJuan QuintelaPeter XuMarkus Armbruster
1/4R-b R-b R-b
2/4R-b R-b R-b
3/4
4/4R-b A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/4] MSG_ZEROCOPY fixes & improvements

Patches 1 & 2 are about a fix needed to make zero-copy flush work. The code that incremented the sendmsg counter ended up missing in the last versions of the patchset, causing the flush to never happen.

Patch 3 is about an improvement on flushing that improves sending performance.

Patch 4 is about making zero-copy-send a migration capability, instead of a migration parameter. Which actually makes more sense and helps the implementation of the libvirt code.

Leonardo Bras (4):
QIOChannelSocket: Introduce assert and reduce ifdefs to improve
readability
QIOChannelSocket: Fix zero-copy send so socket flush works
migration: zero-copy flush only at the end of bitmap scanning
migration: Change zero_copy_send from migration parameter to migration
capability

 qapi/migration.json   | 33 +++++++-----------------
 migration/multifd.h   |  1 +
 io/channel-socket.c   | 19 ++++++++++----
 migration/migration.c | 52 ++++++++++++++------------------------
 migration/multifd.c   | 58 ++++++++++++++++++++++++-------------------
 migration/ram.c       |  7 ++++++
 monitor/hmp-cmds.c    |  6 -----
 7 files changed, 83 insertions(+), 93 deletions(-)
Signature · 1 line
2.36.1