Skip to content

perf lock: New lock contention tracepoints support (v3)

Namhyung Kim linux-perf-users lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7perf lock: Print wait times with unittools/perf/builtin-lock.c+40 -80 replies
2/7perf lock: Allow to use different kernel symbolstools/perf/Documentation/perf-lock.txt tools/perf/builtin-lock.c+11 -00 replies
3/7perf lock: Skip print_bad_events() if nothing badtools/perf/builtin-lock.c+7 -00 replies
4/7perf lock: Add lock contention tracepoints record supporttools/perf/builtin-lock.c+67 -70 replies
5/7perf lock: Handle lock contention tracepointstools/perf/builtin-lock.c+125 -00 replies
6/7perf record: Allow to specify max stack depth of fp callchaintools/perf/Documentation/perf-record.txt tools/perf/util/callchain.c+17 -60 replies
7/7perf lock: Look up callchain for the contended lockstools/perf/builtin-lock.c+168 -40 replies

Reviews trailers per patch

2 of 7 patches have a Reviewed-by or Acked-by.

PatchIan Rogers
1/7
2/7
3/7
4/7
5/7A-b
6/7
7/7A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCHSET 0/7] perf lock: New lock contention tracepoints support (v3)

Hello,

Kernel v5.19 will have a new set of tracepoints to track lock contentions for various lock types. Unlike tracepoints in LOCKDEP and LOCK_STAT, it's hit only for contended locks and lock names are not available. So it needs to collect stack traces and display the caller function instead.

Changes in v3)
* fix build error
* support data from different kernels/machines
* skip bad stat unless there's actual bad ones

Changes in v2)
* add Acked-by from Ian
* print time with a unit for compact output
* add some comments (Ian)
* remove already applied patch

This patchset merely adds support for the new tracepoints to the existing perf lock commands. So there's no change to the user. Later I'll add new a sub-command dedicated to the tracepoints to make use of the additional information.

Example output:

  $ sudo perf lock record -a sleep 3
  $ perf lock report -F acquired,contended,avg_wait,wait_total

Name acquired contended avg wait total wait

   update_blocked_a...         40         40      3.61 us     144.45 us
   kernfs_fop_open+...          5          5      3.64 us      18.18 us
    _nohz_idle_balance          3          3      2.65 us       7.95 us
   tick_do_update_j...          1          1      6.04 us       6.04 us
    ep_scan_ready_list          1          1      3.93 us       3.93 us

...

You can find the code in the 'perf/lock-contention-v3' branch at

git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git

Thanks,
Namhyung

Namhyung Kim (7):
perf lock: Print wait times with unit
perf lock: Allow to use different kernel symbols perf lock: Skip print_bad_events() if nothing bad perf lock: Add lock contention tracepoints record support perf lock: Handle lock contention tracepoints
perf record: Allow to specify max stack depth of fp callchain perf lock: Look up callchain for the contended locks

 tools/perf/Documentation/perf-lock.txt   |   7 +
 tools/perf/Documentation/perf-record.txt |   5 +
 tools/perf/builtin-lock.c                | 424 ++++++++++++++++++++++-
 tools/perf/util/callchain.c              |  18 +-
 4 files changed, 432 insertions(+), 22 deletions(-)

base-commit: 9886142c7a2226439c1e3f7d9b69f9c7094c3ef6

Signature · 1 line
2.36.1.255.ge46751e96f-goog