Skip to content

ASoC: SOF: Intel: Fix IMR boot race caused by early core booting

Peter Ujfalusi alsa-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ASoC: SOF: Intel: hda-dsp: Expose hda_dsp_core_power_up()sound/soc/sof/intel/hda-dsp.c sound/soc/sof/intel/hda.h+10 -10 replies
2/3ASoC: SOF: Intel: hda-loader: Make sure that the fw load sequence is followedsound/soc/sof/intel/hda-loader.c+1 -10 replies
3/3ASoC: SOF: Intel: hda-loader: Clarify the cl_dsp_init() flowsound/soc/sof/intel/hda-loader.c+4 -40 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchPierre-Louis BossartBard LiaoRanjani Sridharan
1/3R-b R-b R-b
2/3R-b R-b R-b
3/3R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/3] ASoC: SOF: Intel: Fix IMR boot race caused by early core booting

Hi,

After the revisited IMR sequence patch
2a68ff846164 ("ASoC: SOF: Intel: hda: Revisit IMR boot sequence")

we have started to see random boot issues manifesting in ghost reply messages from the DSP for a never sent message.
It turned out that an earlier commit:
d416519982cb ("ASoC: SOF: hda: don't use the core op for power up/power down")

replaced the core power up step with a full blown core power up + enable call. The result was that we have booted the core before we would place the message to the ROM code and based on luck and timing it got received by the (IMR) booted firmware or in between ROM and firmware boot.

Mark, can you queue this series for 5.19 as the 2a68ff846164 is in rc1 to make sure that we fix this random issue?

Regards,
Peter
---
Peter Ujfalusi (3):
ASoC: SOF: Intel: hda-dsp: Expose hda_dsp_core_power_up()
ASoC: SOF: Intel: hda-loader: Make sure that the fw load sequence is
followed
ASoC: SOF: Intel: hda-loader: Clarify the cl_dsp_init() flow

 sound/soc/sof/intel/hda-dsp.c    | 10 +++++++++-
 sound/soc/sof/intel/hda-loader.c | 10 +++++-----
 sound/soc/sof/intel/hda.h        |  1 +
 3 files changed, 15 insertions(+), 6 deletions(-)
Signature · 1 line
2.36.1