Skip to content

qemu/qsd: Unlink absolute PID file path

Hanna Reitz qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3qsd: Unlink absolute PID file pathstorage-daemon/qemu-storage-daemon.c+10 -11 reply
2/3vl: Conditionally register PID file unlink notifiersoftmmu/vl.c+9 -91 reply
3/3vl: Unlink absolute PID file pathsoftmmu/vl.c+26 -41 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchDaniel P. Berrangé
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] qemu/qsd: Unlink absolute PID file path

Hi,

QEMU (the system emulator) and the storage daemon (QSD) write their PID to the given file when you specify --pidfile. They keep the path around and register exit handlers (QEMU uses an exit notifier, QSD an atexit() function) to unlink this file when the process terminates. These handlers unlink precisely the path that the user has specified via --pidfile, so if it was a relative path and the process has at any point changed its working directory, the path no longer points to the PID file, and so the unlink() will fail (or worse).

When using --daemonize, the process will always change its working directory to /, so this problem basically always appears when using --daemonize and --pidfile in conjunction.

(It gets even worse with QEMU’s --chroot, but I’m not sure whether there’s any trivial fix for that (whether chroot is used or not is confined to os-posix.c, so this would need to be externally visible; and I guess the plain would be to skip the unlink() in that case?), so I’d rather just skip that for now... :/)

We can fix the problem by running realpath() once the PID file has been created, so we get an absolute path that we can unlink in the exit handler. This is done here.

(Another way to fix this might be to open the directory the PID file is in, keep the FD around, and use unlinkat() in the exit handler. I couldn’t see any real benefit for this, though, so I didn’t go that route. It might be beneficial for the --chroot case, but then again, precisely in that case we probably don’t want to keep random directory FDs around.)

Hanna Reitz (3):
qsd: Unlink absolute PID file path
vl: Conditionally register PID file unlink notifier
vl: Unlink absolute PID file path

 softmmu/vl.c                         | 42 +++++++++++++++++++++-------
 storage-daemon/qemu-storage-daemon.c | 11 +++++++-
 2 files changed, 42 insertions(+), 11 deletions(-)
Signature · 1 line
2.35.3