Skip to content

media: atomisp: Various hmm and other cleanups

Hans de Goede linux-media linux-staging 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest40 patches 1 replyIn review
  2. v140 patches 9 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/40media: atomisp: remove the unused RAW_BUF_STRIDE macrodrivers/staging/media/atomisp/pci/isp/modes/interface/isp_const.h+0 -60 replies
2/40media: atomisp: remove unused ia_css_frame_allocate_contiguous*() functionsdrivers/staging/media/atomisp/pci/ia_css_frame_public.h drivers/staging/media/atomisp/pci/runtime/frame/src/frame.c+0 -810 replies
3/40media: atomisp: drop contiguous argument from ia_css_frame_allocate_with_buffer_size()drivers/staging/media/atomisp/pci/runtime/frame/interface/ia_css_frame.h drivers/staging/media/atomisp/pci/runtime/frame/src/frame.c drivers/staging/media/atomisp/pci/sh_css_mipi.c+6 -120 replies
4/40media: atomisp: drop contiguous argument from frame_allocate_with_data()drivers/staging/media/atomisp/pci/runtime/frame/src/frame.c+4 -60 replies
5/40media: atomisp: drop contiguous argument from frame_create()drivers/staging/media/atomisp/pci/runtime/frame/src/frame.c+2 -60 replies
6/40media: atomisp: drop IA_CSS_FRAME_FORMAT_MIPI support from ia_css_frame_init_planes()drivers/staging/media/atomisp/pci/runtime/frame/src/frame.c+3 -270 replies
7/40media: atomisp: drop contiguous flag from struct ia_css_framedrivers/staging/media/atomisp/pci/ia_css_frame_public.h drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c drivers/staging/media/atomisp/pci/runtime/frame/src/frame.c +1 more+1 -130 replies
8/40media: atomisp: drop ATOMISP_MAP_FLAG_CONTIGUOUSdrivers/staging/media/atomisp/include/linux/atomisp.h drivers/staging/media/atomisp/pci/hmm/hmm.c+1 -40 replies
9/40media: atomisp: remove hmm_pool_[un]register()drivers/staging/media/atomisp/include/hmm/hmm.h drivers/staging/media/atomisp/pci/atomisp_fops.c drivers/staging/media/atomisp/pci/atomisp_v4l2.c +1 more+0 -640 replies
10/40media: atomisp: remove dynamic and reserved pool codedrivers/staging/media/atomisp/Makefile drivers/staging/media/atomisp/pci/hmm/hmm_dynamic_pool.c drivers/staging/media/atomisp/pci/hmm/hmm_reserved_pool.c+0 -4890 replies
11/40media: atomisp: remove hmm pool codedrivers/staging/media/atomisp/include/hmm/hmm.h drivers/staging/media/atomisp/include/hmm/hmm_bo.h drivers/staging/media/atomisp/include/hmm/hmm_pool.h +2 more+8 -2450 replies
12/40media: atomisp: remove hmm_mem_statsdrivers/staging/media/atomisp/include/hmm/hmm.h drivers/staging/media/atomisp/include/hmm/hmm_common.h drivers/staging/media/atomisp/pci/atomisp_drvfs.c +3 more+1 -830 replies
13/40media: atomisp: remove pool related kernel cmdline optionsdrivers/staging/media/atomisp/include/hmm/hmm.h drivers/staging/media/atomisp/pci/atomisp_v4l2.c+0 -190 replies
14/40media: atomisp: remove unused attribute argument from ia_css_frame_map()drivers/staging/media/atomisp/pci/atomisp_ioctl.c drivers/staging/media/atomisp/pci/ia_css_frame_public.h drivers/staging/media/atomisp/pci/runtime/frame/src/frame.c+2 -60 replies
15/40media: atomisp: drop hmm_page_typedrivers/staging/media/atomisp/include/hmm/hmm_bo.h drivers/staging/media/atomisp/pci/hmm/hmm_bo.c+15 -340 replies
16/40media: atomisp: removed unused hmm_bo_get_page_info() functiondrivers/staging/media/atomisp/include/hmm/hmm_bo.h drivers/staging/media/atomisp/pci/hmm/hmm_bo.c+0 -320 replies
17/40media: atomisp: remove bogus comment above hmm_bo_allocated() prototypedrivers/staging/media/atomisp/include/hmm/hmm_bo.h+0 -70 replies
18/40media: atomisp: remove private acceleration ioctlsdrivers/staging/media/atomisp/include/linux/atomisp.h drivers/staging/media/atomisp/pci/atomisp_acc.c drivers/staging/media/atomisp/pci/atomisp_acc.h +2 more+0 -6770 replies
19/40media: atomisp: remove atomisp_acc.cdrivers/staging/media/atomisp/Makefile drivers/staging/media/atomisp/pci/atomisp_acc.c drivers/staging/media/atomisp/pci/atomisp_acc.h +7 more+5 -3470 replies
20/40media: atomisp: remove unused atomisp_*css_* functionsdrivers/staging/media/atomisp/pci/atomisp_compat.h drivers/staging/media/atomisp/pci/atomisp_compat_css20.c drivers/staging/media/atomisp/pci/atomisp_subdev.h+0 -2430 replies
21/40media: atomisp: asc.acc.pipeline is always NULLdrivers/staging/media/atomisp/pci/atomisp_cmd.c drivers/staging/media/atomisp/pci/atomisp_compat_css20.c drivers/staging/media/atomisp/pci/atomisp_ioctl.c +1 more+1 -120 replies
22/40media: atomisp: remove no longer used atomisp_css_acc_done() functiondrivers/staging/media/atomisp/pci/atomisp_compat.h drivers/staging/media/atomisp/pci/atomisp_compat_css20.c drivers/staging/media/atomisp/pci/atomisp_subdev.h+0 -110 replies
23/40media: atomisp: remove atomisp_is_acc_enabled()drivers/staging/media/atomisp/pci/atomisp_cmd.c drivers/staging/media/atomisp/pci/atomisp_ioctl.c drivers/staging/media/atomisp/pci/atomisp_ioctl.h+2 -80 replies
24/40media: atomisp: drop unused ATOMISP_ACC_FW_LOAD_* definesdrivers/staging/media/atomisp/include/linux/atomisp.h+0 -120 replies
25/40media: atomisp: drop ATOMISP_MAP_FLAG_CLEAREDdrivers/staging/media/atomisp/include/linux/atomisp.h drivers/staging/media/atomisp/pci/hmm/hmm.c drivers/staging/media/atomisp/pci/sh_css_params.c+10 -120 replies
26/40media: atomisp: drop unused ATOMISP_MAP_FLAG_* flagsdrivers/staging/media/atomisp/include/hmm/hmm_bo.h drivers/staging/media/atomisp/include/linux/atomisp.h drivers/staging/media/atomisp/pci/hmm/hmm.c +1 more+18 -250 replies
27/40media: atomisp: remove unused hmm address translation functionsdrivers/staging/media/atomisp/include/hmm/hmm.h drivers/staging/media/atomisp/pci/hmm/hmm.c+0 -310 replies
28/40media: atomisp: add hmm_create_from_userdata() helperdrivers/staging/media/atomisp/include/hmm/hmm.h drivers/staging/media/atomisp/pci/hmm/hmm.c drivers/staging/media/atomisp/pci/runtime/frame/src/frame.c+7 -10 replies
29/40media: atomisp: Simplify hmm_alloc() callsdrivers/staging/media/atomisp/include/hmm/hmm.h drivers/staging/media/atomisp/pci/hmm/hmm.c drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c +7 more+33 -430 replies
30/40media: atomisp: drop highmem var/arg from the hmm codedrivers/staging/media/atomisp/include/hmm/hmm_bo.h drivers/staging/media/atomisp/pci/hmm/hmm.c drivers/staging/media/atomisp/pci/hmm/hmm_bo.c+6 -150 replies
31/40media: atomisp: drop HMM_BO_SHARE typedrivers/staging/media/atomisp/include/hmm/hmm_bo.h drivers/staging/media/atomisp/pci/hmm/hmm_bo.c+1 -50 replies
32/40media: atomisp: remove hmm_page_objectdrivers/staging/media/atomisp/include/hmm/hmm_bo.h drivers/staging/media/atomisp/pci/hmm/hmm.c drivers/staging/media/atomisp/pci/hmm/hmm_bo.c+22 -700 replies
33/40media: atomisp: fix __get_frame_info() error handlingdrivers/staging/media/atomisp/pci/atomisp_compat_css20.c+3 -10 replies
34/40media: atomisp: add error checking to atomisp_create_pipes_stream()drivers/staging/media/atomisp/pci/atomisp_compat.h drivers/staging/media/atomisp/pci/atomisp_compat_css20.c drivers/staging/media/atomisp/pci/atomisp_ioctl.c+29 -60 replies
35/40media: atomisp: add error logging to atomisp_destroy_pipes_stream_force()drivers/staging/media/atomisp/pci/atomisp_compat_css20.c+5 -20 replies
36/40media: atomisp: use atomisp_create_pipes_stream() in more placesdrivers/staging/media/atomisp/pci/atomisp_compat_css20.c+4 -240 replies
37/40media: atomisp: use atomisp_css_update_stream() in more placesdrivers/staging/media/atomisp/pci/atomisp_compat_css20.c+6 -310 replies
38/40media: atomisp: use atomisp_destroy_pipes_stream_force() in more placesdrivers/staging/media/atomisp/pci/atomisp_compat_css20.c+5 -190 replies
39/40media: atomisp: remove force argument from __destroy_[stream[s]|pipe[s]]()drivers/staging/media/atomisp/pci/atomisp_compat_css20.c+11 -230 replies
40/40media: atomisp: Add a notes.txt filedrivers/staging/media/atomisp/notes.txt+30 -00 replies

Reviews trailers per patch

39 of 40 patches have a Reviewed-by or Acked-by.

PatchAndy Shevchenko
1/40R-b
2/40R-b
3/40R-b
4/40R-b
5/40R-b
6/40R-b
7/40R-b
8/40R-b
9/40
10/40R-b
11/40R-b
12/40R-b
13/40R-b
14/40R-b
15/40R-b
16/40R-b
17/40R-b
18/40R-b
19/40R-b
20/40R-b
21/40R-b
22/40R-b
23/40R-b
24/40R-b
25/40R-b
26/40R-b
27/40R-b
28/40R-b
29/40R-b
30/40R-b
31/40R-b
32/40R-b
33/40R-b
34/40R-b
35/40R-b
36/40R-b
37/40R-b
38/40R-b
39/40R-b
40/40R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/40] media: atomisp: Various hmm and other cleanups

Hi All,

Here is v2 of my atomisp hmm (and other) cleanups series. As mentioned in the coverletter of v1, this is part of slowly working towards porting the code to videobuf2 to add/fix mmap support.

v2 addresses a few small remarks from Andy and adds Andy's Reviewed-by to all the patches, thank you Andy!

Regards,

Hans

Hans de Goede (40):
media: atomisp: remove the unused RAW_BUF_STRIDE macro
media: atomisp: remove unused ia_css_frame_allocate_contiguous*()
functions
media: atomisp: drop contiguous argument from
ia_css_frame_allocate_with_buffer_size()
media: atomisp: drop contiguous argument from
frame_allocate_with_data()
media: atomisp: drop contiguous argument from frame_create()
media: atomisp: drop IA_CSS_FRAME_FORMAT_MIPI support from
ia_css_frame_init_planes()
media: atomisp: drop contiguous flag from struct ia_css_frame
media: atomisp: drop ATOMISP_MAP_FLAG_CONTIGUOUS
media: atomisp: remove hmm_pool_[un]register()
media: atomisp: remove dynamic and reserved pool code
media: atomisp: remove hmm pool code
media: atomisp: remove hmm_mem_stats
media: atomisp: remove pool related kernel cmdline options
media: atomisp: remove unused attribute argument from

    ia_css_frame_map()
  media: atomisp: drop hmm_page_type
  media: atomisp: removed unused hmm_bo_get_page_info() function
  media: atomisp: remove bogus comment above hmm_bo_allocated()
    prototype
  media: atomisp: remove private acceleration ioctls
  media: atomisp: remove atomisp_acc.c
  media: atomisp: remove unused atomisp_*css_* functions
  media: atomisp: asc.acc.pipeline is always NULL
  media: atomisp: remove no longer used atomisp_css_acc_done() function
  media: atomisp: remove atomisp_is_acc_enabled()
  media: atomisp: drop unused ATOMISP_ACC_FW_LOAD_* defines
  media: atomisp: drop ATOMISP_MAP_FLAG_CLEARED
  media: atomisp: drop unused ATOMISP_MAP_FLAG_* flags
  media: atomisp: remove unused hmm address translation functions
  media: atomisp: add hmm_create_from_userdata() helper
  media: atomisp: Simplify hmm_alloc() calls
  media: atomisp: drop highmem var/arg from the hmm code
  media: atomisp: drop HMM_BO_SHARE type
  media: atomisp: remove hmm_page_object
  media: atomisp: fix __get_frame_info() error handling
  media: atomisp: add error checking to atomisp_create_pipes_stream()
  media: atomisp: add error logging to
    atomisp_destroy_pipes_stream_force()
  media: atomisp: use atomisp_create_pipes_stream() in more places
  media: atomisp: use atomisp_css_update_stream() in more places
  media: atomisp: use atomisp_destroy_pipes_stream_force() in more
    places
  media: atomisp: remove force argument from
    __destroy_[stream[s]|pipe[s]]()

media: atomisp: Add a notes.txt file

 drivers/staging/media/atomisp/Makefile        |   3 -
 .../staging/media/atomisp/include/hmm/hmm.h   |  32 +-
 .../media/atomisp/include/hmm/hmm_bo.h        |  37 +-
 .../media/atomisp/include/hmm/hmm_common.h    |  26 -
 .../media/atomisp/include/hmm/hmm_pool.h      | 116 ----
 .../media/atomisp/include/linux/atomisp.h     | 146 ----
 drivers/staging/media/atomisp/notes.txt       |  30 +
 .../staging/media/atomisp/pci/atomisp_acc.c   | 625 ------------------
 .../staging/media/atomisp/pci/atomisp_acc.h   | 120 ----
 .../staging/media/atomisp/pci/atomisp_cmd.c   |  33 +-
 .../media/atomisp/pci/atomisp_compat.h        |  29 +-
 .../media/atomisp/pci/atomisp_compat_css20.c  | 365 ++--------
 .../atomisp/pci/atomisp_compat_ioctl32.h      |  58 --
 .../staging/media/atomisp/pci/atomisp_drvfs.c |   7 +-
 .../staging/media/atomisp/pci/atomisp_fops.c  |  13 -
 .../staging/media/atomisp/pci/atomisp_ioctl.c |  73 +-
 .../staging/media/atomisp/pci/atomisp_ioctl.h |   1 -
 .../media/atomisp/pci/atomisp_subdev.c        |   3 -
 .../media/atomisp/pci/atomisp_subdev.h        |  10 -
 .../staging/media/atomisp/pci/atomisp_v4l2.c  |  32 -
 drivers/staging/media/atomisp/pci/hmm/hmm.c   | 186 +-----
 .../staging/media/atomisp/pci/hmm/hmm_bo.c    | 261 ++------
 .../media/atomisp/pci/hmm/hmm_dynamic_pool.c  | 234 -------
 .../media/atomisp/pci/hmm/hmm_reserved_pool.c | 253 -------
 .../media/atomisp/pci/ia_css_frame_public.h   |  40 --
 .../kernels/sdis/sdis_1.0/ia_css_sdis.host.c  |   2 +-
 .../kernels/sdis/sdis_2/ia_css_sdis2.host.c   |   2 +-
 .../pci/isp/modes/interface/isp_const.h       |   6 -
 .../pci/runtime/debug/src/ia_css_debug.c      |   2 -
 .../runtime/frame/interface/ia_css_frame.h    |   7 +-
 .../atomisp/pci/runtime/frame/src/frame.c     | 105 +--
 .../pci/runtime/isp_param/src/isp_param.c     |   2 +-
 .../atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c  |   3 +-
 .../atomisp/pci/runtime/spctrl/src/spctrl.c   |   2 +-
 drivers/staging/media/atomisp/pci/sh_css.c    |   5 -
 .../media/atomisp/pci/sh_css_firmware.c       |   2 +-
 .../staging/media/atomisp/pci/sh_css_mipi.c   |   3 +-
 .../staging/media/atomisp/pci/sh_css_params.c |  47 +-
 38 files changed, 205 insertions(+), 2716 deletions(-)
 delete mode 100644 drivers/staging/media/atomisp/include/hmm/hmm_pool.h
 create mode 100644 drivers/staging/media/atomisp/notes.txt
 delete mode 100644 drivers/staging/media/atomisp/pci/atomisp_acc.c
 delete mode 100644 drivers/staging/media/atomisp/pci/atomisp_acc.h
 delete mode 100644 drivers/staging/media/atomisp/pci/hmm/hmm_dynamic_pool.c
 delete mode 100644 drivers/staging/media/atomisp/pci/hmm/hmm_reserved_pool.c
Signature · 1 line
2.36.0