Skip to content

Improve reliability of VM tests

John Snow qemu-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest12 patches 13 repliesIn review
  2. v313 patches 17 repliesSuperseded
  3. v210 patches 14 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v15 patches13 repliesSuperseded

Changes in v4 from the cover letter

- Addressed concern by Marc-Andre in patch 01.
- Squashed Ubuntu patches (rth)

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12qga: treat get-guest-fsinfo as "best effort"qga/commands-posix.c+9 -11 reply
2/12tests/vm: use 'cp' instead of 'ln' for temporary vm imagestests/vm/centos+1 -11 reply
3/12tests/vm: switch CentOS 8 to CentOS 8 Streamtests/vm/centos+3 -31 reply
4/12tests/vm: switch centos.aarch64 to CentOS 8 Streamtests/vm/centos.aarch64+24 -1501 reply
5/12tests/vm: upgrade Ubuntu 18.04 VM to 20.04tests/vm/ubuntu.aarch64+7 -31 reply
6/12tests/vm: remove ubuntu.i386 VM testtests/vm/Makefile.include tests/vm/ubuntu.i386+1 -421 reply
7/12tests/vm: remove duplicate 'centos' VM testtests/vm/Makefile.include+1 -11 reply
8/12tests/vm: add 1GB extra memory per coretests/vm/basevm.py+5 -01 reply
9/12tests/vm: Remove docker cross-compile test from CentOS VMtests/vm/centos+0 -11 reply
10/12tests/qemu-iotests: hotfix for 307, 223 outputtests/qemu-iotests/223.out tests/qemu-iotests/307.out+4 -40 replies
11/12tests/qemu-iotests: skip 108 when FUSE is not loadedtests/qemu-iotests/108+5 -00 replies
12/12iotests: fix copy-before-write for macOS and FreeBSDtests/qemu-iotests/tests/copy-before-write+5 -00 replies

Reviews trailers per patch

9 of 12 patches have a Reviewed-by or Acked-by.

PatchDaniel P. BerrangéThomas HuthMarc-André LureauRichard Henderson
1/12R-b
2/12R-b R-b R-b
3/12R-b R-b R-b
4/12R-b R-b
5/12R-b R-b
6/12R-b R-b R-b
7/12R-b R-b R-b
8/12R-b A-b
9/12R-b R-b
10/12
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v4 thread

Cover letter [PATCH v4 00/12] Improve reliability of VM tests

Note: patches 10-12 are included for testing simplicity, they shouldn't be merged. They will be included in a forthcoming block PR.

V4:

- Addressed concern by Marc-Andre in patch 01.
- Squashed Ubuntu patches (rth)

This patch series attempts to improve the reliability of several of the VM test targets. In particular, both CentOS 8 tests are non-functional because CentOS 8 was EOL at the beginning of this calendar year, with repositories and mirrors going offline.

I also remove the ubuntu.i386 test because we no longer support Ubuntu 18.04 nor do we have explicit need of an i386 build test.

After this series, I am able to successfully run every VM target on an x86_64 host, except:

- ubuntu.aarch64: Hangs often during testing, see below.
- centos.aarch64: Hangs often during testing, see below.
- haiku.x86_64: Build failures not addressed by this series, see
https://lists.gnu.org/archive/html/qemu-devel/2022-06/msg02103.html

The unit tests that I see fail most often under aarch64 are:

- virtio-net-failover: Seems to like to hang on openbsd
- migration-test: Tends to hang under aarch64 tcg

Future work (next version? next series?);

- Try to get centos.aarch64 working reliably under TCG
- Upgrade ubuntu.aarch64 to 20.04 after fixing centos.aarch64
- Fix the Haiku build test, if possible.
- Ensure I can reliably run and pass "make vm-build-all". (Remove VMs from this recipe if necessary.)

John Snow (11):
qga: treat get-guest-fsinfo as "best effort" tests/vm: use 'cp' instead of 'ln' for temporary vm images tests/vm: switch CentOS 8 to CentOS 8 Stream tests/vm: switch centos.aarch64 to CentOS 8 Stream tests/vm: upgrade Ubuntu 18.04 VM to 20.04 tests/vm: remove ubuntu.i386 VM test
tests/vm: remove duplicate 'centos' VM test tests/vm: add 1GB extra memory per core tests/vm: Remove docker cross-compile test from CentOS VM tests/qemu-iotests: hotfix for 307, 223 output tests/qemu-iotests: skip 108 when FUSE is not loaded

Vladimir Sementsov-Ogievskiy (1):
iotests: fix copy-before-write for macOS and FreeBSD

 qga/commands-posix.c                       |  10 +-
 tests/qemu-iotests/108                     |   5 +
 tests/qemu-iotests/223.out                 |   4 +-
 tests/qemu-iotests/307.out                 |   4 +-
 tests/qemu-iotests/tests/copy-before-write |   5 +
 tests/vm/Makefile.include                  |   5 +-
 tests/vm/basevm.py                         |   5 +
 tests/vm/centos                            |   9 +-
 tests/vm/centos.aarch64                    | 174 +++------------------
 tests/vm/ubuntu.aarch64                    |  10 +-
 tests/vm/ubuntu.i386                       |  40 -----
 11 files changed, 65 insertions(+), 206 deletions(-)
 delete mode 100755 tests/vm/ubuntu.i386
Signature · 1 line
2.34.3