Vimc code readability improvements
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 8 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | media: vimc: expand the names of vimc entity typesdrivers/ drivers/ drivers/ +4 more | +652 | 5 replies | |
| 2/3 | media: vimc: enumerate data link entities for claritydrivers/ | +28 | 1 reply | |
| 3/3 | media: vimc: use data link entities enum to index the ent_config arraydrivers/ | +11 | 2 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Shuah Khan |
|---|---|
| 1/3 | R-b |
| 2/3 | R-b |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/3] Vimc code readability improvements
These patches are supposed to be applied on top of the not yet merged vimc ancillary patch (65b957cb0a926ee178100f4af8fea0e516fc7604).
While the vimc ancillary lens patch series was being reviewed, it was made apparent that there were a few issues with the vimc code clarity:
- The data link entity names were unclear, leading to a possible confusion with len and lens, e.g. vimc_len_type refers to the lens.
- Raw index numbers in the VIMC_DATA_LINK declarations made understanding that code hard.
This patch series aims to solve these problems.
Link to lens patch review:
https://lore.kernel.org/r/165037056336.2548121.16870543641391713634@Monstersaurus
Daniel Oakley (3):
media: vimc: expand the names of vimc entity types
media: vimc: enumerate data link entities for clarity
media: vimc: use data link entities enum to index the ent_config array
.../media/test-drivers/vimc/vimc-capture.c | 270 ++++++------ drivers/media/test-drivers/vimc/vimc-common.h | 10 +- drivers/media/test-drivers/vimc/vimc-core.c | 80 ++-- .../media/test-drivers/vimc/vimc-debayer.c | 393 +++++++++--------- drivers/media/test-drivers/vimc/vimc-lens.c | 82 ++-- drivers/media/test-drivers/vimc/vimc-scaler.c | 216 +++++----- drivers/media/test-drivers/vimc/vimc-sensor.c | 307 +++++++------- 7 files changed, 691 insertions(+), 667 deletions(-)
base-commit: 65b957cb0a926ee178100f4af8fea0e516fc7604
Signature · 1 line
2.36.1