cover-letter: Update vfio_pin/unpin_pages API
Status from this message: Applied to vfio next branch for v5.20. Thanks,
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest10 patches 2 repliesApplied
- v39 of 10 patches 10 repliesSuperseded
- v29 patches 41 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 6 patches | 25 replies | Superseded |
Changes in v4 from the cover letter · 19 lines
* Dropped double-shifting at two gvt_unpin_guest_page calls, fixing a bug that's discovered by Alex
* Added Reviewed-by from Anthony Krowiak
* Rebased on top of linux-vfio's next
v3: https://lore.kernel.org/kvm/[email protected]/
* Added a patch to replace roundup with DIV_ROUND_UP in i915 gvt
* Dropped the "driver->ops->unpin_pages" and NULL checks in PATCH-1
* Changed to use WARN_ON and separate into lines in PATCH-1
* Replaced "guest" words with "user" and fix typo in PATCH-5
* Updated commit log of PATCH-1, PATCH-6, and PATCH-10
* Added Reviewed/Acked-by from Christoph, Jason, Kirti, Kevin and Eric
* Added Tested-by from Terrence (i915) and Eric (s390)
v2: https://lore.kernel.org/kvm/[email protected]/
* Added a patch to make vfio_unpin_pages return void
* Added two patches to remove PFN list from two s390 callers
* Renamed "phys_page" parameter to "pages" for vfio_pin_pages
* Updated commit log of kmap_local_page() patch
* Added Harald's "Reviewed-by" to pa_ind patch
* Rebased on top of Alex's extern removal path
v1: https://lore.kernel.org/kvm/[email protected]/
Patches in v4 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | vfio: Make vfio_unpin_pages() return voidDocumentation/ drivers/ drivers/ +3 more | +18 | 0 replies | |
| 2/10 | drm/i915/gvt: Replace roundup with DIV_ROUND_UPdrivers/ | +2 | 0 replies | |
| 3/10 | vfio/ap: Pass in physical address of ind to ap_aqic()arch/ drivers/ drivers/ | +8 | 0 replies | |
| 4/10 | vfio/ccw: Only pass in contiguous pagesdrivers/ | +56 | 0 replies | |
| 5/10 | vfio: Pass in starting IOVA to vfio_pin/unpin_pages APIDocumentation/ drivers/ drivers/ +5 more | +37 | 0 replies | |
| 6/10 | vfio/ap: Change saved_pfn to saved_iovadrivers/ drivers/ | +19 | 0 replies | |
| 7/10 | vfio/ccw: Change pa_pfn list to pa_iova listdrivers/ | +64 | 0 replies | |
| 8/10 | vfio: Rename user_iova of vfio_dma_rw()drivers/ include/ | +4 | 0 replies | |
| 9/10 | vfio/ccw: Add kmap_local_page() for memcpydrivers/ | +6 | 0 replies | |
| 10/10 | vfio: Replace phys_pfn with pages for vfio_pin_pages()Documentation/ drivers/ drivers/ +5 more | +36 | 0 replies |
Reviews trailers per patch
9 of 10 patches have a Reviewed-by or Acked-by.
| Patch | Terrence Xu | Christoph Hellwig | Jason Gunthorpe | Kirti Wankhede | Harald Freudenberger | Eric Farman | Kevin Tian | Tony Krowiak |
|---|---|---|---|---|---|---|---|---|
| Series | T-b | |||||||
| 1/10 | T-b | R-b | R-b | R-b | ||||
| 2/10 | T-b | |||||||
| 3/10 | R-b | R-b | T-b | |||||
| 4/10 | R-b | R-b T-b | ||||||
| 5/10 | T-b | R-b | R-b | A-b T-b | R-b | R-b | ||
| 6/10 | R-b | T-b | R-b | |||||
| 7/10 | R-b | R-b T-b | ||||||
| 8/10 | T-b | R-b | R-b | T-b | R-b | |||
| 9/10 | R-b | A-b T-b | ||||||
| 10/10 | T-b | R-b | R-b | R-b | A-b T-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 8 reviewers.
Cover letter [PATCH v4 00/10] cover-letter: Update vfio_pin/unpin_pages API
This is a preparatory series for IOMMUFD v2 patches. It prepares for replacing vfio_iommu_type1 implementations of vfio_pin/unpin_pages() with IOMMUFD version.
There's a gap between these two versions: the vfio_iommu_type1 version inputs a non-contiguous PFN list and outputs another PFN list for the pinned physical page list, while the IOMMUFD version only supports a contiguous address input by accepting the starting IO virtual address of a set of pages to pin and by outputting to a physical page list.
The nature of existing callers mostly aligns with the IOMMUFD version, except s390's vfio_ccw_cp code where some additional change is needed along with this series. Overall, updating to "iova" and "phys_page" does improve the caller side to some extent.
Also fix a misuse of physical address and virtual address in the s390's crypto code. And update the input naming at the adjacent vfio_dma_rw().
This is on github:
https://github.com/nicolinc/iommufd/commits/vfio_pin_pages-v4
Terrence has tested this series on i915; Eric has tested on s390.
Thanks!
Changelog
v4:
* Dropped double-shifting at two gvt_unpin_guest_page calls, fixing a bug that's discovered by Alex
* Added Reviewed-by from Anthony Krowiak
* Rebased on top of linux-vfio's next
v3: https://lore.kernel.org/kvm/[email protected]/
* Added a patch to replace roundup with DIV_ROUND_UP in i915 gvt
* Dropped the "driver->ops->unpin_pages" and NULL checks in PATCH-1
* Changed to use WARN_ON and separate into lines in PATCH-1
* Replaced "guest" words with "user" and fix typo in PATCH-5
* Updated commit log of PATCH-1, PATCH-6, and PATCH-10
* Added Reviewed/Acked-by from Christoph, Jason, Kirti, Kevin and Eric
* Added Tested-by from Terrence (i915) and Eric (s390)
v2: https://lore.kernel.org/kvm/[email protected]/
* Added a patch to make vfio_unpin_pages return void
* Added two patches to remove PFN list from two s390 callers
* Renamed "phys_page" parameter to "pages" for vfio_pin_pages
* Updated commit log of kmap_local_page() patch
* Added Harald's "Reviewed-by" to pa_ind patch
* Rebased on top of Alex's extern removal path
v1: https://lore.kernel.org/kvm/[email protected]/
Nicolin Chen (10):
vfio: Make vfio_unpin_pages() return void drm/i915/gvt: Replace roundup with DIV_ROUND_UP vfio/ap: Pass in physical address of ind to ap_aqic() vfio/ccw: Only pass in contiguous pages
vfio: Pass in starting IOVA to vfio_pin/unpin_pages API vfio/ap: Change saved_pfn to saved_iova vfio/ccw: Change pa_pfn list to pa_iova list
vfio: Rename user_iova of vfio_dma_rw() vfio/ccw: Add kmap_local_page() for memcpy
vfio: Replace phys_pfn with pages for vfio_pin_pages()
.../driver-api/vfio-mediated-device.rst | 6 +- arch/s390/include/asm/ap.h | 6 +- drivers/gpu/drm/i915/gvt/kvmgt.c | 45 ++-- drivers/s390/cio/vfio_ccw_cp.c | 195 +++++++++++------- drivers/s390/crypto/ap_queue.c | 2 +- drivers/s390/crypto/vfio_ap_ops.c | 54 +++-- drivers/s390/crypto/vfio_ap_private.h | 4 +- drivers/vfio/vfio.c | 54 ++--- drivers/vfio/vfio.h | 8 +- drivers/vfio/vfio_iommu_type1.c | 45 ++-- include/linux/vfio.h | 9 +- 11 files changed, 213 insertions(+), 215 deletions(-)
Signature · 1 line
2.17.1