Skip to content

efivar: remove inappropriate uses of the efivar API

Ard Biesheuvel linux-efi linux-input linux-wireless 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4efi: avoid efivars layer when loading SSDTs from variablesdrivers/firmware/efi/efi.c+41 -620 replies
2/4Input: applespi - avoid efivars API and invoke EFI services directlydrivers/input/keyboard/applespi.c+14 -281 reply
3/4iwlwifi: Switch to proper EFI variable store interfacedrivers/net/wireless/intel/iwlwifi/fw/uefi.c+32 -640 replies
4/4brcmfmac: Switch to appropriate helper to load EFI variable contentsdrivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c+8 -170 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchKalle Valo
SeriesA-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] efivar: remove inappropriate uses of the efivar API

The efivar layer is a caching non-volatile variable store abstraction that is normally backed by EFI, but in some cases, might be backed by Google SMI firmware interfaces instead.

It is mainly used by efivarfs and EFI pstore, both of which actually need the caching and abstraction properties. However, there are a few other occurrences where efivar is not necessary, or used in an invalid way. So let's fix this up, and remove some impediments to refactoring and cleaning up the efivars layer in the future.

Assuming there are no objections to these changes, I intend to queue them up in the EFI tree fairly soon, so that ongoing work depending on these changes can continue as well.

Cc Dmitry Torokhov <[email protected]>
Cc Arend van Spriel <[email protected]>
Cc Franky Lin <[email protected]>
Cc Hante Meuleman <[email protected]>
Cc Kalle Valo <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Eric Dumazet <[email protected]>
Cc Jakub Kicinski <[email protected]>
Cc Paolo Abeni <[email protected]>
Cc Gregory Greenman <[email protected]>

Ard Biesheuvel (4):
efi: avoid efivars layer when loading SSDTs from variables
Input: applespi - avoid efivars API and invoke EFI services directly
iwlwifi: Switch to proper EFI variable store interface
brcmfmac: Switch to appropriate helper to load EFI variable contents

 drivers/firmware/efi/efi.c                                  | 103 ++++++++------------
 drivers/input/keyboard/applespi.c                           |  42 +++-----
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c |  25 ++---
 drivers/net/wireless/intel/iwlwifi/fw/uefi.c                |  96 ++++++------------
 4 files changed, 95 insertions(+), 171 deletions(-)
Signature · 1 line
2.35.1