Skip to content

pnv-phb related cleanups

Daniel Henrique Barboza qemu-devel 2 versions – Applied

Status from this message: Queued in gitlab.com/danielhb/qemu/tree/ppc-next after fixing

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest8 patches 3 repliesApplied
  2. v29 patches 9 repliesSuperseded

Changes in v3 from the cover letter

- patch 03:
- set chassis and slot outside of root_port_realize()
- former patch 04 ("use dev instead of pci->qdev in root_port_realize()"):
- dropped due to changes in patch 03
- v2 link: https://lists.gnu.org/archive/html/qemu-devel/2022-06/msg03177.html

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/8ppc/pnv: move root port attach to pnv_phb4_realize()hw/pci-host/pnv_phb4.c hw/pci-host/pnv_phb4_pec.c+4 -30 replies
2/8ppc/pnv: attach phb3/phb4 root ports in QOM treehw/pci-host/pnv_phb3.c hw/pci-host/pnv_phb4.c hw/ppc/pnv.c +1 more+9 -40 replies
3/8ppc/pnv: assign pnv-phb-root-port chassis/slot earlierhw/pci-host/pnv_phb3.c hw/pci-host/pnv_phb4.c hw/ppc/pnv.c +1 more+19 -352 replies
4/8ppc/pnv: make pnv_ics_get() use the chip8->phbs[] arrayhw/ppc/pnv.c+11 -270 replies
5/8ppc/pnv: make pnv_ics_resend() use chip8->phbs[]hw/ppc/pnv.c+8 -140 replies
6/8ppc/pnv: make pnv_chip_power8_pic_print_info() use chip8->phbs[]hw/ppc/pnv.c+8 -140 replies
7/8ppc/pnv: remove 'INTERFACE_PCIE_DEVICE' from phb3 root bushw/pci-host/pnv_phb3.c+0 -40 replies
8/8ppc/pnv: remove 'INTERFACE_PCIE_DEVICE' from phb4 root bushw/pci-host/pnv_phb4.c+0 -40 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchFrederic BarratCédric Le Goater
1/8R-b R-b
2/8R-b R-b
3/8R-b R-b
4/8R-b R-b
5/8R-b R-b
6/8R-b
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/8] pnv-phb related cleanups

This version present changes in patch 03. We're now setting chassis and slot in pnv_phb_attach_root_port(), avoiding all the hassle of having to access the PHB object via bus->qbus.parent inside root_port_realize().

changes from v2:
- patch 03:
- set chassis and slot outside of root_port_realize()
- former patch 04 ("use dev instead of pci->qdev in root_port_realize()"):
- dropped due to changes in patch 03
- v2 link: https://lists.gnu.org/archive/html/qemu-devel/2022-06/msg03177.html

Daniel Henrique Barboza (8):
ppc/pnv: move root port attach to pnv_phb4_realize() ppc/pnv: attach phb3/phb4 root ports in QOM tree ppc/pnv: assign pnv-phb-root-port chassis/slot earlier ppc/pnv: make pnv_ics_get() use the chip8->phbs[] array ppc/pnv: make pnv_ics_resend() use chip8->phbs[] ppc/pnv: make pnv_chip_power8_pic_print_info() use chip8->phbs[] ppc/pnv: remove 'INTERFACE_PCIE_DEVICE' from phb3 root bus ppc/pnv: remove 'INTERFACE_PCIE_DEVICE' from phb4 root bus

 hw/pci-host/pnv_phb3.c     |  22 +-------
 hw/pci-host/pnv_phb4.c     |  24 ++-------
 hw/pci-host/pnv_phb4_pec.c |   3 --
 hw/ppc/pnv.c               | 102 ++++++++++++++++---------------------
 include/hw/ppc/pnv.h       |   3 +-
 5 files changed, 54 insertions(+), 100 deletions(-)
Signature · 1 line
2.36.1