Skip to content

mlxsw: Unified bridge conversion - part 1/6

Ido Schimmel netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 0 repliesApplied 13/13

Patches in v1 All 13 applied

#Subject and filesSizeRepliesApplied
1/13mlxsw: reg: Add 'flood_rsp' field to SFMR registerdrivers/net/ethernet/mellanox/mlxsw/reg.h+12 -00 repliesApplied
2/13mlxsw: reg: Add ingress RIF related fields to SFMR registerdrivers/net/ethernet/mellanox/mlxsw/reg.h+20 -00 repliesApplied
3/13mlxsw: reg: Add ingress RIF related fields to SVFA registerdrivers/net/ethernet/mellanox/mlxsw/reg.h+21 -10 repliesApplied
4/13mlxsw: reg: Add Switch Multicast Port to Egress VID Registerdrivers/net/ethernet/mellanox/mlxsw/reg.h+40 -00 repliesApplied
5/13mlxsw: Add SMPE related fields to SMID2 registerdrivers/net/ethernet/mellanox/mlxsw/reg.h drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c+24 -40 repliesApplied
6/13mlxsw: reg: Add SMPE related fields to SFMR registerdrivers/net/ethernet/mellanox/mlxsw/reg.h+20 -10 repliesApplied
7/13mlxsw: reg: Add VID related fields to SFD registerdrivers/net/ethernet/mellanox/mlxsw/reg.h+36 -10 repliesApplied
8/13mlxsw: reg: Add flood related field to SFMR registerdrivers/net/ethernet/mellanox/mlxsw/reg.h+10 -00 repliesApplied
9/13mlxsw: reg: Replace MID related fields in SFGC registerdrivers/net/ethernet/mellanox/mlxsw/port.h drivers/net/ethernet/mellanox/mlxsw/reg.h+9 -100 repliesApplied
10/13mlxsw: reg: Add Router Egress Interface to VID Registerdrivers/net/ethernet/mellanox/mlxsw/reg.h+59 -00 repliesApplied
11/13mlxsw: reg: Add egress FID field to RITR registerdrivers/net/ethernet/mellanox/mlxsw/reg.h+14 -20 repliesApplied
12/13mlxsw: Add support for egress FID classification after decapsulationdrivers/net/ethernet/mellanox/mlxsw/reg.h drivers/net/ethernet/mellanox/mlxsw/spectrum_fid.c+44 -90 repliesApplied
13/13mlxsw: reg: Add support for VLAN RIF as part of RITR registerdrivers/net/ethernet/mellanox/mlxsw/reg.h+26 -30 repliesApplied

Reviews trailers per patch

12 of 13 patches have a Reviewed-by or Acked-by.

PatchPetr MachataDanielle Ratson
1/13R-b
2/13R-b
3/13R-b
4/13R-b R-b
5/13
6/13R-b R-b
7/13R-b
8/13R-b
9/13R-b
10/13R-b
11/13R-b
12/13R-b R-b
13/13R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 00/13] mlxsw: Unified bridge conversion - part 1/6

This set starts converting mlxsw to the unified bridge model and mainly adds new device registers and extends existing ones that will be used in follow-up patchsets.

High-level summary
==================

The unified bridge model is a new way of managing low-level device objects such as filtering identifiers (FIDs). The conversion moves a lot of logic out of the device's firmware towards the driver, but its main selling point is that it allows to overcome various scalability issues related to the amount of entries that need to be programmed to the device.

The only (intended) user visible changes of the conversion are improvement in resource utilization and ability to support more router interfaces (RIFs) in Spectrum-{2,3}.

Details
=======

Commit 50853808ff4a ("Merge branch 'mlxsw-Prepare-for-VLAN-aware-bridge-w-VxLAN'") converted mlxsw to emulate 802.1Q FIDs (represent VLANs in a VLAN-aware bridge) using 802.1D FIDs (represent VLAN-unaware bridges). This was necessary because at that time VNI could not be assigned to 802.1Q FIDs, which effectively meant that mlxsw could not support VXLAN with VLAN-aware bridges.

The downside of this approach is that multiple {Port,VID}->FID entries are required in order to classify incoming traffic to a FID, as opposed to a single VID->FID entry that can be used with actual 802.1Q FIDs.

For example, if 10 ports are members in the same VLAN-aware bridge and the same 100 VLANs are configured on each port, then only 100 VID->FID entries are required with 802.1Q FIDs, whereas 1000 {Port,VID}->FID entries are required with emulated 802.1Q FIDs.

The above limitation is the result of various assumptions that were made in the design of the API that was exposed to software. In the unified bridge model the API is much more "raw" and therefore avoids these assumptions, allowing software to configure the device in a more efficient manner.

Amit Cohen (13):
mlxsw: reg: Add 'flood_rsp' field to SFMR register
mlxsw: reg: Add ingress RIF related fields to SFMR register
mlxsw: reg: Add ingress RIF related fields to SVFA register
mlxsw: reg: Add Switch Multicast Port to Egress VID Register
mlxsw: Add SMPE related fields to SMID2 register
mlxsw: reg: Add SMPE related fields to SFMR register
mlxsw: reg: Add VID related fields to SFD register
mlxsw: reg: Add flood related field to SFMR register
mlxsw: reg: Replace MID related fields in SFGC register
mlxsw: reg: Add Router Egress Interface to VID Register
mlxsw: reg: Add egress FID field to RITR register
mlxsw: Add support for egress FID classification after decapsulation
mlxsw: reg: Add support for VLAN RIF as part of RITR register

 drivers/net/ethernet/mellanox/mlxsw/port.h    |   2 -
 drivers/net/ethernet/mellanox/mlxsw/reg.h     | 353 ++++++++++++++++--
 .../ethernet/mellanox/mlxsw/spectrum_fid.c    |   4 +-
 .../mellanox/mlxsw/spectrum_switchdev.c       |   7 +-
 4 files changed, 335 insertions(+), 31 deletions(-)
Signature · 1 line
2.36.1