Skip to content

aborted fstests may leave frozen fs behind

Amir Goldstein fstests 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 2 repliesIn review
  2. v14 patches 19 repliesSuperseded

Changes in v2 from the cover letter

- Remove auto-cleanup in check
- Add more kill+wait in cleanups where needed
- Change the cleanup routines of the freeze_loops

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3fstests: add missing _require_freeze() to teststests/xfs/119 tests/xfs/318 tests/xfs/325 +3 more+9 -41 reply
2/3fstests: unfreeze fs on cleanup routinestests/generic/068 tests/generic/085 tests/generic/280 +9 more+71 -91 reply
3/3xfs/{422,517}: kill background jobs on test terminationtests/xfs/422 tests/xfs/517+53 -50 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchZorro Lang
1/3R-b
2/3R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] aborted fstests may leave frozen fs behind

Zorro,

As discussed on v1, this series fixes cleanup routines of freeze tests without adding auto-cleanup in check.

I also took a closer look at some test cleanups and handled the kill of background processes after unfreeze.

I tested that all the tests in the 'freeze' group that I modified run to completion with no regressions.

I did not try to interrupt all the rest of the tests, because interrupting a test at exact time that it is frozen is quite hard.

I did test that interrupting xfs/517 several times did not leave the fs frozen. Before the changes, it was rather easy to get it to leave a frozen fs behind, because the freeze_loop() keeps the fs frozen around half of the time that the test is running.

Thanks,
Amir.

Changes since v1:
- Remove auto-cleanup in check
- Add more kill+wait in cleanups where needed
- Change the cleanup routines of the freeze_loops

Amir Goldstein (3):
fstests: add missing _require_freeze() to tests
fstests: unfreeze fs on cleanup routines xfs/{422,517}: kill background jobs on test termination

 tests/generic/068 | 14 ++++++++++----
 tests/generic/085 |  3 +++
 tests/generic/280 | 13 ++++++++++++-
 tests/generic/390 |  8 +++++++-
 tests/generic/459 |  2 ++
 tests/generic/491 |  9 +++++++++
 tests/xfs/011     |  3 ++-
 tests/xfs/119     | 10 ++++++++++
 tests/xfs/297     | 11 +++++++++++
 tests/xfs/318     |  6 ++++--
 tests/xfs/325     |  6 ++++--
 tests/xfs/422     | 35 ++++++++++++++++++++++++++++++++---
 tests/xfs/438     |  4 +++-
 tests/xfs/517     | 27 ++++++++++++++++++++++++---
 14 files changed, 133 insertions(+), 18 deletions(-)
Signature · 1 line
2.25.1