Skip to content

RFC reduce the size of rnbd_clt_dev

Guoqing Jiang linux-block 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest6 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6rnbd-clt: open code send_msg_open in rnbd_clt_map_devicedrivers/block/rnbd/rnbd-clt.c+42 -22 replies
2/6rnbd-clt: don't free rsp in msg_open_conf for map scenariodrivers/block/rnbd/rnbd-clt.c+14 -41 reply
3/6rnbd-clt: kill read_only from struct rnbd_clt_devdrivers/block/rnbd/rnbd-clt.c drivers/block/rnbd/rnbd-clt.h+2 -71 reply
4/6rnbd-clt: reduce the size of struct rnbd_clt_devdrivers/block/rnbd/rnbd-clt.c drivers/block/rnbd/rnbd-clt.h+55 -741 reply
5/6rnbd-clt: adjust the layout of struct rnbd_clt_devdrivers/block/rnbd/rnbd-clt.h+2 -21 reply
6/6rnbd-clt: refactor rnbd_clt_change_capacitydrivers/block/rnbd/rnbd-clt-sysfs.c drivers/block/rnbd/rnbd-clt.c drivers/block/rnbd/rnbd-clt.h+14 -142 replies

Reviews trailers per patch

4 of 6 patches have a Reviewed-by or Acked-by.

PatchJack Wang
1/6
2/6A-b
3/6A-b
4/6A-b
5/6A-b
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC PATCH 0/6] reduce the size of rnbd_clt_dev

Hi,

The struct rnbd_clt_dev added some members (wc, fua and max_hw_sectors etc) which are used to set up gendisk and request_queue, but seems only map scenario need to setup them since rnbd_client_setup_device is not called from remap path.

Previously, pahole reports.

	/* size: 272, cachelines: 5, members: 29 */
	/* sum members: 259, holes: 4, sum holes: 13 */
	/* last cacheline: 16 bytes */

After the series, it changes to

	/* size: 224, cachelines: 4, members: 17 */
	/* last cacheline: 32 bytes */

Please review.

Thanks,
Guoqing

Guoqing Jiang (6):
rnbd-clt: open code send_msg_open in rnbd_clt_map_device
rnbd-clt: don't free rsp in msg_open_conf for map scenario
rnbd-clt: kill read_only from struct rnbd_clt_dev
rnbd-clt: reduce the size of struct rnbd_clt_dev
rnbd-clt: adjust the layout of struct rnbd_clt_dev
rnbd-clt: refactor rnbd_clt_change_capacity

 drivers/block/rnbd/rnbd-clt-sysfs.c |   2 +-
 drivers/block/rnbd/rnbd-clt.c       | 202 +++++++++++++++++-----------
 drivers/block/rnbd/rnbd-clt.h       |  18 +--
 3 files changed, 124 insertions(+), 98 deletions(-)
Signature · 1 line
2.34.1