RFC reduce the size of rnbd_clt_dev
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest6 patches 10 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | rnbd-clt: open code send_msg_open in rnbd_clt_map_devicedrivers/ | +42 | 2 replies | |
| 2/6 | rnbd-clt: don't free rsp in msg_open_conf for map scenariodrivers/ | +14 | 1 reply | |
| 3/6 | rnbd-clt: kill read_only from struct rnbd_clt_devdrivers/ drivers/ | +2 | 1 reply | |
| 4/6 | rnbd-clt: reduce the size of struct rnbd_clt_devdrivers/ drivers/ | +55 | 1 reply | |
| 5/6 | rnbd-clt: adjust the layout of struct rnbd_clt_devdrivers/ | +2 | 1 reply | |
| 6/6 | rnbd-clt: refactor rnbd_clt_change_capacitydrivers/ drivers/ drivers/ | +14 | 2 replies |
Reviews trailers per patch
4 of 6 patches have a Reviewed-by or Acked-by.
| Patch | Jack Wang |
|---|---|
| 1/6 | |
| 2/6 | A-b |
| 3/6 | A-b |
| 4/6 | A-b |
| 5/6 | A-b |
| 6/6 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFC PATCH 0/6] reduce the size of rnbd_clt_dev
Hi,
The struct rnbd_clt_dev added some members (wc, fua and max_hw_sectors etc) which are used to set up gendisk and request_queue, but seems only map scenario need to setup them since rnbd_client_setup_device is not called from remap path.
Previously, pahole reports.
/* size: 272, cachelines: 5, members: 29 */ /* sum members: 259, holes: 4, sum holes: 13 */ /* last cacheline: 16 bytes */
After the series, it changes to
/* size: 224, cachelines: 4, members: 17 */ /* last cacheline: 32 bytes */
Please review.
Thanks,
Guoqing
Guoqing Jiang (6):
rnbd-clt: open code send_msg_open in rnbd_clt_map_device
rnbd-clt: don't free rsp in msg_open_conf for map scenario
rnbd-clt: kill read_only from struct rnbd_clt_dev
rnbd-clt: reduce the size of struct rnbd_clt_dev
rnbd-clt: adjust the layout of struct rnbd_clt_dev
rnbd-clt: refactor rnbd_clt_change_capacity
drivers/block/rnbd/rnbd-clt-sysfs.c | 2 +- drivers/block/rnbd/rnbd-clt.c | 202 +++++++++++++++++----------- drivers/block/rnbd/rnbd-clt.h | 18 +-- 3 files changed, 124 insertions(+), 98 deletions(-)
Signature · 1 line
2.34.1