Skip to content

serial: A few cleanups

Ilpo Järvinen linux-amlogic linux-arm-kernel linux-arm-msm linux-mips linux-serial lkml sparclinux 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 1 replyIn review
  2. v26 patches 12 repliesSuperseded
  3. v16 patches 1 replySuperseded

Changes in v3 from the cover letter

- Remove one useless comment
- Improve changelog texts

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6serial: msm: Convert container_of UART_TO_MSM to static inlinedrivers/tty/serial/msm_serial.c+26 -230 replies
2/6serial: msm: Rename UART_* defines to MSM_UART_*drivers/tty/serial/msm_serial.c+250 -2510 replies
3/6serial: Use bits for UART_LSR_BRK_ERROR_BITS/MSR_ANY_DELTAinclude/uapi/linux/serial_reg.h+2 -20 replies
4/6serial: 8250: Use C99 array initializer & define UART_REG_UNMAPPEDdrivers/tty/serial/8250/8250_port.c+20 -180 replies
5/6serial: Convert SERIAL_XMIT_SIZE to UART_XMIT_SIZEdrivers/tty/amiserial.c drivers/tty/mips_ejtag_fdc.c drivers/tty/serial/meson_uart.c +3 more+13 -191 reply
6/6serial: Consolidate BOTH_EMPTY usearch/mips/ath79/early_printk.c drivers/accessibility/speakup/serialio.h drivers/tty/serial/8250/8250_early.c +7 more+31 -330 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchJiri Slaby
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/6] serial: A few cleanups

Here are a few cleanup to semi-random things I've come across while reading the code.

The series had initially only patches 3-6 but then msm_serial exploded during build because of redefining UART_SCR so I had to resolve the namespace conflict. It would have probably being avoided if there would have been linux/serial_reg.h but it was recently ruled out:

https://lore.kernel.org/lkml/CAPDyKFqHLQ8YTc3wzaFOdAA7Ay9RBEfdQC5uN574=oMavi6iCQ@mail.gmail.com/t/

(Now there would 3 items already in serial_reg.h already but it would leave only async_icount into serial.h so the same problem in other file).

v3:
- Remove one useless comment
- Improve changelog texts

v2:
- Fix commit summary line prefix

Ilpo Järvinen (6):
serial: msm: Convert container_of UART_TO_MSM to static inline
serial: msm: Rename UART_* defines to MSM_UART_*
serial: Use bits for UART_LSR_BRK_ERROR_BITS/MSR_ANY_DELTA
serial: 8250: Use C99 array initializer & define UART_REG_UNMAPPED
serial: Convert SERIAL_XMIT_SIZE to UART_XMIT_SIZE
serial: Consolidate BOTH_EMPTY use

 arch/mips/ath79/early_printk.c           |   9 +-
 drivers/accessibility/speakup/serialio.h |   3 +-
 drivers/tty/amiserial.c                  |  18 +-
 drivers/tty/mips_ejtag_fdc.c             |   2 +-
 drivers/tty/serial/8250/8250_early.c     |   4 +-
 drivers/tty/serial/8250/8250_port.c      |  50 +--
 drivers/tty/serial/meson_uart.c          |   2 +-
 drivers/tty/serial/msm_serial.c          | 550 ++++++++++++-----------
 drivers/tty/serial/omap-serial.c         |   7 +-
 drivers/tty/serial/owl-uart.c            |   2 +-
 drivers/tty/serial/pch_uart.c            |   7 +-
 drivers/tty/serial/pxa.c                 |   5 +-
 drivers/tty/serial/rda-uart.c            |   2 +-
 drivers/tty/serial/sunsu.c               |   4 +-
 drivers/tty/serial/vr41xx_siu.c          |   4 +-
 include/linux/serial.h                   |  15 +-
 include/uapi/linux/serial_reg.h          |   4 +-
 17 files changed, 342 insertions(+), 346 deletions(-)
Signature · 1 line
2.30.2