New fanotify API for ignoring events
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest3 patches 2 repliesIn review
- v22 patches 5 repliesSuperseded
- v12 patches 10 repliesSuperseded
Changes in v3 from the cover letter
- Rebase on top of API restriction patch
- Require FAN_MARK_IGNORED_SURV_MODIFY for dir/mount/sb ignore mark
- Add test coverage and update man page with new restrictions
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | fanotify: prepare for setting event flags in ignore maskfs/ fs/ fs/ +2 more | +121 | 2 replies | |
| 2/3 | fanotify: cleanups for fanotify_mark() input validationsfs/ include/ | +26 | 0 replies | |
| 3/3 | fanotify: introduce FAN_MARK_IGNOREfs/ fs/ include/ +1 more | +67 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.
Cover letter [PATCH v3 0/3] New fanotify API for ignoring events
Hi Jan,
As we discussed [1], here is the implementation of the new FAN_MARK_IGNORE API, to try and sort the historic mess of FAN_MARK_IGNORED_MASK.
We use the opportunity of the new API to further restict the events and flags that are allowed in ignore mask of a non-dir inode mark and we require FAN_MARK_IGNORED_SURV_MODIFY for dir/mount/sb ignore mark to remove from the test matrix a lot of notsensical combinations.
I extended the LTP tests [2] to cover the bug that you pointed out in [v1] review. I verified that the 6 relevant test cases fail with the buggy v1 version and pass in this version.
The man page draft [3] has been updated to reflect the new restrictions, some of which have already been added by a Fixes patch [4].
Thanks,
Amir.
Changes since [v2]:
- Rebase on top of API restriction patch
- Require FAN_MARK_IGNORED_SURV_MODIFY for dir/mount/sb ignore mark
- Add test coverage and update man page with new restrictions
Changes since [v1]:
- Replace "sticky" semantics with EEXITS error
- Simplify EINVAL checks
- Add missing ignore mask accessors
- Add fsnotify_effective_ignore_mask() helper to fix bug
[v1] https://lore.kernel.org/linux-fsdevel/[email protected]/
[v2] https://lore.kernel.org/linux-fsdevel/[email protected]/
[1] https://lore.kernel.org/linux-fsdevel/[email protected]/
[2] https://github.com/amir73il/ltp/commits/fan_mark_ignore
[3] https://github.com/amir73il/man-pages/commits/fan_mark_ignore
[4] https://lore.kernel.org/linux-fsdevel/[email protected]/
Amir Goldstein (3):
fanotify: prepare for setting event flags in ignore mask
fanotify: cleanups for fanotify_mark() input validations
fanotify: introduce FAN_MARK_IGNORE
fs/notify/fanotify/fanotify.c | 19 ++--- fs/notify/fanotify/fanotify.h | 2 + fs/notify/fanotify/fanotify_user.c | 110 ++++++++++++++++++++++------- fs/notify/fdinfo.c | 6 +- fs/notify/fsnotify.c | 21 +++--- include/linux/fanotify.h | 14 ++-- include/linux/fsnotify_backend.h | 89 +++++++++++++++++++++-- include/uapi/linux/fanotify.h | 8 +++ 8 files changed, 212 insertions(+), 57 deletions(-)
Signature · 1 line
2.25.1