Skip to content

media: cedrus: h265: Implement tiles support

Jernej Skrabec linux-arm-kernel linux-media linux-staging linux-sunxi lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7media: cedrus: h265: Fix flag namedrivers/staging/media/sunxi/cedrus/cedrus_h265.c drivers/staging/media/sunxi/cedrus/cedrus_regs.h+4 -30 replies
2/7media: cedrus: h265: Fix logic for not low delay flagdrivers/staging/media/sunxi/cedrus/cedrus_h265.c+26 -10 replies
3/7media: cedrus: Improve error messages for controlsdrivers/staging/media/sunxi/cedrus/cedrus.c+5 -21 reply
4/7media: cedrus: Add error handling for failed setupdrivers/staging/media/sunxi/cedrus/cedrus.h drivers/staging/media/sunxi/cedrus/cedrus_dec.c drivers/staging/media/sunxi/cedrus/cedrus_h264.c +3 more+30 -151 reply
5/7media: cedrus: h265: Add a couple of error checksdrivers/staging/media/sunxi/cedrus/cedrus_h265.c+8 -03 replies
6/7media: cedrus: Add helper for determining number of elementsdrivers/staging/media/sunxi/cedrus/cedrus.c drivers/staging/media/sunxi/cedrus/cedrus.h+12 -01 reply
7/7media: cedrus: h265: Implement support for tilesdrivers/staging/media/sunxi/cedrus/cedrus.c drivers/staging/media/sunxi/cedrus/cedrus.h drivers/staging/media/sunxi/cedrus/cedrus_dec.c +1 more+120 -61 reply

Reviews trailers per patch

5 of 7 patches have a Reviewed-by or Acked-by.

PatchEzequiel Garcia
1/7
2/7
3/7R-b
4/7R-b
5/7R-b
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] media: cedrus: h265: Implement tiles support

Now that we have full and stable HEVC uAPI, let's implement last big missing piece of HEVC in Cedrus - tiles support. This is done in last patch. Before that, there are bug fixes (patch 1 & 2, previously submitted separately in [1]), error handling improvements (patch 3, 4) and added helper for dealing with dynamic arrays (patch 5).

These patches are based on top of [2].

Final fluster score with this series is 125/147. 11 bitstreams are MAIN10, which is not yet properly supported. 5 bitstreams need better memory management with auxiliary buffers (wip patches exists). 4 are too big and 2 probably fails due to ffmpeg implementation.

Used ffmpeg source is in [3].

Note - Cedrus driver currently supports only one slice per request since HW takes data for 1 slice only. This can be improved by loading data for next slice automatically after HW signalled end of decoding. Something for later.

Please take a look.

Best regards,
Jernej

[1] https://patchwork.linuxtv.org/project/linux-media/list/?series=8187
[2] https://patchwork.linuxtv.org/project/linux-media/list/?series=8208
[3] https://github.com/jernejsk/FFmpeg/commits/hevc-mainline

Jernej Skrabec (7):
media: cedrus: h265: Fix flag name
media: cedrus: h265: Fix logic for not low delay flag
media: cedrus: Improve error messages for controls
media: cedrus: Add error handling for failed setup
media: cedrus: h265: Add a couple of error checks
media: cedrus: Add helper for determining number of elements
media: cedrus: h265: Implement support for tiles

 drivers/staging/media/sunxi/cedrus/cedrus.c   |  28 +++-
 drivers/staging/media/sunxi/cedrus/cedrus.h   |   7 +-
 .../staging/media/sunxi/cedrus/cedrus_dec.c   |  25 ++-
 .../staging/media/sunxi/cedrus/cedrus_h264.c  |   5 +-
 .../staging/media/sunxi/cedrus/cedrus_h265.c  | 153 ++++++++++++++++--
 .../staging/media/sunxi/cedrus/cedrus_mpeg2.c |   4 +-
 .../staging/media/sunxi/cedrus/cedrus_regs.h  |   3 +-
 .../staging/media/sunxi/cedrus/cedrus_vp8.c   |   5 +-
 8 files changed, 204 insertions(+), 26 deletions(-)
Signature · 1 line
2.36.1