Skip to content

check: add option to rerun failed tests

David Disseldorp fstests linux-ext4 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 2 repliesIn review
  2. v35 patches 5 repliesSuperseded
  3. v2 RFC6 patches 8 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v1 RFC2 patches5 repliesSuperseded

Changes since (v3), following Darrick's review from the cover letter

- extended full/out.bad/etc. retention to cover more paths and remove stale .rerun# files

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5report: use array for REPORT_ENV_LISTcommon/report+5 -210 replies
2/5report: pass through most details as function parameterscheck common/report+47 -310 replies
3/5check: make a few variables localcheck+5 -50 replies
4/5check: append bad / notrun arrays in helper functioncheck+39 -290 replies
5/5check: add -L <n> parameter to rerun failed testscheck+54 -31 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDarrick J. WongZorro Lang
SeriesR-b
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/5] check: add option to rerun failed tests

This patchset adds support to loop on failed tests, as proposed by Ted Ts'o in https://lwn.net/Articles/897061/:
add a mode that will immediately rerun a failed test 25 or 100 times to establish a failure percentage.

Changes since (v3), following Darrick's review:
- extended full/out.bad/etc. retention to cover more paths and remove stale .rerun# files

Changes since (v2), following Darrick's review:
- dropped RFC flag
- rebased atop v2022.07.03
- simplified test iterator
+ results stashed at the end of each iteration, rather than start of next / loop-exit
- dropped aggregate loop stats message from xunit report
- squashed full/dmesg/out.bad file retention patch with rerun patch

Changes since (v1):
- rebased atop upstream v2022.06.26
- added a few extra cleanup commits
- append details for every rerun to xunit output
+ provide aggregate stats via <testcase status=X>
- extend _stash_test_status to call report hook, as well as save failure artifacts with a .rerun# suffix

Diffstat:

 check         | 137 +++++++++++++++++++++++++++++++++++++-------------
 common/report |  90 ++++++++++++++++-----------------
 2 files changed, 144 insertions(+), 83 deletions(-)