Skip to content

PCI: designware-ep: Fix DBI access before core init

Vidya Sagar linux-arm-msm linux-pci lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest3 patches 9 repliesIn review
  2. v43 patches 3 repliesSuperseded
  3. v11 patch 16 repliesSuperseded

Changes in v5 from the cover letter

* Addressed review comments from Bjorn
* Changed dw_pcie_ep_init_complete() to dw_pcie_ep_init_late()
* Skipped memory allocation if done already. This is to avoid freeing and then allocating again during PERST# toggles from the host.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3PCI: designware-ep: Fix DBI access before core initdrivers/pci/controller/dwc/pcie-designware-ep.c drivers/pci/controller/dwc/pcie-designware.h+80 -552 replies
2/3PCI: qcom-ep: Refactor EP initialization completiondrivers/pci/controller/dwc/pcie-qcom-ep.c+16 -111 reply
3/3PCI: tegra194: Refactor EP initialization completiondrivers/pci/controller/dwc/pcie-tegra194.c+1 -30 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchJingoo Han
1/3A-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH V5 0/3] PCI: designware-ep: Fix DBI access before core init

This series attempts to fix the issue with core register (Ex:- DBI) accesses causing system hang issues in platforms where there is a dependency on the availability of PCIe Reference clock from the host for their core initialization.
This series is verified on Tegra194 & Tegra234 platforms.

Manivannan, could you please verify on qcom platforms?

V5:
* Addressed review comments from Bjorn
* Changed dw_pcie_ep_init_complete() to dw_pcie_ep_init_late()
* Skipped memory allocation if done already. This is to avoid freeing and then allocating again during PERST# toggles from the host.

V4:
* Addressed review comments from Bjorn and Manivannan
* Added .ep_init_late() ops
* Added patches to refactor code in qcom and tegra platforms

Vidya Sagar (3):
PCI: designware-ep: Fix DBI access before core init
PCI: qcom-ep: Refactor EP initialization completion
PCI: tegra194: Refactor EP initialization completion

 .../pci/controller/dwc/pcie-designware-ep.c   | 125 +++++++++++-------
 drivers/pci/controller/dwc/pcie-designware.h  |  10 +-
 drivers/pci/controller/dwc/pcie-qcom-ep.c     |  27 ++--
 drivers/pci/controller/dwc/pcie-tegra194.c    |   4 +-
 4 files changed, 97 insertions(+), 69 deletions(-)
Signature · 1 line
2.17.1