Skip to content

Read _SUB from ACPI to be able to identify firmware

Stefan Binding alsa-devel linux-acpi lkml 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest2 patches 2 repliesIn review
  2. v52 patches 5 repliesSuperseded
  3. v42 patches 1 replySuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v32 patches0 repliesSuperseded
v22 patches0 repliesSuperseded
v12 patches1 replySuperseded

Changes in v6 from the cover letter

- Clean up return codes
- Refactor length calculation
- Allow fallback to existing behaviour when bad ACPI is detected

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ACPI: utils: Add api to read _SUB from ACPIdrivers/acpi/utils.c include/linux/acpi.h+44 -01 reply
2/2ASoC: cs35l41: Read System Name from ACPI _SUB to identify firmwaresound/soc/codecs/cs35l41.c+30 -00 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchRafael J. Wysocki
1/2A-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/2] Read _SUB from ACPI to be able to identify firmware

CS35L41 has a DSP which is able to run firmware, as well as a tuning file. Different systems may want to use different firmwares and tuning files, and some firmwares/tunings may not be compatible with other systems. To allow a system to select the correct fimware/tuning, we can read an _SUB from the ACPI. This _SUB can then be used to uniquely identify the system in the firmware/tuning file name.

Add a helper function which reads the _SUB, so this can be used by other parts in the future.
Add support inside the CS35L41 ASoC driver to read this _SUB, and save it appropriately.

Changes since v5:
- Clean up return codes
- Refactor length calculation
- Allow fallback to existing behaviour when bad ACPI is detected

Changes since v4:
- Rename function

Changes since v3:
- Fix 32 bit format string warning

Changes since v2:
- Fix error in function prototype

Changes since v1:
- Add length validation for SSID String
- Rename API
- Allocate memory inside API
- Use ACPI_HANDLE macro instead of ACPI_COMPANION
- Improve error handling

Stefan Binding (2):
ACPI: utils: Add api to read _SUB from ACPI
ASoC: cs35l41: Read System Name from ACPI _SUB to identify firmware

 drivers/acpi/utils.c       | 38 ++++++++++++++++++++++++++++++++++++++
 include/linux/acpi.h       |  6 ++++++
 sound/soc/codecs/cs35l41.c | 30 ++++++++++++++++++++++++++++++
 3 files changed, 74 insertions(+)
Signature · 1 line
2.25.1