Skip to content

RFC KVM: nVMX: Use vmcs_config for setting up nested VMX MSRs

Vitaly Kuznetsov kvm linux-hyperv lkml oe-lkp 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest10 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10KVM: VMX: Move CPU_BASED_CR8_{LOAD,STORE}_EXITING filtering out of setup_vmcs_config()arch/x86/kvm/vmx/vmx.c+6 -51 reply
2/10KVM: VMX: Add missing CPU based VM execution controls to vmcs_configarch/x86/kvm/vmx/vmx.c+14 -12 replies
3/10KVM: VMX: Move CPU_BASED_{CR3_LOAD,CR3_STORE,INVLPG}_EXITING filtering out of setup_vmcs_config()arch/x86/kvm/vmx/vmx.c+10 -01 reply
4/10KVM: VMX: Add missing VMEXIT controls to vmcs_configarch/x86/kvm/vmx/vmx.c+6 -00 replies
5/10KVM: VMX: Add missing VMENTRY controls to vmcs_configarch/x86/kvm/vmx/vmx.c+7 -10 replies
6/10KVM: nVMX: Use sanitized allowed-1 bits for VMX control MSRsarch/x86/kvm/vmx/nested.c arch/x86/kvm/vmx/nested.h arch/x86/kvm/vmx/vmx.c+19 -220 replies
7/10KVM: VMX: Store required-1 VMX controls in vmcs_configarch/x86/kvm/vmx/capabilities.h arch/x86/kvm/vmx/vmx.c+26 -70 replies
8/10KVM: nVMX: Use sanitized required-1 bits for VMX control MSRsarch/x86/kvm/vmx/nested.c+1 -50 replies
9/10KVM: VMX: Cache MSR_IA32_VMX_MISC in vmcs_configarch/x86/kvm/vmx/capabilities.h arch/x86/kvm/vmx/vmx.c+8 -110 replies
10/10KVM: nVMX: Use cached host MSR_IA32_VMX_MISC value for setting up nested MSRarch/x86/kvm/vmx/nested.c+1 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH RFC v1 00/10] KVM: nVMX: Use vmcs_config for setting up nested VMX MSRs

vmcs_config is a sanitized version of host VMX MSRs where some controls are filtered out (e.g. when Enlightened VMCS is enabled, some know bugs are discovered, some inconsistencies in controls are detected,...) but nested_vmx_setup_ctls_msrs() uses raw host MSRs instead. This may end up in exposing undesired controls to L1. Switch to using vmcs_config instead.

RFC part: vmcs_config's sanitization now is a mix of "what can't be enabled" and "what KVM doesn't want" and we need to separate these as for nested VMX MSRs only the first category makes sense. This gives vmcs_config a slightly different meaning "controls which can be (theoretically) used". An alternative approach would be to store sanitized host MSRs values separately, sanitize them and and use in nested_vmx_setup_ctls_msrs() but currently I don't see any benefits. Comments welcome!

Very lightly tested with KVM selftests / kvm-unit-tests.

Vitaly Kuznetsov (10):
KVM: VMX: Move CPU_BASED_CR8_{LOAD,STORE}_EXITING filtering out of
setup_vmcs_config()
KVM: VMX: Add missing CPU based VM execution controls to vmcs_config
KVM: VMX: Move CPU_BASED_{CR3_LOAD,CR3_STORE,INVLPG}_EXITING filtering
out of setup_vmcs_config()
KVM: VMX: Add missing VMEXIT controls to vmcs_config
KVM: VMX: Add missing VMENTRY controls to vmcs_config
KVM: nVMX: Use sanitized allowed-1 bits for VMX control MSRs
KVM: VMX: Store required-1 VMX controls in vmcs_config
KVM: nVMX: Use sanitized required-1 bits for VMX control MSRs
KVM: VMX: Cache MSR_IA32_VMX_MISC in vmcs_config
KVM: nVMX: Use cached host MSR_IA32_VMX_MISC value for setting up
nested MSR

 arch/x86/kvm/vmx/capabilities.h | 16 +++---
 arch/x86/kvm/vmx/nested.c       | 37 +++++---------
 arch/x86/kvm/vmx/nested.h       |  2 +-
 arch/x86/kvm/vmx/vmx.c          | 91 +++++++++++++++++++++++++--------
 4 files changed, 94 insertions(+), 52 deletions(-)
Signature · 1 line
2.35.3