Skip to content

drm/i915/display: stop HPD workers before display driver unregister

Andrzej Hajda dri-devel intel-gfx 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest3 patches 2 repliesIn review
  2. v64 patches 13 repliesSuperseded
  3. v54 patches 0 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v43 patches0 repliesSuperseded
v33 patches4 repliesSuperseded
v22 patches2 repliesSuperseded
v12 patches4 repliesSuperseded

Changes in v7 from the cover letter

- addresed comments from Imre and Jani,
- removed patch adding suspended flag

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3drm/i915/hpd: suspend MST at the end of intel_modeset_driver_removedrivers/gpu/drm/i915/display/intel_display.c+7 -71 reply
2/3drm/i915/fbdev: suspend HPD before fbdev unregistrationdrivers/gpu/drm/i915/display/intel_fbdev.c+4 -20 replies
3/3drm/i915/fbdev: do not create fbdev if HPD is suspendeddrivers/gpu/drm/i915/display/intel_fbdev.c+6 -00 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchArun R MurthyImre Deak
1/3R-b R-b
2/3R-b R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 0/3] drm/i915/display: stop HPD workers before display driver unregister

Hi Imre, Jani, Ville, Arun,

This patchset is replacement of patch
"drm/i915/display: disable HPD workers before display driver unregister" [1]. Ive decided to split patch into two parts - fbdev and MST, there are different issues.
Ive also dropped shutdown path, as it has slightly different requirements, and more importantly I am not able to test properly.

v2 (thx Arun for review):
- reword of commit message (Arun)
- intel_fbdev_hpd_set_suspend replaced with intel_fbdev_set_suspend (Arun)
v3:
- new patch adding suspended flag, to handle

    https://gitlab.freedesktop.org/drm/intel/-/issues/5950

v4:
- check suspend flag also in i915_digport_work_func
v5:
- added patch blocking FB creation in case HPD is supended,
- added R-B from Arun to patch 3, thx
v6:
- finally, after getting direct access to bat-rpls-2, I have found the source of last WARN, intel_fbdev_hpd_set_suspend was not called in case of deferred setup, fixed in patch 2.
v7:
- addresed comments from Imre and Jani,
- removed patch adding suspended flag

[1]: https://patchwork.freedesktop.org/series/103811/

Regards
Andrzej

Andrzej Hajda (3):
drm/i915/hpd: suspend MST at the end of intel_modeset_driver_remove drm/i915/fbdev: suspend HPD before fbdev unregistration drm/i915/fbdev: do not create fbdev if HPD is suspended

 drivers/gpu/drm/i915/display/intel_display.c | 14 +++++++-------
 drivers/gpu/drm/i915/display/intel_fbdev.c   | 12 ++++++++++--
 2 files changed, 17 insertions(+), 9 deletions(-)
Signature · 1 line
2.25.1