Improve static type checking for request flags
Status from this message: Applied, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest63 patches 10 repliesApplied
- v263 patches 32 repliesSuperseded
- v151 patches 30 repliesSuperseded
Changes in v3 from the cover letter
- Renamed 'op' arguments and variables into 'opf' in case these hold both a request operation and flags (BFQ, mq-deadline, Kyber and NVMe target code).
- Added more Reviewed-by tags.
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/63 | treewide: Rename enum req_opf into enum req_opblock/ drivers/ drivers/ +10 more | +33 | 0 replies | |
| 2/63 | block: Use enum req_op where appropriateblock/ block/ block/ +4 more | +14 | 0 replies | |
| 3/63 | block: Change the type of the last .rw_page() argumentdrivers/ drivers/ drivers/ +2 more | +5 | 0 replies | |
| 4/63 | block: Change the type of req_op() and bio_op() into enum req_opblock/ drivers/ drivers/ +2 more | +14 | 0 replies | |
| 5/63 | block: Introduce the type blk_opf_tinclude/ | +51 | 0 replies | |
| 6/63 | block: Use the new blk_opf_t typeblock/ block/ block/ +11 more | +53 | 0 replies | |
| 7/63 | block/bfq: Use the new blk_opf_t typeblock/ block/ block/ | +25 | 1 reply | |
| 8/63 | block/mq-deadline: Use the new blk_opf_t typeblock/ | +2 | 0 replies | |
| 9/63 | block/kyber: Use the new blk_opf_t typeblock/ | +4 | 0 replies | |
| 10/63 | blktrace: Trace remapped requests correctlykernel/ | +1 | 0 replies | |
| 11/63 | blktrace: Use the new blk_opf_t typeinclude/ kernel/ | +27 | 0 replies | |
| 12/63 | block/brd: Use the enum req_op typedrivers/ | +1 | 0 replies | |
| 13/63 | block/drbd: Use the enum req_op and blk_opf_t typesdrivers/ drivers/ drivers/ +1 more | +15 | 0 replies | |
| 14/63 | block/drbd: Combine two drbd_submit_peer_request() argumentsdrivers/ drivers/ drivers/ | +9 | 0 replies | |
| 15/63 | block/floppy: Fix a sparse warningdrivers/ | +1 | 0 replies | |
| 16/63 | block/rnbd: Use blk_opf_t where appropriatedrivers/ | +4 | 0 replies | |
| 17/63 | xen-blkback: Use the enum req_op and blk_opf_t typesdrivers/ | +3 | 0 replies | |
| 18/63 | block/zram: Use enum req_op where appropriatedrivers/ | +1 | 0 replies | |
| 19/63 | nvdimm-btt: Use the enum req_op typedrivers/ | +1 | 0 replies | |
| 20/63 | um: Use enum req_op where appropriatearch/ | +2 | 0 replies | |
| 21/63 | dm/core: Reduce the size of struct dm_io_requestdrivers/ drivers/ drivers/ +6 more | +29 | 0 replies | |
| 22/63 | dm/core: Rename kcopyd_job.rw into kcopyd.opdrivers/ | +13 | 0 replies | |
| 23/63 | dm/core: Combine request operation type and flagsdrivers/ drivers/ drivers/ | +32 | 0 replies | |
| 24/63 | dm/ebs: Change 'int rw' into 'enum req_op op'drivers/ | +8 | 0 replies | |
| 25/63 | dm/dm-flakey: Use the new blk_opf_t typedrivers/ | +6 | 0 replies | |
| 26/63 | dm/dm-integrity: Combine request operation and flagsdrivers/ | +34 | 0 replies | |
| 27/63 | dm mirror log: Use the new blk_opf_t typedrivers/ | +1 | 0 replies | |
| 28/63 | dm-snap: Combine request operation type and flagsdrivers/ | +12 | 0 replies | |
| 29/63 | dm/zone: Use the enum req_op typedrivers/ | +1 | 0 replies | |
| 30/63 | dm/dm-zoned: Use the enum req_op typedrivers/ drivers/ | +4 | 0 replies | |
| 31/63 | md/core: Combine two sync_page_io() argumentsdrivers/ drivers/ drivers/ +5 more | +29 | 0 replies | |
| 32/63 | md/bcache: Combine two uuid_io() argumentsdrivers/ | +8 | 1 reply | |
| 33/63 | md/bcache: Combine two prio_io() argumentsdrivers/ | +4 | 1 reply | |
| 34/63 | md/raid1: Use the new blk_opf_t typedrivers/ | +2 | 0 replies | |
| 35/63 | md/raid10: Use the new blk_opf_t typedrivers/ | +5 | 0 replies | |
| 36/63 | md/raid5: Use the enum req_op and blk_opf_t typesdrivers/ | +2 | 0 replies | |
| 37/63 | nvme/host: Use the enum req_op and blk_opf_t typesdrivers/ drivers/ | +3 | 0 replies | |
| 38/63 | nvme/target: Use the new blk_opf_t typedrivers/ drivers/ | +12 | 0 replies | |
| 39/63 | scsi/core: Improve static type checkingdrivers/ include/ | +5 | 0 replies | |
| 40/63 | scsi/core: Change the return type of scsi_noretry_cmd() into booldrivers/ drivers/ | +9 | 0 replies | |
| 41/63 | scsi/core: Use the new blk_opf_t typedrivers/ include/ | +4 | 0 replies | |
| 42/63 | scsi/device_handlers: Use the new blk_opf_t typedrivers/ drivers/ drivers/ +1 more | +6 | 1 reply | |
| 43/63 | scsi/ufs: Rename a 'dir' argument into 'op'drivers/ | +2 | 0 replies | |
| 44/63 | scsi/target: Use the new blk_opf_t typedrivers/ | +2 | 0 replies | |
| 45/63 | mm: Use the new blk_opf_t typeinclude/ | +2 | 1 reply | |
| 46/63 | fs/buffer: Use the new blk_opf_t typefs/ include/ | +16 | 0 replies | |
| 47/63 | fs/buffer: Combine two submit_bh() and ll_rw_block() argumentsdrivers/ fs/ fs/ +32 more | +88 | 1 reply | |
| 48/63 | fs/direct-io: Reduce the size of struct diofs/ | +23 | 0 replies | |
| 49/63 | fs/mpage: Use the new blk_opf_t typefs/ | +3 | 0 replies | |
| 50/63 | fs/btrfs: Use the enum req_op and blk_opf_t typesfs/ fs/ fs/ +3 more | +19 | 0 replies | |
| 51/63 | fs/ext4: Use the new blk_opf_t typefs/ fs/ fs/ | +12 | 1 reply | |
| 52/63 | fs/f2fs: Use the enum req_op and blk_opf_t typesfs/ fs/ fs/ +2 more | +22 | 0 replies | |
| 53/63 | fs/gfs2: Use the enum req_op and blk_opf_t typesfs/ fs/ fs/ +2 more | +10 | 0 replies | |
| 54/63 | fs/hfsplus: Use the enum req_op and blk_opf_t typesfs/ fs/ fs/ +1 more | +11 | 0 replies | |
| 55/63 | fs/iomap: Use the new blk_opf_t typefs/ | +4 | 0 replies | |
| 56/63 | fs/jbd2: Fix the documentation of the jbd2_write_superblock() callersfs/ include/ include/ | +15 | 1 reply | |
| 57/63 | fs/nfs: Use enum req_op where appropriatefs/ | +6 | 0 replies | |
| 58/63 | fs/nilfs2: Use the enum req_op and blk_opf_t typesfs/ fs/ fs/ +3 more | +23 | 0 replies | |
| 59/63 | fs/ntfs3: Use enum req_op where appropriatefs/ fs/ | +2 | 0 replies | |
| 60/63 | fs/ocfs2: Use the enum req_op and blk_opf_t typesfs/ | +5 | 0 replies | |
| 61/63 | PM: Use the enum req_op and blk_opf_t typeskernel/ | +13 | 0 replies | |
| 62/63 | fs/xfs: Use the enum req_op and blk_opf_t typesfs/ fs/ fs/ +1 more | +5 | 0 replies | |
| 63/63 | fs/zonefs: Use the enum req_op type for tracing request operationsfs/ | +1 | 1 reply |
Reviews trailers per patch
28 of 63 patches have a Reviewed-by or Acked-by.
| Patch | Jun'ichi Nomura | Christoph Böhmwalder | Jack Wang | Roger Pau Monné | Damien Le Moal | Song Liu | Sagi Grimberg | Avri Altman | Jan Kara | David Sterba | Andreas Gruenbacher | Ryusuke Konishi | Joseph Qi | Rafael J. Wysocki | Darrick J. Wong | Johannes Thumshirn | Martin Wilck | Theodore Ts'o | Coly Li |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1/63 | |||||||||||||||||||
| 2/63 | |||||||||||||||||||
| 3/63 | |||||||||||||||||||
| 4/63 | |||||||||||||||||||
| 5/63 | |||||||||||||||||||
| 6/63 | |||||||||||||||||||
| 7/63 | R-b | ||||||||||||||||||
| 8/63 | |||||||||||||||||||
| 9/63 | |||||||||||||||||||
| 10/63 | R-b | ||||||||||||||||||
| 11/63 | |||||||||||||||||||
| 12/63 | |||||||||||||||||||
| 13/63 | R-b | ||||||||||||||||||
| 14/63 | R-b | ||||||||||||||||||
| 15/63 | |||||||||||||||||||
| 16/63 | A-b | ||||||||||||||||||
| 17/63 | A-b | ||||||||||||||||||
| 18/63 | |||||||||||||||||||
| 19/63 | |||||||||||||||||||
| 20/63 | |||||||||||||||||||
| 21/63 | |||||||||||||||||||
| 22/63 | |||||||||||||||||||
| 23/63 | |||||||||||||||||||
| 24/63 | |||||||||||||||||||
| 25/63 | |||||||||||||||||||
| 26/63 | |||||||||||||||||||
| 27/63 | |||||||||||||||||||
| 28/63 | |||||||||||||||||||
| 29/63 | R-b | ||||||||||||||||||
| 30/63 | R-b | ||||||||||||||||||
| 31/63 | |||||||||||||||||||
| 32/63 | A-b | ||||||||||||||||||
| 33/63 | Asked-by | ||||||||||||||||||
| 34/63 | A-b | ||||||||||||||||||
| 35/63 | A-b | ||||||||||||||||||
| 36/63 | A-b | ||||||||||||||||||
| 37/63 | R-b | ||||||||||||||||||
| 38/63 | |||||||||||||||||||
| 39/63 | |||||||||||||||||||
| 40/63 | |||||||||||||||||||
| 41/63 | |||||||||||||||||||
| 42/63 | R-b | ||||||||||||||||||
| 43/63 | R-b | ||||||||||||||||||
| 44/63 | |||||||||||||||||||
| 45/63 | R-b | ||||||||||||||||||
| 46/63 | R-b | ||||||||||||||||||
| 47/63 | A-b | R-b | |||||||||||||||||
| 48/63 | R-b | ||||||||||||||||||
| 49/63 | |||||||||||||||||||
| 50/63 | A-b | ||||||||||||||||||
| 51/63 | A-b | ||||||||||||||||||
| 52/63 | |||||||||||||||||||
| 53/63 | R-b | ||||||||||||||||||
| 54/63 | |||||||||||||||||||
| 55/63 | |||||||||||||||||||
| 56/63 | A-b | ||||||||||||||||||
| 57/63 | |||||||||||||||||||
| 58/63 | R-b | ||||||||||||||||||
| 59/63 | |||||||||||||||||||
| 60/63 | R-b | ||||||||||||||||||
| 61/63 | A-b | ||||||||||||||||||
| 62/63 | R-b | ||||||||||||||||||
| 63/63 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 19 reviewers.
Cover letter [PATCH v3 00/63] Improve static type checking for request flags
Hi Jens,
A source of confusion in the block layer is that can be nontrivial to determine which type of flags a u32 function argument accepts. This patch series clears up that confusion for request flags by introducing a new __bitwise type, namely blk_opf_t. Additionally, the type 'int' is change into 'enum req_op' where used to hold a request operation.
Analysis of the sparse warnings introduced by this conversion resulted in one bug fix ("blktrace: Trace remap operations correctly").
Although the number of patches in this series is significant, the risk of this patch series is low since most patches involve changing one integer type (int or u32) into another integer type of the same size (enum req_op or blk_opf_t).
Please consider this patch series for kernel v5.20.
Thanks,
Bart.
Changes compared to v2:
- Renamed 'op' arguments and variables into 'opf' in case these hold both a request operation and flags (BFQ, mq-deadline, Kyber and NVMe target code).
- Added more Reviewed-by tags.
Changes compared to v1:
- Combined request operation and flags into a single variable or argument.
- Changed the type of several enum req_op arguments into blk_opf_t for future extensibility.
- Removed the __force casts from tracing code.
- Added a few additional patches that convert additional block drivers.
Bart Van Assche (63):
treewide: Rename enum req_opf into enum req_op
block: Use enum req_op where appropriate
block: Change the type of the last .rw_page() argument
block: Change the type of req_op() and bio_op() into enum req_op
block: Introduce the type blk_opf_t
block: Use the new blk_opf_t type
block/bfq: Use the new blk_opf_t type
block/mq-deadline: Use the new blk_opf_t type
block/kyber: Use the new blk_opf_t type
blktrace: Trace remapped requests correctly
blktrace: Use the new blk_opf_t type
block/brd: Use the enum req_op type
block/drbd: Use the enum req_op and blk_opf_t types block/drbd: Combine two drbd_submit_peer_request() arguments block/floppy: Fix a sparse warning
block/rnbd: Use blk_opf_t where appropriate
xen-blkback: Use the enum req_op and blk_opf_t types block/zram: Use enum req_op where appropriate
nvdimm-btt: Use the enum req_op type
um: Use enum req_op where appropriate
dm/core: Reduce the size of struct dm_io_request
dm/core: Rename kcopyd_job.rw into kcopyd.op
dm/core: Combine request operation type and flags
dm/ebs: Change 'int rw' into 'enum req_op op' dm/dm-flakey: Use the new blk_opf_t type
dm/dm-integrity: Combine request operation and flags
dm mirror log: Use the new blk_opf_t type
dm-snap: Combine request operation type and flags
dm/zone: Use the enum req_op type
dm/dm-zoned: Use the enum req_op type
md/core: Combine two sync_page_io() arguments
md/bcache: Combine two uuid_io() arguments
md/bcache: Combine two prio_io() arguments
md/raid1: Use the new blk_opf_t type
md/raid10: Use the new blk_opf_t type
md/raid5: Use the enum req_op and blk_opf_t types nvme/host: Use the enum req_op and blk_opf_t types nvme/target: Use the new blk_opf_t type
scsi/core: Improve static type checking
scsi/core: Change the return type of scsi_noretry_cmd() into bool scsi/core: Use the new blk_opf_t type scsi/device_handlers: Use the new blk_opf_t type
scsi/ufs: Rename a 'dir' argument into 'op'
scsi/target: Use the new blk_opf_t type
mm: Use the new blk_opf_t type
fs/buffer: Use the new blk_opf_t type
fs/buffer: Combine two submit_bh() and ll_rw_block() arguments fs/direct-io: Reduce the size of struct dio
fs/mpage: Use the new blk_opf_t type
fs/btrfs: Use the enum req_op and blk_opf_t types
fs/ext4: Use the new blk_opf_t type
fs/f2fs: Use the enum req_op and blk_opf_t types
fs/gfs2: Use the enum req_op and blk_opf_t types fs/hfsplus: Use the enum req_op and blk_opf_t types fs/iomap: Use the new blk_opf_t type
fs/jbd2: Fix the documentation of the jbd2_write_superblock() callers fs/nfs: Use enum req_op where appropriate
fs/nilfs2: Use the enum req_op and blk_opf_t types fs/ntfs3: Use enum req_op where appropriate
fs/ocfs2: Use the enum req_op and blk_opf_t types
PM: Use the enum req_op and blk_opf_t types
fs/xfs: Use the enum req_op and blk_opf_t types
fs/zonefs: Use the enum req_op type for tracing request operations
arch/um/drivers/ubd_kern.c | 4 +- block/bfq-cgroup.c | 26 ++--- block/bfq-iosched.c | 16 +-- block/bfq-iosched.h | 8 +- block/bio.c | 10 +- block/blk-cgroup-rwstat.h | 8 +- block/blk-core.c | 8 +- block/blk-flush.c | 6 +- block/blk-merge.c | 8 +- block/blk-mq-debugfs.c | 6 +- block/blk-mq.c | 15 +-- block/blk-mq.h | 6 +- block/blk-throttle.c | 7 +- block/blk-wbt.c | 18 +-- block/blk-zoned.c | 7 +- block/blk.h | 2 +- block/elevator.h | 2 +- block/fops.c | 12 +- block/kyber-iosched.c | 8 +- block/mq-deadline.c | 4 +- drivers/block/brd.c | 4 +- drivers/block/drbd/drbd_actlog.c | 9 +- drivers/block/drbd/drbd_bitmap.c | 2 +- drivers/block/drbd/drbd_int.h | 5 +- drivers/block/drbd/drbd_receiver.c | 24 ++-- drivers/block/drbd/drbd_worker.c | 2 +- drivers/block/floppy.c | 2 +- drivers/block/null_blk/main.c | 9 +- drivers/block/null_blk/null_blk.h | 12 +- drivers/block/null_blk/trace.h | 2 +- drivers/block/null_blk/zoned.c | 4 +- drivers/block/paride/pd.c | 2 + drivers/block/rnbd/rnbd-proto.h | 7 +- drivers/block/xen-blkback/blkback.c | 6 +- drivers/block/zram/zram_drv.c | 4 +- drivers/md/bcache/super.c | 25 ++-- drivers/md/dm-bufio.c | 26 ++--- drivers/md/dm-ebs-target.c | 15 +-- drivers/md/dm-flakey.c | 8 +- drivers/md/dm-integrity.c | 76 ++++++------- drivers/md/dm-io.c | 38 +++---- drivers/md/dm-kcopyd.c | 26 ++--- drivers/md/dm-log.c | 8 +- drivers/md/dm-raid.c | 2 +- drivers/md/dm-raid1.c | 12 +- drivers/md/dm-snap-persistent.c | 25 ++-- drivers/md/dm-writecache.c | 12 +- drivers/md/dm-zone.c | 2 +- drivers/md/dm-zoned-metadata.c | 5 +- drivers/md/dm-zoned.h | 2 +- drivers/md/dm.c | 12 +- drivers/md/md-bitmap.c | 6 +- drivers/md/md.c | 10 +- drivers/md/md.h | 3 +- drivers/md/raid1.c | 12 +- drivers/md/raid10.c | 20 ++-- drivers/md/raid5-cache.c | 12 +- drivers/md/raid5-ppl.c | 12 +- drivers/md/raid5.c | 3 +- drivers/nvdimm/btt.c | 4 +- drivers/nvdimm/pmem.c | 2 +- drivers/nvme/host/ioctl.c | 4 +- drivers/nvme/host/nvme.h | 2 +- drivers/nvme/target/io-cmd-bdev.c | 17 +-- drivers/nvme/target/zns.c | 10 +- drivers/scsi/device_handler/scsi_dh_alua.c | 4 +- drivers/scsi/device_handler/scsi_dh_emc.c | 2 +- drivers/scsi/device_handler/scsi_dh_hp_sw.c | 4 +- drivers/scsi/device_handler/scsi_dh_rdac.c | 2 +- drivers/scsi/scsi_error.c | 16 +-- drivers/scsi/scsi_lib.c | 12 +- drivers/scsi/scsi_priv.h | 2 +- drivers/scsi/sd_zbc.c | 2 +- drivers/target/target_core_iblock.c | 4 +- drivers/ufs/core/ufshpb.c | 7 +- fs/btrfs/check-integrity.c | 4 +- fs/btrfs/compression.c | 6 +- fs/btrfs/compression.h | 2 +- fs/btrfs/extent_io.c | 18 +-- fs/btrfs/inode.c | 4 +- fs/btrfs/raid56.c | 4 +- fs/buffer.c | 56 ++++----- fs/direct-io.c | 40 ++++--- fs/ext4/ext4.h | 8 +- fs/ext4/fast_commit.c | 4 +- fs/ext4/mmp.c | 2 +- fs/ext4/super.c | 20 ++-- fs/f2fs/data.c | 11 +- fs/f2fs/f2fs.h | 6 +- fs/f2fs/node.c | 2 +- fs/f2fs/segment.c | 2 +- fs/gfs2/bmap.c | 5 +- fs/gfs2/dir.c | 5 +- fs/gfs2/log.c | 4 +- fs/gfs2/log.h | 2 +- fs/gfs2/lops.c | 4 +- fs/gfs2/lops.h | 2 +- fs/gfs2/meta_io.c | 18 ++- fs/gfs2/quota.c | 2 +- fs/hfsplus/hfsplus_fs.h | 2 +- fs/hfsplus/part_tbl.c | 5 +- fs/hfsplus/super.c | 4 +- fs/hfsplus/wrapper.c | 12 +- fs/iomap/direct-io.c | 8 +- fs/isofs/compress.c | 2 +- fs/jbd2/commit.c | 8 +- fs/jbd2/journal.c | 19 ++-- fs/jbd2/recovery.c | 4 +- fs/mpage.c | 6 +- fs/nfs/blocklayout/blocklayout.c | 13 +-- fs/nilfs2/btnode.c | 8 +- fs/nilfs2/btnode.h | 4 +- fs/nilfs2/btree.c | 6 +- fs/nilfs2/gcinode.c | 7 +- fs/nilfs2/mdt.c | 19 ++-- fs/ntfs/aops.c | 6 +- fs/ntfs/compress.c | 2 +- fs/ntfs/file.c | 2 +- fs/ntfs/logfile.c | 2 +- fs/ntfs/mft.c | 4 +- fs/ntfs3/file.c | 2 +- fs/ntfs3/fsntfs.c | 2 +- fs/ntfs3/inode.c | 2 +- fs/ntfs3/ntfs_fs.h | 2 +- fs/ocfs2/aops.c | 2 +- fs/ocfs2/buffer_head_io.c | 8 +- fs/ocfs2/cluster/heartbeat.c | 11 +- fs/ocfs2/super.c | 2 +- fs/reiserfs/inode.c | 4 +- fs/reiserfs/journal.c | 12 +- fs/reiserfs/stree.c | 4 +- fs/reiserfs/super.c | 2 +- fs/udf/dir.c | 2 +- fs/udf/directory.c | 2 +- fs/udf/inode.c | 2 +- fs/ufs/balloc.c | 2 +- fs/xfs/xfs_bio_io.c | 2 +- fs/xfs/xfs_buf.c | 4 +- fs/xfs/xfs_linux.h | 2 +- fs/xfs/xfs_log_recover.c | 2 +- fs/zonefs/super.c | 5 +- fs/zonefs/trace.h | 4 +- include/linux/bio.h | 10 +- include/linux/blk-mq.h | 12 +- include/linux/blk_types.h | 119 +++++++++++--------- include/linux/blkdev.h | 12 +- include/linux/blktrace_api.h | 3 +- include/linux/buffer_head.h | 9 +- include/linux/dm-io.h | 4 +- include/linux/jbd2.h | 2 +- include/linux/writeback.h | 4 +- include/scsi/scsi_cmnd.h | 4 +- include/scsi/scsi_device.h | 2 +- include/trace/events/f2fs.h | 22 ++-- include/trace/events/jbd2.h | 12 +- include/trace/events/nilfs2.h | 4 +- kernel/power/swap.c | 29 +++-- kernel/trace/blktrace.c | 51 ++++----- 158 files changed, 751 insertions(+), 743 deletions(-)