Skip to content

RFC ice: PPPoE offload support

Marcin Szycik intel-wired-lan netdev 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 RFC Latest4 patches 2 repliesIn review
  2. v5 RFC4 patches 1 replySuperseded
  3. v4 RFC4 patches 9 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v3 RFC4 patches9 repliesSuperseded
v2 RFC4 patches5 repliesSuperseded
v1 RFC4 patches4 repliesSuperseded

Changes in v6 from the cover letter

* make check for ppp proto more generic
* fix remaining byte order issues
v5: fix endianness when processing compressed protocols

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4flow_dissector: Add PPPoE dissectorsinclude/linux/ppp_defs.h include/net/flow_dissector.h net/core/flow_dissector.c+73 -71 reply
2/4net/sched: flower: Add PPPoE filterinclude/uapi/linux/pkt_cls.h net/sched/cls_flower.c+67 -01 reply
3/4flow_offload: Introduce flow_match_pppoeinclude/net/flow_offload.h net/core/flow_offload.c+13 -00 replies
4/4ice: Add support for PPPoE hardware offloaddrivers/net/ethernet/intel/ice/ice.h drivers/net/ethernet/intel/ice/ice_flex_pipe.c drivers/net/ethernet/intel/ice/ice_protocol_type.h +3 more+259 -20 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchGuillaume Nault
1/4A-b
2/4A-b
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [RFC PATCH net-next v6 0/4] ice: PPPoE offload support

Add support for dissecting PPPoE and PPP-specific fields in flow dissector:
PPPoE session id and PPP protocol type. Add support for those fields in tc-flower and support offloading PPPoE. Finally, add support for hardware offload of PPPoE packets in switchdev mode in ice driver.

Example filter:
tc filter add dev $PF1 ingress protocol ppp_ses prio 1 flower pppoe_sid \
1234 ppp_proto ip skip_sw action mirred egress redirect dev $VF1_PR

Changes in iproute2 are required to use the new fields (will be submitted soon).

ICE COMMS DDP package is required to create a filter in ice.

v6:
* make check for ppp proto more generic
* fix remaining byte order issues
v5: fix endianness when processing compressed protocols
v4:
* PPPoE header validation
* added MPLS support
* added support for compressed PPP protocol field
* flow_dissector_key_pppoe::session_id stored in __be16
* new field: flow_dissector_key_pppoe::type
* always add an ethtype lookup if PPP/PPPoE options are provided (to prevent setting incorrect ethtype)
* rebase
v3:
* revert byte order changes in is_ppp_proto_supported from previous version
* add kernel-doc for is_ppp_proto_supported
* add more CC
v2: cosmetic changes

Marcin Szycik (1):
ice: Add support for PPPoE hardware offload

Wojciech Drewek (3):
flow_dissector: Add PPPoE dissectors
net/sched: flower: Add PPPoE filter
flow_offload: Introduce flow_match_pppoe

 drivers/net/ethernet/intel/ice/ice.h          |   1 +
 .../net/ethernet/intel/ice/ice_flex_pipe.c    |   5 +-
 .../ethernet/intel/ice/ice_protocol_type.h    |  11 ++
 drivers/net/ethernet/intel/ice/ice_switch.c   | 165 ++++++++++++++++++
 drivers/net/ethernet/intel/ice/ice_tc_lib.c   |  71 +++++++-
 drivers/net/ethernet/intel/ice/ice_tc_lib.h   |   8 +
 include/linux/ppp_defs.h                      |  14 ++
 include/net/flow_dissector.h                  |  13 ++
 include/net/flow_offload.h                    |   6 +
 include/uapi/linux/pkt_cls.h                  |   3 +
 net/core/flow_dissector.c                     |  53 +++++-
 net/core/flow_offload.c                       |   7 +
 net/sched/cls_flower.c                        |  64 +++++++
 13 files changed, 412 insertions(+), 9 deletions(-)
Signature · 6 lines
2.35.1

_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan