Skip to content

fbcon: Fixes for screen resolution changes

Helge Deller dri-devel linux-fbdev 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 posting 2/24 patches 2 repliesIn review
  2. v6 Latest4 patches 7 repliesIn review
  3. v54 patches 2 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v43 patches2 repliesSuperseded
v3 posting 1/24 patches8 repliesSuperseded
v24 patches13 repliesSuperseded

Changes in v6 from the cover letter

- final version
- added all missing: Reviewed-by: Daniel Vetter <[email protected]>

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4fbcon: Disallow setting font bigger than screen sizedrivers/video/fbdev/core/fbcon.c+5 -00 replies
2/4fbmem: Prevent invalid virtual screen sizesdrivers/video/fbdev/core/fbmem.c+6 -02 replies
3/4fbcon: Prevent that screen size is smaller than font sizedrivers/video/fbdev/core/fbcon.c drivers/video/fbdev/core/fbmem.c include/linux/fbcon.h+34 -14 replies
4/4fbcon: Use fbcon_info_from_console() in fbcon_modechange_possible()drivers/video/fbdev/core/fbcon.c+1 -10 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchDaniel Vetter
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/4] fbcon: Fixes for screen resolution changes

This series fixes possible out-of-bound memory accesses when users trigger screen resolutions changes with invalid input parameters, e.g. reconfigures screen which is smaller than the current font size, or if the virtual screen size is smaller than the physical screen size.

v6:
- final version
- added all missing: Reviewed-by: Daniel Vetter <[email protected]>

v5:
- swapped patch #2 and #3
- modified patch #3 to use registered_fb[con2fb_map[i]] instead of fbcon_info_from_console(). This is necessary that the patch can
be cleanly pushed back to v5.4
- added cleanup patch #4 to fix up patch #3 again to use fbcon_info_from_console() for v5.19+

v4:
- merged former patch #2 and #3
- added more Reviewed-by
- new patch #2 needs more testing. Note added to comit message that another patch needs to be backport as well.

Helge Deller (4):
fbcon: Disallow setting font bigger than screen size
fbmem: Prevent invalid virtual screen sizes
fbcon: Prevent that screen size is smaller than font size
fbcon: Use fbcon_info_from_console() in fbcon_modechange_possible()

 drivers/video/fbdev/core/fbcon.c | 32 ++++++++++++++++++++++++++++++++
 drivers/video/fbdev/core/fbmem.c | 10 +++++++++-
 include/linux/fbcon.h            |  4 ++++
 3 files changed, 45 insertions(+), 1 deletion(-)

--
2.35.3