Skip to content

Vhost logs fixes and improvement

David Marchand dpdk-dev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 2 repliesIn review
  2. v14 patches 8 repliesSuperseded

Changes in v2 from the cover letter

- fixed log formats in patch4,

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4vhost: add some trailing newline in log messageslib/vhost/socket.c+5 -50 replies
2/4vhost: restore device information in log messageslib/vhost/vhost_user.c+6 -30 replies
3/4vhost: improve some datapath log messageslib/vhost/vhost.h+3 -30 replies
4/4vhost: prefix logs with contextlib/vhost/iotlb.c lib/vhost/socket.c lib/vhost/vdpa.c +4 more+634 -5933 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchChenbo XiaMaxime Coquelin
1/4R-b
2/4R-b
3/4R-b
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] Vhost logs fixes and improvement

Here is a series that fixes log messages (with one regression being fixed in patch 2) and changes the VHOST_LOG_* helpers to enforce that vhost log messages will always have some context/prefix to help debugging on setups with many vhost ports.

The first three patches are low risk and can probably be merged in v22.07.

Changes since v1:
- fixed log formats in patch4,

Signature · 19 lines
David Marchand

David Marchand (4):
  vhost: add some trailing newline in log messages
  vhost: restore device information in log messages
  vhost: improve some datapath log messages
  vhost: prefix logs with context

 lib/vhost/iotlb.c      |  30 +-
 lib/vhost/socket.c     | 129 ++++-----
 lib/vhost/vdpa.c       |   4 +-
 lib/vhost/vhost.c      | 144 +++++-----
 lib/vhost/vhost.h      |  20 +-
 lib/vhost/vhost_user.c | 639 +++++++++++++++++++++--------------------
 lib/vhost/virtio_net.c | 258 +++++++++--------
 7 files changed, 634 insertions(+), 590 deletions(-)

-- 
2.36.1