Vhost logs fixes and improvement
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest4 patches 2 repliesIn review
- v14 patches 8 repliesSuperseded
Changes in v2 from the cover letter
- fixed log formats in patch4,
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | vhost: add some trailing newline in log messageslib/ | +5 | 0 replies | |
| 2/4 | vhost: restore device information in log messageslib/ | +6 | 0 replies | |
| 3/4 | vhost: improve some datapath log messageslib/ | +3 | 0 replies | |
| 4/4 | vhost: prefix logs with contextlib/ lib/ lib/ +4 more | +634 | 3 replies |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Chenbo Xia | Maxime Coquelin |
|---|---|---|
| 1/4 | R-b | |
| 2/4 | R-b | |
| 3/4 | R-b | |
| 4/4 | R-b R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/4] Vhost logs fixes and improvement
Here is a series that fixes log messages (with one regression being fixed in patch 2) and changes the VHOST_LOG_* helpers to enforce that vhost log messages will always have some context/prefix to help debugging on setups with many vhost ports.
The first three patches are low risk and can probably be merged in v22.07.
Changes since v1:
- fixed log formats in patch4,
Signature · 19 lines
David Marchand David Marchand (4): vhost: add some trailing newline in log messages vhost: restore device information in log messages vhost: improve some datapath log messages vhost: prefix logs with context lib/vhost/iotlb.c | 30 +- lib/vhost/socket.c | 129 ++++----- lib/vhost/vdpa.c | 4 +- lib/vhost/vhost.c | 144 +++++----- lib/vhost/vhost.h | 20 +- lib/vhost/vhost_user.c | 639 +++++++++++++++++++++-------------------- lib/vhost/virtio_net.c | 258 +++++++++-------- 7 files changed, 634 insertions(+), 590 deletions(-) -- 2.36.1