Skip to content

fixed worker

Hao Xu io-uring 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v5 Latest11 patches 1 replyIn review

Changes in v5 from the cover letter

- code clean
- rebase against the for-5.20/io_uring

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11io-wq: add a worker flag for individual exitio_uring/io-wq.c+10 -10 replies
2/11io-wq: change argument of create_io_worker() for convienenceio_uring/io-wq.c+7 -50 replies
3/11io-wq: add infra data structure for fixed workersio_uring/io-wq.c+92 -110 replies
4/11io-wq: tweak io_get_acct()io_uring/io-wq.c+9 -50 replies
5/11io-wq: fixed worker initializationio_uring/io-wq.c+24 -00 replies
6/11io-wq: fixed worker exitio_uring/io-wq.c+26 -00 replies
7/11io-wq: implement fixed worker logicio_uring/io-wq.c+122 -260 replies
8/11io-wq: batch the handling of fixed worker private worksio_uring/io-wq.c io_uring/io-wq.h+38 -90 replies
9/11io_uring: add register fixed worker interfaceinclude/uapi/linux/io_uring.h io_uring/io-wq.c io_uring/io-wq.h +1 more+186 -00 replies
10/11io-wq: add an work list for fixed workerio_uring/io-wq.c+13 -70 replies
11/11io_uring: cancel works in exec work list for fixed workerio_uring/io-wq.c+35 -90 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCH v5 00/11] fixed worker

From: Hao Xu <[email protected]>

This is the second version of fixed worker implementation. Wrote a nop test program to test it, 3 fixed-workers VS 3 normal workers. normal workers:
./run_nop_wqe.sh nop_wqe_normal 200000 100 3 1-3

        time spent: 17314274 usecs      IOPS: 1155116
        time spent: 17016942 usecs      IOPS: 1175299
        time spent: 17908684 usecs      IOPS: 1116776

fixed workers:
./run_nop_wqe.sh nop_wqe_fixed 200000 100 3 1-3

        time spent: 10464397 usecs      IOPS: 1911242
        time spent: 9610976 usecs       IOPS: 2080954
        time spent: 9807361 usecs       IOPS: 2039284

About 2x improvement. From perf result, almost no acct->lock contension. Test program: https://github.com/HowHsu/liburing/tree/fixed_worker
liburing/test/nop_wqe.c

v3->v4:
- make work in fixed worker's private worfixed worker
- tweak the io_wqe_acct struct to make it clearer

v4->v5:
- code clean
- rebase against the for-5.20/io_uring

Hao Xu (11):
io-wq: add a worker flag for individual exit
io-wq: change argument of create_io_worker() for convienence
io-wq: add infra data structure for fixed workers
io-wq: tweak io_get_acct()
io-wq: fixed worker initialization
io-wq: fixed worker exit
io-wq: implement fixed worker logic
io-wq: batch the handling of fixed worker private works
io_uring: add register fixed worker interface
io-wq: add an work list for fixed worker
io_uring: cancel works in exec work list for fixed worker

 include/uapi/linux/io_uring.h |  11 +
 io_uring/io-wq.c              | 495 ++++++++++++++++++++++++++++++----
 io_uring/io-wq.h              |   8 +
 io_uring/io_uring.c           |  71 +++++
 4 files changed, 537 insertions(+), 48 deletions(-)

base-commit: 094abe8fbccb0d79bef982c67eb7372e92452c0e

Signature · 1 line
2.25.1