libvhost-user: NEED_REPLY behaviour fixes
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | docs/vhost-user: Fix mismergedocs/ | +0 | 1 reply | |
| 2/3 | libvhost-user: Fix VHOST_USER_GET_MAX_MEM_SLOTS replysubprojects/ | +2 | 0 replies | |
| 3/3 | libvhost-user: Fix VHOST_USER_ADD_MEM_REG replysubprojects/ | +1 | 0 replies |
Reviews trailers per patch
1 of 3 patches has a Reviewed-by or Acked-by.
| Patch | Peter Maydell |
|---|---|
| 1/3 | R-b |
| 2/3 | |
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/3] libvhost-user: NEED_REPLY behaviour fixes
Command handlers shouldn't send replies themselves, but just prepare the message and let vu_dispatch() send it. Otherwise, vu_dispatch() will add a second reply as an ACK when NEED_REPLY was requested.
QEMU's vhost-user devices are not affected by these bugs because they don't set NEED_REPLY for the commands that get it wrong. libblkio does run into it, though.
Kevin Wolf (3):
docs/vhost-user: Fix mismerge
libvhost-user: Fix VHOST_USER_GET_MAX_MEM_SLOTS reply
libvhost-user: Fix VHOST_USER_ADD_MEM_REG reply
docs/interop/vhost-user.rst | 16 ---------------- subprojects/libvhost-user/libvhost-user.c | 19 +++---------------- 2 files changed, 3 insertions(+), 32 deletions(-)
Signature · 1 line
2.35.3