Skip to content

KVM: nVMX: Use vmcs_config for setting up nested VMX MSRs

Vitaly Kuznetsov kvm linux-hyperv lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest14 patches 16 repliesIn review

Changes since RFC from the cover letter

- "KVM: VMX: Extend VMX controls macro shenanigans" PATCH added and the infrastructure is later used in other patches [Sean] PATCHes 1-3 added to support the change.
- "KVM: VMX: Clear controls obsoleted by EPT at runtime, not setup" PATCH added [Sean].
- Commit messages added.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14KVM: VMX: Check VM_ENTRY_IA32E_MODE in setup_vmcs_config()arch/x86/kvm/vmx/vmx.c+12 -30 replies
2/14KVM: VMX: Check CPU_BASED_{INTR,NMI}_WINDOW_EXITING in setup_vmcs_config()arch/x86/kvm/vmx/vmx.c+7 -10 replies
3/14KVM: VMX: Tweak the special handling of SECONDARY_EXEC_ENCLS_EXITING in setup_vmcs_config()arch/x86/kvm/vmx/vmx.c+6 -30 replies
4/14KVM: VMX: Extend VMX controls macro shenanigansarch/x86/kvm/vmx/vmx.c arch/x86/kvm/vmx/vmx.h+127 -815 replies
5/14KVM: VMX: Move CPU_BASED_CR8_{LOAD,STORE}_EXITING filtering out of setup_vmcs_config()arch/x86/kvm/vmx/vmx.c+6 -70 replies
6/14KVM: VMX: Add missing VMEXIT controls to vmcs_configarch/x86/kvm/vmx/vmx.c arch/x86/kvm/vmx/vmx.h+7 -00 replies
7/14KVM: VMX: Add missing VMENTRY controls to vmcs_configarch/x86/kvm/vmx/vmx.c arch/x86/kvm/vmx/vmx.h+6 -10 replies
8/14KVM: VMX: Add missing CPU based VM execution controls to vmcs_configarch/x86/kvm/vmx/vmx.c arch/x86/kvm/vmx/vmx.h+11 -10 replies
9/14KVM: VMX: Clear controls obsoleted by EPT at runtime, not setuparch/x86/kvm/vmx/vmx.c+7 -110 replies
10/14KVM: nVMX: Use sanitized allowed-1 bits for VMX control MSRsarch/x86/kvm/vmx/nested.c arch/x86/kvm/vmx/nested.h arch/x86/kvm/vmx/vmx.c+19 -220 replies
11/14KVM: VMX: Store required-1 VMX controls in vmcs_configarch/x86/kvm/vmx/capabilities.h arch/x86/kvm/vmx/vmx.c+26 -70 replies
12/14KVM: nVMX: Use sanitized required-1 bits for VMX control MSRsarch/x86/kvm/vmx/nested.c+1 -50 replies
13/14KVM: VMX: Cache MSR_IA32_VMX_MISC in vmcs_configarch/x86/kvm/vmx/capabilities.h arch/x86/kvm/vmx/vmx.c+8 -110 replies
14/14KVM: nVMX: Use cached host MSR_IA32_VMX_MISC value for setting up nested MSRarch/x86/kvm/vmx/nested.c+1 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/14] KVM: nVMX: Use vmcs_config for setting up nested VMX MSRs

Changes since RFC:
- "KVM: VMX: Extend VMX controls macro shenanigans" PATCH added and the infrastructure is later used in other patches [Sean] PATCHes 1-3 added to support the change.
- "KVM: VMX: Clear controls obsoleted by EPT at runtime, not setup" PATCH added [Sean].
- Commit messages added.

vmcs_config is a sanitized version of host VMX MSRs where some controls are filtered out (e.g. when Enlightened VMCS is enabled, some know bugs are discovered, some inconsistencies in controls are detected,...) but nested_vmx_setup_ctls_msrs() uses raw host MSRs instead. This may end up in exposing undesired controls to L1. Switch to using vmcs_config instead.

Sean Christopherson (1):
KVM: VMX: Clear controls obsoleted by EPT at runtime, not setup

Vitaly Kuznetsov (13):
KVM: VMX: Check VM_ENTRY_IA32E_MODE in setup_vmcs_config()
KVM: VMX: Check CPU_BASED_{INTR,NMI}_WINDOW_EXITING in
setup_vmcs_config()
KVM: VMX: Tweak the special handling of SECONDARY_EXEC_ENCLS_EXITING
in setup_vmcs_config()
KVM: VMX: Extend VMX controls macro shenanigans
KVM: VMX: Move CPU_BASED_CR8_{LOAD,STORE}_EXITING filtering out of
setup_vmcs_config()
KVM: VMX: Add missing VMEXIT controls to vmcs_config
KVM: VMX: Add missing VMENTRY controls to vmcs_config
KVM: VMX: Add missing CPU based VM execution controls to vmcs_config
KVM: nVMX: Use sanitized allowed-1 bits for VMX control MSRs
KVM: VMX: Store required-1 VMX controls in vmcs_config
KVM: nVMX: Use sanitized required-1 bits for VMX control MSRs
KVM: VMX: Cache MSR_IA32_VMX_MISC in vmcs_config
KVM: nVMX: Use cached host MSR_IA32_VMX_MISC value for setting up
nested MSR

 arch/x86/kvm/vmx/capabilities.h |  16 +--
 arch/x86/kvm/vmx/nested.c       |  37 +++---
 arch/x86/kvm/vmx/nested.h       |   2 +-
 arch/x86/kvm/vmx/vmx.c          | 198 ++++++++++++++------------------
 arch/x86/kvm/vmx/vmx.h          | 118 +++++++++++++++++++
 5 files changed, 229 insertions(+), 142 deletions(-)
Signature · 1 line
2.35.3