Skip to content

KUnit tests for RGB565 conversion

José Expósito dri-devel lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 1 replyIn review
  2. v24 patches 10 repliesSuperseded
  3. v14 patches 5 repliesSuperseded

Changes in v3 from the cover letter

- Test endian as fixed in commit 4d9db10576ff ("drm/format-helper: Fix endianness in drm_fb_*_to_*() conversion helpers")
- Fix Sparse warning reported by David Gow
- Add Reviewed-by David Gow

[1] https://lore.kernel.org/dri-devel/[email protected]/

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/format-helper: Fix test on big endian architecturesdrivers/gpu/drm/tests/drm_format_helper_test.c+21 -20 replies
2/4drm/format-helper: Rename test cases to make them more genericdrivers/gpu/drm/tests/drm_format_helper_test.c+8 -90 replies
3/4drm/format-helper: Support multiple target formats resultsdrivers/gpu/drm/tests/drm_format_helper_test.c+33 -200 replies
4/4drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb565()drivers/gpu/drm/tests/drm_format_helper_test.c+78 -00 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchDavid GowTales L. AparecidaThomas Zimmermann
1/4R-b
2/4R-b T-b A-b
3/4R-b T-b A-b
4/4R-b T-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/4] KUnit tests for RGB565 conversion

Hello everyone,

This series is a follow up of the XRGB8888 to RGB332 conversion KUnit tests.

As I mentioned in v2 [1] I suspected that the inconsistency handling the endian might need to be fixed.
Fortunately, Geert Uytterhoeven fixed it in commit 4d9db10576ff ("drm/format-helper: Fix endianness in drm_fb_*_to_*() conversion helpers"), so I updated the tests to reflect his change.

Changes since v1:

- Fix a bug reported by David Gow in the XRGB8888 to RGB332 tests
- Simplify the test structure as suggested by David Gow
- Add Tested-by Tales L. Aparecida and Acked-by Thomas Zimmermann
- Fix link in the last patch (Thomas Zimmermann)

Changes since v2:

- Test endian as fixed in commit 4d9db10576ff ("drm/format-helper: Fix endianness in drm_fb_*_to_*() conversion helpers")
- Fix Sparse warning reported by David Gow
- Add Reviewed-by David Gow

[1] https://lore.kernel.org/dri-devel/[email protected]/

José Expósito (4):
drm/format-helper: Fix test on big endian architectures drm/format-helper: Rename test cases to make them more generic drm/format-helper: Support multiple target formats results drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb565()

 .../gpu/drm/tests/drm_format_helper_test.c    | 169 ++++++++++++++----
 1 file changed, 139 insertions(+), 30 deletions(-)
Signature · 1 line
2.25.1