Zero copy improvements (QIOChannel + multifd)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest3 patches 5 repliesIn review
- v33 patches 19 repliesSuperseded
- v23 patches 10 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 2 patches | 8 replies | Superseded |
Changes in v4 from the cover letter
- Patch#1: Also checks if no packet was queued after the last flush
- Patch#2: Improve dirty-sync-missed-zero-copy doc and hmp print message
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | QIOChannelSocket: Fix zero-copy flush returning code 1 when nothing sentio/ | +7 | 1 reply | |
| 2/3 | Add dirty-sync-missed-zero-copy migration statmigration/ monitor/ qapi/ | +13 | 1 reply | |
| 3/3 | migration/multifd: Report to user when zerocopy not workingmigration/ migration/ migration/ | +9 | 2 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Daniel P. Berrangé | Juan Quintela | Markus Armbruster | Peter Xu |
|---|---|---|---|---|
| 1/3 | R-b A-b | R-b | R-b | |
| 2/3 | R-b | A-b | A-b | |
| 3/3 | R-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v4 0/3] Zero copy improvements (QIOChannel + multifd)
The first patch avoid spuriously returning 1 [*] when zero-copy flush is attempted before any buffer was sent using MSG_ZEROCOPY.
[*] zero-copy not being used, even though it's enabled and supported by kernel
The second patch introduces a new migration stat (dirty-sync-missed-zero-copy) that will be used to keep track of [*].
The third patch keeps track of how many zero-copy flushes retured 1 [*]
Changes since v3:
- Patch#1: Also checks if no packet was queued after the last flush
- Patch#2: Improve dirty-sync-missed-zero-copy doc and hmp print message
Changes since v2:
- Documentation release number changed from 7.2 to 7.1
- migration stat renamed from zero-copy-copied to dirty-sync-missed-zero-copy
- Updated documentation to make it more user-friendly
Changes since v1:
- Idea of using a warning replaced by using a migration stat counter
Leonardo Bras (3):
QIOChannelSocket: Fix zero-copy flush returning code 1 when nothing
sent
Add dirty-sync-missed-zero-copy migration stat migration/multifd: Report to user when zerocopy not working
qapi/migration.json | 7 ++++++- migration/ram.h | 2 ++ io/channel-socket.c | 8 +++++++- migration/migration.c | 2 ++ migration/multifd.c | 2 ++ migration/ram.c | 5 +++++ monitor/hmp-cmds.c | 5 +++++ 7 files changed, 29 insertions(+), 2 deletions(-)
Signature · 1 line
2.37.0