tests: improve reliability of migration test
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest5 patches 12 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | tests: wait max 120 seconds for migration test status changestests/ | +14 | 2 replies | |
| 2/5 | tests: wait for migration completion before looking for STOP eventtests/ | +4 | 3 replies | |
| 3/5 | tests: increase migration test converge downtime to 30 secondstests/ | +1 | 1 reply | |
| 4/5 | tests: use consistent bandwidth/downtime limits in migration teststests/ | +20 | 1 reply | |
| 5/5 | tests: stop skipping migration test on s390x/ppc64tests/ | +0 | 4 replies |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by.
| Patch | Laurent Vivier | Thomas Huth | Dr. David Alan Gilbert |
|---|---|---|---|
| Series | T-b | ||
| 1/5 | R-b | R-b | |
| 2/5 | R-b | R-b | |
| 3/5 | R-b | ||
| 4/5 | R-b | ||
| 5/5 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH 0/5] tests: improve reliability of migration test
Since the TLS tests were added a few people have reported seeing hangs in some of the TLS test cases for migration. Debugging has revealed that in all cases the test was waiting for a STOP event that never arrived.
The problem is that TLS performance is highly dependant on the crypto impl. Some people have been running tests on machines which are highly efficient at running the guest dirtying workload but relatively slow at TLS. This has prevented convergance from being reliably achieved in the configured max downtime.
Since this test design has been long standing I suspect the lack of convergance is a likely cause of previous hangs we've seen in various scenarios that resulted in us disabling the test on s390 TCG, ppc TCG and ppc KVM-PR.
Thus I have suggested we drop this skip conditions, though I would note that I've not had the ability to actually test the effect that this has.
Daniel P. Berrangé (5):
tests: wait max 120 seconds for migration test status changes
tests: wait for migration completion before looking for STOP event
tests: increase migration test converge downtime to 30 seconds
tests: use consistent bandwidth/downtime limits in migration tests
tests: stop skipping migration test on s390x/ppc64
tests/qtest/migration-helpers.c | 14 ++++++ tests/qtest/migration-test.c | 80 ++++++++++----------------------- 2 files changed, 38 insertions(+), 56 deletions(-)
Signature · 1 line
2.36.1