Skip to content

serial: 8250_dw: Rework ->serial_out() & LCR retry logic

Ilpo Järvinen linux-serial lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4serial: 8250_dw: Use dw8250_serial_out() in dw8250_serial_out38x()drivers/tty/serial/8250/8250_dw.c+6 -120 replies
2/4serial: 8250_dw: Rename offset to reg_offsetdrivers/tty/serial/8250/8250_dw.c+5 -53 replies
3/4serial: 8250_dw: Move 16550 compatible & LCR checks to dw8250_verify_write()drivers/tty/serial/8250/8250_dw.c+17 -181 reply
4/4serial: 8250_dw: Rework ->serial_out() LCR write retry logicdrivers/tty/serial/8250/8250_dw.c+35 -245 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] serial: 8250_dw: Rework ->serial_out() & LCR retry logic

This series reworks DW UART's write logic such that the write in ->serial_out() is reused for LCR retries which allows removing those ugly duplicated writes in dw8250_check_lcr() (renamed to dw8250_verify_write() by this series).

I've used label+goto since the retry is really an exceptional thing. If somebody insists, I can convert those to do {} while (); but I feel it will give wrong impression that there's a "loop" there.

Ilpo Järvinen (4):
serial: 8250_dw: Use dw8250_serial_out() in dw8250_serial_out38x()
serial: 8250_dw: Rename offset to reg_offset
serial: 8250_dw: Move 16550 compatible & LCR checks to

    dw8250_verify_write()

serial: 8250_dw: Rework ->serial_out() LCR write retry logic

 drivers/tty/serial/8250/8250_dw.c | 90 ++++++++++++++++---------------
 1 file changed, 47 insertions(+), 43 deletions(-)
Signature · 1 line
2.30.2