Skip to content

hw/i2c/aspeed: Add new-registers DMA slave mode RX support

Peter Delevoryas qemu-arm qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest13 patches 17 repliesIn review

Changes in v2 from the cover letter

- Replaced printf's with qemu_log_mask or trace events.
- Added more detailed commit messages to several commits.
- Removed one unnecessary patch through reordering intel-me before oby35-cl.
- Replaced PECI register #define's with registerfields.h API.
- Renamed fby35-cpld to fby35-sb-cpld to be more specific.
- Moved the I2C patches to the start of the series, and the optional device/machine stuff to the end of the series.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13hw/i2c/aspeed: Fix R_I2CD_FUN_CTRL referencehw/i2c/aspeed_i2c.c+1 -11 reply
2/13hw/i2c/aspeed: Fix DMA len write-enable bit handlinghw/i2c/aspeed_i2c.c+4 -41 reply
3/13hw/i2c/aspeed: Fix MASTER_EN missing error messagehw/i2c/aspeed_i2c.c+2 -21 reply
4/13hw/i2c: support multiple mastershw/i2c/core.c include/hw/i2c/i2c.h+47 -11 reply
5/13hw/i2c: add asynchronous sendhw/arm/pxa2xx.c hw/display/sii9022.c hw/display/ssd0303.c +6 more+67 -10 replies
6/13hw/i2c/aspeed: add slave device in old register modehw/i2c/aspeed_i2c.c include/hw/i2c/aspeed_i2c.h+88 -90 replies
7/13hw/i2c/aspeed: Add new-registers DMA slave mode RX supporthw/i2c/aspeed_i2c.c include/hw/i2c/aspeed_i2c.h+124 -120 replies
8/13hw/i2c/pmbus: Reset out buf after switching pageshw/i2c/pmbus_device.c+1 -04 replies
9/13hw/i2c/pmbus: Add read-only IC_DEVICE_ID supporthw/i2c/pmbus_device.c hw/sensor/isl_pmbus_vr.c include/hw/i2c/pmbus_device.h +1 more+38 -06 replies
10/13hw/misc/aspeed: Add PECI controllerhw/arm/aspeed_ast10x0.c hw/arm/aspeed_ast2600.c hw/arm/aspeed_soc.c +5 more+229 -13 replies
11/13hw/misc/aspeed: Add fby35-sb-cpldMAINTAINERS hw/misc/fby35_sb_cpld.c hw/misc/meson.build+131 -10 replies
12/13hw/misc/aspeed: Add intel-meMAINTAINERS hw/misc/intel_me.c hw/misc/meson.build +1 more+173 -10 replies
13/13hw/arm/aspeed: Add oby35-cl machinehw/arm/aspeed.c+48 -00 replies

Reviews trailers per patch

4 of 13 patches have a Reviewed-by or Acked-by.

PatchCédric Le Goater
1/13R-b
2/13R-b
3/13R-b
4/13
5/13
6/13
7/13
8/13R-b
9/13
10/13
11/13
12/13
13/13

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/13] hw/i2c/aspeed: Add new-registers DMA slave mode RX support

Hey Cedric,

I've gone over the patch series and reordered it a little better.

Changes since v1:
- Replaced printf's with qemu_log_mask or trace events.
- Added more detailed commit messages to several commits.
- Removed one unnecessary patch through reordering intel-me before oby35-cl.
- Replaced PECI register #define's with registerfields.h API.
- Renamed fby35-cpld to fby35-sb-cpld to be more specific.
- Moved the I2C patches to the start of the series, and the optional device/machine stuff to the end of the series.

If you'd like, I can separate this into separate patch series.

However, as I mentioned in the previous series, I was using oby35-cl to test the I2C master and slave mode support in QEMU against Zephyr, and this patch series includes everything put together.

Hopefully my patch series actually arrives in one piece this time.

Thanks,
Peter

v1: https://lore.kernel.org/qemu-devel/[email protected]/

Klaus Jensen (3):
hw/i2c: support multiple masters
hw/i2c: add asynchronous send hw/i2c/aspeed: add slave device in old register mode

Peter Delevoryas (10):
hw/i2c/aspeed: Fix R_I2CD_FUN_CTRL reference hw/i2c/aspeed: Fix DMA len write-enable bit handling hw/i2c/aspeed: Fix MASTER_EN missing error message hw/i2c/aspeed: Add new-registers DMA slave mode RX support hw/i2c/pmbus: Reset out buf after switching pages hw/i2c/pmbus: Add read-only IC_DEVICE_ID support hw/misc/aspeed: Add PECI controller hw/misc/aspeed: Add fby35-sb-cpld hw/misc/aspeed: Add intel-me
hw/arm/aspeed: Add oby35-cl machine

 MAINTAINERS                      |   2 +
 hw/arm/aspeed.c                  |  48 +++++++
 hw/arm/aspeed_ast10x0.c          |  12 ++
 hw/arm/aspeed_ast2600.c          |  12 ++
 hw/arm/aspeed_soc.c              |  13 ++
 hw/arm/pxa2xx.c                  |   2 +
 hw/display/sii9022.c             |   2 +
 hw/display/ssd0303.c             |   2 +
 hw/i2c/aspeed_i2c.c              | 234 +++++++++++++++++++++++++++----
 hw/i2c/core.c                    |  70 ++++++++-
 hw/i2c/pmbus_device.c            |   6 +
 hw/i2c/smbus_slave.c             |   4 +
 hw/i2c/trace-events              |   2 +
 hw/misc/aspeed_peci.c            | 136 ++++++++++++++++++
 hw/misc/fby35_sb_cpld.c          | 128 +++++++++++++++++
 hw/misc/intel_me.c               | 162 +++++++++++++++++++++
 hw/misc/meson.build              |   5 +-
 hw/misc/trace-events             |  12 ++
 hw/nvram/eeprom_at24c.c          |   2 +
 hw/sensor/isl_pmbus_vr.c         |  31 ++++
 hw/sensor/lsm303dlhc_mag.c       |   2 +
 include/hw/arm/aspeed_soc.h      |   3 +
 include/hw/i2c/aspeed_i2c.h      |  11 ++
 include/hw/i2c/i2c.h             |  30 ++++
 include/hw/i2c/pmbus_device.h    |   1 +
 include/hw/misc/aspeed_peci.h    |  47 +++++++
 include/hw/sensor/isl_pmbus_vr.h |   1 +
 27 files changed, 950 insertions(+), 30 deletions(-)
 create mode 100644 hw/misc/aspeed_peci.c
 create mode 100644 hw/misc/fby35_sb_cpld.c
 create mode 100644 hw/misc/intel_me.c
 create mode 100644 include/hw/misc/aspeed_peci.h
Signature · 1 line
2.30.2