RFC net: dsa: realtek: drop custom slave MII
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest3 patches 9 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | net: dsa: realtek: rename switch_ops to its usage, not usersdrivers/ drivers/ drivers/ +2 more | +12 | 0 replies | |
| 2/3 | net: dsa: realtek: deprecate custom slave miidrivers/ | +18 | 0 replies | |
| 3/3 | net: dsa: realtek: remove deprecated custom slave miidrivers/ drivers/ drivers/ +1 more | +8 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH net-next RFC 0/3] net: dsa: realtek: drop custom slave MII
The last patch cleans all the deprecated code while keeping the kernel messages. However, if there is no "mdio" node but there is a node with the old compatible stings "realtek,smi-mdio", it will show an error. It should still work but it will use polling instead of interruptions.
My idea, if accepted, is to submit patches 1 and 2 now. After a reasonable period, submit patch 3.
I don't have an SMI-connected device and I'm asking for testers. It would be nice to test the first 2 patches with:
1) "mdio" without a compatible string. It should work without warnings.
2) "mdio" with a compatible string. It should work with a warning asking to remove the compatible string
3) "xxx" node with compatible string. It should work with a warning asking to rename "xxx" to "mdio" and remove the compatible string
In all those cases, the switch should still keep using interruptions.
After that, the last patch can be applied. The same tests can be performed:
1) "mdio" without a compatible string. It should work without warnings.
2) "mdio" with a compatible string. It should work with a warning asking to remove the compatible string
3) "xxx" node with compatible string. It should work with an error asking to rename "xxx" to "mdio" and remove the compatible string. The switch will use polling instead of interruptions.
This series might inspire other drivers as well. Currently, most dsa driver implements a custom slave mii, normally only defining a phy_{read,write} and loading properties from an "mdio" OF node. Since fe7324b932, dsa generic code can do all that if the mdio node is named "mdio". I believe most drivers could simply drop their slave mii implementations and add phy_{read,write} to the dsa_switch_ops. For drivers that look for an "mdio-like" node using a compatible string, it might need some type of transition to let vendors update their OF tree.
Regards,
Luiz