Skip to content

fbcon: Fixes for screen resolution changes - round 2

Helge Deller dri-devel linux-fbdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/24 patches 6 repliesIn review
  2. v2 posting 1/23 of 4 patches 0 repliesSuperseded
  3. v15 patches 22 repliesSuperseded

Changes in v2 from the cover letter

- don't fixup wrong xy_vres values, but instead print warning.
- add Reviewed-by tags, minor variable name fixes

Patches in v2 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4fbcon: Disallow setting font bigger than screen sizedrivers/video/fbdev/core/fbcon.c+5 -00 replies
2/4fbcon: Prevent that screen size is smaller than font sizedrivers/video/fbdev/core/fbcon.c drivers/video/fbdev/core/fbmem.c include/linux/fbcon.h+35 -11 reply
3/4fbmem: Prevent invalid virtual screen sizes in fb_set_var()drivers/video/fbdev/core/fbmem.c+12 -04 replies
4/4fbcon: Use fbcon_info_from_console() in fbcon_modechange_possible()drivers/video/fbdev/core/fbcon.c+1 -10 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchDaniel VetterGeert Uytterhoeven
1/4R-b R-b
2/4
3/4
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] fbcon: Fixes for screen resolution changes - round 2

This series fixes possible out-of-bound memory accesses when users trigger screen resolutions changes with invalid input parameters, e.g. reconfigures screen which is smaller than the current font size, or if the virtual screen size is smaller than the physical screen size.

Changes in v2:
- don't fixup wrong xy_vres values, but instead print warning.
- add Reviewed-by tags, minor variable name fixes

Helge Deller (4):
fbcon: Disallow setting font bigger than screen size
fbcon: Prevent that screen size is smaller than font size
fbmem: Prevent invalid virtual screen sizes in fb_set_var()
fbcon: Use fbcon_info_from_console() in fbcon_modechange_possible()

 drivers/video/fbdev/core/fbcon.c | 33 ++++++++++++++++++++++++++++++++
 drivers/video/fbdev/core/fbmem.c | 16 +++++++++++++++-
 include/linux/fbcon.h            |  4 ++++
 3 files changed, 52 insertions(+), 1 deletion(-)

--
2.35.3