Skip to content

hw/i2c/aspeed: I2C slave mode DMA RX w/ new regs

Peter Delevoryas qemu-arm qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest14 patches 19 repliesIn review

Changes in v3 from the cover letter

- hw/i2c/pmbus_device:
- Removed commit that resets the out buf.
- Removed IC_DEVICE_ID
- Added commit to allow devices to move to an idle state that avoids enqueuing excess data into the out buf.
- hw/sensor/isl_pmbus_vr:
- Added IC_DEVICE_ID commit just for voltage regulators.
- Added ISL69259 with an IC_DEVICE_ID.
- hw/misc/aspeed_peci:
- Moved registers from .h to .c
- Replaced guest_error on interrupt disable case with trace for all interrupts (not just when they're disabled).
- Removed leftover qemu_irq_raise

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14hw/i2c/aspeed: Fix R_I2CD_FUN_CTRL referencehw/i2c/aspeed_i2c.c+1 -10 replies
2/14hw/i2c/aspeed: Fix DMA len write-enable bit handlinghw/i2c/aspeed_i2c.c+4 -40 replies
3/14hw/i2c/aspeed: Fix MASTER_EN missing error messagehw/i2c/aspeed_i2c.c+2 -20 replies
4/14hw/i2c: support multiple mastershw/i2c/core.c include/hw/i2c/i2c.h+47 -10 replies
5/14hw/i2c: add asynchronous sendhw/arm/pxa2xx.c hw/display/sii9022.c hw/display/ssd0303.c +6 more+67 -10 replies
6/14hw/i2c/aspeed: add slave device in old register modehw/i2c/aspeed_i2c.c include/hw/i2c/aspeed_i2c.h+88 -90 replies
7/14hw/i2c/aspeed: Add new-registers DMA slave mode RX supporthw/i2c/aspeed_i2c.c include/hw/i2c/aspeed_i2c.h+124 -120 replies
8/14hw/i2c/pmbus: Add idle state to return 0xff'shw/i2c/pmbus_device.c include/hw/i2c/pmbus_device.h+16 -01 reply
9/14hw/sensor: Add IC_DEVICE_ID to ISL voltage regulatorshw/sensor/isl_pmbus_vr.c include/hw/sensor/isl_pmbus_vr.h+17 -01 reply
10/14hw/sensor: Add Renesas ISL69259 device modelhw/sensor/isl_pmbus_vr.c+28 -05 replies
11/14hw/misc/aspeed: Add PECI controllerhw/arm/aspeed_ast10x0.c hw/arm/aspeed_ast2600.c hw/arm/aspeed_soc.c +5 more+228 -11 reply
12/14hw/misc/aspeed: Add fby35-sb-cpldMAINTAINERS hw/misc/fby35_sb_cpld.c hw/misc/meson.build+131 -11 reply
13/14hw/misc/aspeed: Add intel-meMAINTAINERS hw/misc/intel_me.c hw/misc/meson.build +1 more+173 -12 replies
14/14hw/arm/aspeed: Add oby35-cl machinehw/arm/aspeed.c+48 -06 replies

Reviews trailers per patch

3 of 14 patches have a Reviewed-by or Acked-by.

PatchCédric Le GoaterTitus Rwantare
1/14
2/14
3/14
4/14
5/14
6/14
7/14
8/14R-b
9/14R-b
10/14
11/14R-b
12/14
13/14
14/14

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/14] hw/i2c/aspeed: I2C slave mode DMA RX w/ new regs

From: Peter Delevoryas <[email protected]>

v3:
- hw/i2c/pmbus_device:
- Removed commit that resets the out buf.
- Removed IC_DEVICE_ID
- Added commit to allow devices to move to an idle state that avoids enqueuing excess data into the out buf.
- hw/sensor/isl_pmbus_vr:
- Added IC_DEVICE_ID commit just for voltage regulators.
- Added ISL69259 with an IC_DEVICE_ID.
- hw/misc/aspeed_peci:
- Moved registers from .h to .c
- Replaced guest_error on interrupt disable case with trace for all interrupts (not just when they're disabled).
- Removed leftover qemu_irq_raise

Thanks,
Peter

Klaus Jensen (3):
hw/i2c: support multiple masters
hw/i2c: add asynchronous send hw/i2c/aspeed: add slave device in old register mode

Peter Delevoryas (11):
hw/i2c/aspeed: Fix R_I2CD_FUN_CTRL reference hw/i2c/aspeed: Fix DMA len write-enable bit handling hw/i2c/aspeed: Fix MASTER_EN missing error message hw/i2c/aspeed: Add new-registers DMA slave mode RX support hw/i2c/pmbus: Add idle state to return 0xff's hw/sensor: Add IC_DEVICE_ID to ISL voltage regulators hw/sensor: Add Renesas ISL69259 device model hw/misc/aspeed: Add PECI controller hw/misc/aspeed: Add fby35-sb-cpld hw/misc/aspeed: Add intel-me
hw/arm/aspeed: Add oby35-cl machine

 MAINTAINERS                      |   2 +
 hw/arm/aspeed.c                  |  48 +++++++
 hw/arm/aspeed_ast10x0.c          |  12 ++
 hw/arm/aspeed_ast2600.c          |  12 ++
 hw/arm/aspeed_soc.c              |  13 ++
 hw/arm/pxa2xx.c                  |   2 +
 hw/display/sii9022.c             |   2 +
 hw/display/ssd0303.c             |   2 +
 hw/i2c/aspeed_i2c.c              | 234 +++++++++++++++++++++++++++----
 hw/i2c/core.c                    |  70 ++++++++-
 hw/i2c/pmbus_device.c            |   9 ++
 hw/i2c/smbus_slave.c             |   4 +
 hw/i2c/trace-events              |   2 +
 hw/misc/aspeed_peci.c            | 152 ++++++++++++++++++++
 hw/misc/fby35_sb_cpld.c          | 128 +++++++++++++++++
 hw/misc/intel_me.c               | 162 +++++++++++++++++++++
 hw/misc/meson.build              |   5 +-
 hw/misc/trace-events             |  13 ++
 hw/nvram/eeprom_at24c.c          |   2 +
 hw/sensor/isl_pmbus_vr.c         |  40 ++++++
 hw/sensor/lsm303dlhc_mag.c       |   2 +
 include/hw/arm/aspeed_soc.h      |   3 +
 include/hw/i2c/aspeed_i2c.h      |  11 ++
 include/hw/i2c/i2c.h             |  30 ++++
 include/hw/i2c/pmbus_device.h    |   7 +
 include/hw/misc/aspeed_peci.h    |  29 ++++
 include/hw/sensor/isl_pmbus_vr.h |   5 +
 27 files changed, 971 insertions(+), 30 deletions(-)
 create mode 100644 hw/misc/aspeed_peci.c
 create mode 100644 hw/misc/fby35_sb_cpld.c
 create mode 100644 hw/misc/intel_me.c
 create mode 100644 include/hw/misc/aspeed_peci.h
Signature · 1 line
2.37.0