Skip to content

Add panic test support

Nico Boehr kvm 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest4 patches 3 repliesIn review
  2. v54 patches 4 repliesSuperseded
  3. v44 patches 6 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v34 patches10 repliesSuperseded
v24 patches4 repliesSuperseded
v13 patches11 repliesSuperseded

Changes in v6 from the cover letter

---
* minor commit message fixes (thanks Janosch)

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4runtime: add support for panic testss390x/run scripts/arch-run.bash scripts/runtime.bash+53 -10 replies
2/4lib/s390x: add CPU timer related defines and functionslib/s390x/asm/arch_def.h lib/s390x/asm/time.h+17 -11 reply
3/4s390x: add extint loop tests390x/Makefile s390x/panic-loop-extint.c s390x/unittests.cfg+66 -00 replies
4/4s390x: add pgm spec interrupt loop tests390x/Makefile s390x/panic-loop-pgm.c s390x/unittests.cfg+45 -01 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchThomas HuthJanosch FrankClaudio Imbrenda
1/4R-b A-b R-b
2/4R-b R-b
3/4R-b R-b
4/4R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v6 thread

Cover letter [kvm-unit-tests PATCH v6 0/4] Add panic test support

v5->v6:
---
* minor commit message fixes (thanks Janosch)

v4->v5:
---
* use psw_mask_set_bits instead of load_psw_mask/extract_psw_mask (thanks Claudio)
* add missing space in pgm int (thanks Janosch)
* set bit 12 to cause a pgm int (thanks Janosch)

v3->v4:
---
* avoid backslash at line end in scripts wherever possible (thanks Claudio)
* remove selfmade interrupt handlers and use kvm-unit-test default handers. This simplifies the code quite a bit.
* fix cpu timer and clock comparator confusion

v2->v3:
---
* rename TIMING_S390_SHIFT_US->S390_CLOCK_SHIFT_US (thanks Claudio)
* rename cpu_timer_set -> cpu_timer_set_ms (thanks Claudio)

v1->v2:
---
* fix spelling mistakes/long lines (thanks Thomas)
* quoting improvments (thanks Thomas)
* smaller timeout for tests (thanks Thomas and Janis)
* move function and defines for cpu timer to time.h (thanks Janosch)
* fence tests for non-QEMU/KVM (thanks Janosch)

QEMU suports a guest state "guest-panicked" which indicates something in the guest went wrong, for example on s390x, when an external interrupt loop was triggered.

Since the guest does not continue to run when it is in the guest-panicked state, it is currently impossible to write panicking tests in kvm-unit-tests. Support from the runtime is needed to check that the guest enters the guest-panicked state.

This series adds the required support to the runtime together with two tests for s390x which cause guest panics.

Nico Boehr (4):
runtime: add support for panic tests lib/s390x: add CPU timer related defines and functions
s390x: add extint loop test
s390x: add pgm spec interrupt loop test

 lib/s390x/asm/arch_def.h  |  1 +
 lib/s390x/asm/time.h      | 17 ++++++++++-
 s390x/Makefile            |  2 ++
 s390x/panic-loop-extint.c | 59 +++++++++++++++++++++++++++++++++++++++
 s390x/panic-loop-pgm.c    | 38 +++++++++++++++++++++++++
 s390x/run                 |  2 +-
 s390x/unittests.cfg       | 12 ++++++++
 scripts/arch-run.bash     | 49 ++++++++++++++++++++++++++++++++
 scripts/runtime.bash      |  3 ++
 9 files changed, 181 insertions(+), 2 deletions(-)
 create mode 100644 s390x/panic-loop-extint.c
 create mode 100644 s390x/panic-loop-pgm.c
Signature · 1 line
2.36.1