Skip to content

cleanup error handling in kvmppc_read_int_cpu_dt()

Daniel Henrique Barboza qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 1 replyIn review
  2. v19 patches 22 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5target/ppc/kvm.c: do not return -1 on uint64_t returntarget/ppc/kvm.c+2 -21 reply
2/5target/ppc: add errp to kvmppc_read_int_cpu_dt()target/ppc/kvm.c+9 -70 replies
3/5target/ppc: Add error reporting when opening file failstarget/ppc/kvm.c+3 -20 replies
4/5target/ppc: use g_autofree in kvmppc_read_int_cpu_dt()target/ppc/kvm.c+3 -50 replies
5/5target/ppc: exit(1) on failure in kvmppc_get_clockfreq()target/ppc/kvm.c+16 -10 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchCédric Le Goater
1/5
2/5
3/5R-b
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] cleanup error handling in kvmppc_read_int_cpu_dt()

Hi,

In this second version the biggest change is that I decided to error_fatal inside kvmppc_get_clockfreq().

After the discussions in v1 [1] it became clear that falling back to a default value when 'clock-frequency' is missing is a bad idea. Not because of the default value per se, but for the absence of this root node property in the userspace.

This assumption works fine with pSeries, the most used KVM platform we have today. If this change causes a legitimate regression (i.e. a valid use case where clock-frequency is missing from the DT and it's ok) in other KVM-capable ppc boards, we can amend it case by case.

[1] https://lists.gnu.org/archive/html/qemu-devel/2022-06/msg05751.html

Daniel Henrique Barboza (4):
target/ppc/kvm.c: do not return -1 on uint64_t return target/ppc: add errp to kvmppc_read_int_cpu_dt() target/ppc: use g_autofree in kvmppc_read_int_cpu_dt() target/ppc: exit(1) on failure in kvmppc_get_clockfreq()

jianchunfu (1):
target/ppc: Add error reporting when opening file fails

 target/ppc/kvm.c | 46 +++++++++++++++++++++++++++++++---------------
 1 file changed, 31 insertions(+), 15 deletions(-)
Signature · 1 line
2.36.1