Skip to content

PolarFire SoC macb reset support

Conor Dooley linux-devicetree linux-riscv lkml netdev 3 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 0 repliesApplied 5/5
  2. v25 patches 2 repliesSuperseded
  3. v12 patches 7 repliesSuperseded

Changes in v3 from the cover letter

- Fix a commit message typo

Patches in v3 All 5 applied

#Subject and filesSizeRepliesApplied
1/5dt-bindings: net: cdns,macb: document polarfire soc's macbDocumentation/devicetree/bindings/net/cdns,macb.yaml+1 -00 repliesApplied
2/5net: macb: add polarfire soc reset supportdrivers/net/ethernet/cadence/macb_main.c+18 -80 repliesApplied
3/5net: macb: unify macb_config alignment styledrivers/net/ethernet/cadence/macb_main.c+8 -80 repliesApplied
4/5net: macb: simplify error paths in init_reset_optional()drivers/net/ethernet/cadence/macb_main.c+7 -130 repliesApplied
5/5net: macb: sort init_reset_optional() with other init()sdrivers/net/ethernet/cadence/macb_main.c+34 -340 repliesApplied

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchRob HerringClaudiu Beznea
1/5A-b R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [net-next PATCH v3 0/5] PolarFire SoC macb reset support

Hey all,
Jakub requested that these patches be split off from the series adding the reset controller itself that I sent ~yesterday~ last week [0].

The Cadence MACBs on PolarFire SoC (MPFS) have reset capability and are compatible with the zynqmp's init function. I have removed the zynqmp specific comments from that function & renamed it to reflect what it does, since it is no longer zynqmp only.

MPFS's MACB had previously used the generic binding, so I also added the required specific binding.

For v2, I noticed some low hanging cleanup fruit so there are extra patches added for that:
moving the init function out of the config structs, aligning the alignment of the zynqmp & default config structs with the other dozen or so structs & simplifing the error paths to use dev_err_probe().

Feel free to apply as many or as few of those as you like.

Thanks,
Conor.

Changes since v2:
- Fix a commit message typo

Changes since v1:
- added the 3 aforementioned cleanup patches
- fixed two stylistic complaints from Claudiu

Conor Dooley (5):
dt-bindings: net: cdns,macb: document polarfire soc's macb
net: macb: add polarfire soc reset support
net: macb: unify macb_config alignment style
net: macb: simplify error paths in init_reset_optional()
net: macb: sort init_reset_optional() with other init()s

 .../devicetree/bindings/net/cdns,macb.yaml    |   1 +
 drivers/net/ethernet/cadence/macb_main.c      | 106 +++++++++---------
 2 files changed, 56 insertions(+), 51 deletions(-)
Signature · 1 line
2.36.1