Skip to content

arm: dts: rockchip: rk3399: usb: ehci: Fix EHCI probe in rk3399 to access peripherals by USB 2

Xavier Drudis Ferran u-boot 6 versions – Applied

Status from this message: Applied both to usb/master .

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest2 patches 10 repliesApplied
  2. v62 patches 6 repliesSuperseded
  3. v51 of 2 patches 9 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v31 patch3 repliesSuperseded
v21 patch2 repliesSuperseded
v11 patch3 repliesSuperseded

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/2phy: rockchip-inno-usb2: Add usb2phy clock provider of 480MHz clockdrivers/phy/rockchip/phy-rockchip-inno-usb2.c+30 -32 replies
2/2phy: rockchip-inno-usb2: Implement clock operations for usb2phy clockdrivers/phy/rockchip/phy-rockchip-inno-usb2.c+78 -26 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchKever YangJagan Teki
1/2R-b R-b T-b
2/2R-b R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 0/2] arm: dts: rockchip: rk3399: usb: ehci: Fix EHCI probe in rk3399 to access peripherals by USB 2

EHCI probing in Rock pi 4 currently fails.

Add a clock driver for usb2phy so that probing EHCI does not fail when missing one of the clocks in the bundle for usb_host0_ehci, since usb2phy is UCLASS_PHY but not UCLASS_CLK.

Xavier Drudis Ferran (2):
phy: rockchip-inno-usb2: Add usb2phy clock provider of 480MHz clock
phy: rockchip-inno-usb2: Implement clock operations for usb2phy clock

 drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 109 +++++++++++++++++-
 1 file changed, 106 insertions(+), 3 deletions(-)
Cc Simon Glass <[email protected]>
Cc Philipp Tomsich <[email protected]>
Cc Kever Yang <[email protected]>
Cc Lukasz Majewski <[email protected]>
Cc Sean Anderson <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Christoph Fritz <[email protected]>
Cc Jagan Teki <[email protected]>

---

Changes:

v7: Error handling. Remove unnecessary if.
Adding config data for rk3568 (untested).

v6: just retested over current next branch and some corrections
to message and headers
(no changes to code).

v5: fixes a bug that Christoph Fritz discovered, consisting in the
wrong eror code returned when enabling or disabling the clock because property_enable() returns an error code in linux but the modified register value in U-Boot. This caused the clk disable to abort before freeing the clock.

v4: move v3 to one patch in the series and add a second patch
to add operations to enable disable the usb2phy 480Mhz clock. Also, honour clock-output-names for what is worth.

v3: implement option 5 (bind usb2phy as a clk driver too) instead
of option 1 (ehci-generic.c tolerates missing clocks).

v2: implement option 1 (ehci-generic.c tolerates missing clocks)
instead of option 3 (change dts node to remove the missing clock).

Signature · 1 line
2.20.1