Skip to content

Deduplicate dhelectronics board files

Philip Oberfichtner u-boot 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 4 repliesIn review
  2. v34 patches 1 replySuperseded
  3. v24 patches 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches4 repliesSuperseded

Changes in v4 from the cover letter

- Replace printf() by log_err() in stm32 board file
- stm32 changes reviewed by Patrick

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4board: dhelectronics: Implement common MAC address functionsboard/dhelectronics/common/Makefile board/dhelectronics/common/dh_common.c board/dhelectronics/common/dh_common.h +2 more+139 -01 reply
2/4ARM: imx6: DH: Use common MAC address functionsboard/dhelectronics/dh_imx6/dh_imx6.c+14 -331 reply
3/4ARM: imx8: DH: Use common MAC address functionsboard/dhelectronics/dh_imx8mp/imx8mp_dhcom_pdk2.c+48 -731 reply
4/4ARM: stm32: DH: Use common MAC address functionsboard/dhelectronics/dh_stm32mp1/board.c+45 -571 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchMarek VasutPatrick Delaunay
1/4R-b
2/4T-b R-b
3/4T-b R-b
4/4T-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/4] Deduplicate dhelectronics board files

This series unifies common MAC address code for imx6, imx8 and stm32 based boards by DH. It is thought of as a starting point for more deduplication in the future.

Changes in v4:
- Replace printf() by log_err() in stm32 board file
- stm32 changes reviewed by Patrick

Changes in v3:
- Entire series reviewed by Marek

Changes in v2:
- Tested-by Marek
- convert to livetree (rebase on commit 5a605b7c86152)
- Fix spelling

Philip Oberfichtner (4):
board: dhelectronics: Implement common MAC address functions
ARM: imx6: DH: Use common MAC address functions
ARM: imx8: DH: Use common MAC address functions
ARM: stm32: DH: Use common MAC address functions

 board/dhelectronics/common/Makefile           |  10 ++
 board/dhelectronics/common/dh_common.c        |  65 ++++++++++
 board/dhelectronics/common/dh_common.h        |  28 ++++
 board/dhelectronics/common/dh_imx.c           |  24 ++++
 board/dhelectronics/common/dh_imx.h           |  12 ++
 board/dhelectronics/dh_imx6/dh_imx6.c         |  47 ++-----
 .../dh_imx8mp/imx8mp_dhcom_pdk2.c             | 121 +++++++-----------
 board/dhelectronics/dh_stm32mp1/board.c       | 102 +++++++--------
 8 files changed, 246 insertions(+), 163 deletions(-)
 create mode 100644 board/dhelectronics/common/Makefile
 create mode 100644 board/dhelectronics/common/dh_common.c
 create mode 100644 board/dhelectronics/common/dh_common.h
 create mode 100644 board/dhelectronics/common/dh_imx.c
 create mode 100644 board/dhelectronics/common/dh_imx.h
Signature · 1 line
2.37.1