Skip to content

phy: qcom,qmp: fix dt-bindings and deprecate lane suffix

Johan Hovold linux-arm-msm linux-devicetree linux-phy lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest30 patches 1 replyIn review
  2. v330 patches 19 repliesSuperseded
  3. v230 patches 36 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v143 patches45 repliesSuperseded

Changes in v4 from the cover letter

- rebase on phy/next from 2022-08-30 (71351b0e5646 ("phy: move from strlcpy with unused retval to strscpy")) which included a new sc8280xp USB PHY binding
- add more tags from Krzysztof and Dmitry

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/30dt-bindings: phy: qcom,qmp: fix bogus clock-cells propertyDocumentation/devicetree/bindings/phy/qcom,qmp-phy.yaml+0 -50 replies
2/30dt-bindings: phy: qcom,qmp: sort compatible stringsDocumentation/devicetree/bindings/phy/qcom,qmp-phy.yaml+7 -70 replies
3/30dt-bindings: phy: qcom,qmp: drop redundant descriptionsDocumentation/devicetree/bindings/phy/qcom,qmp-phy.yaml+25 -830 replies
4/30dt-bindings: phy: qcom,qmp: fix child node descriptionDocumentation/devicetree/bindings/phy/qcom,qmp-phy.yaml+1 -30 replies
5/30dt-bindings: phy: qcom,qmp: clean up descriptionsDocumentation/devicetree/bindings/phy/qcom,qmp-phy.yaml+3 -30 replies
6/30dt-bindings: phy: qcom,qmp: clean up exampleDocumentation/devicetree/bindings/phy/qcom,qmp-phy.yaml+5 -20 replies
7/30dt-bindings: phy: qcom,qmp: drop child-node commentDocumentation/devicetree/bindings/phy/qcom,qmp-phy.yaml+0 -10 replies
8/30dt-bindings: phy: add qcom,msm8996-qmp-pcie-phy schemaDocumentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml+146 -260 replies
9/30dt-bindings: phy: qcom,msm8996-qmp-pcie: add missing child node schemaDocumentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml+49 -00 replies
10/30dt-bindings: phy: qcom,msm8996-qmp-pcie: deprecate PIPE clock namesDocumentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml+1 -40 replies
11/30dt-bindings: phy: qcom,msm8996-qmp-pcie: deprecate reset namesDocumentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml+2 -50 replies
12/30dt-bindings: phy: add QMP PCIe PHY schemaDocumentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml+205 -680 replies
13/30dt-bindings: phy: qcom,qmp-pcie: add missing child node schemaDocumentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml+92 -00 replies
14/30dt-bindings: phy: qcom,qmp-pcie: deprecate PIPE clock nameDocumentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml+1 -20 replies
15/30dt-bindings: phy: add QMP UFS PHY schemaDocumentation/devicetree/bindings/phy/qcom,qmp-phy.yaml Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml+148 -600 replies
16/30dt-bindings: phy: qcom,qmp-ufs: add missing SM8450 clockDocumentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml+18 -20 replies
17/30dt-bindings: phy: qcom,qmp-ufs: add missing SM8150 power domainDocumentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml+3 -00 replies
18/30dt-bindings: phy: qcom,qmp-ufs: add missing child node schemaDocumentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml+72 -00 replies
19/30dt-bindings: phy: add QMP USB PHY schemaDocumentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml+16 -510 replies
20/30dt-bindings: phy: qcom,qmp-usb: add missing child node schemaDocumentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml+115 -00 replies
21/30dt-bindings: phy: qcom,qmp-usb: deprecate PIPE clock nameDocumentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml+1 -20 replies
22/30dt-bindings: phy: qcom,qmp-usb: add missing qcom,sc7180-qmp-usb3-phy schemaDocumentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml+22 -00 replies
23/30dt-bindings: phy: qcom,qmp-usb3-dp: fix bogus clock-cells propertyDocumentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml+0 -50 replies
24/30dt-bindings: phy: qcom,qmp-usb3-dp: deprecate USB PIPE clock nameDocumentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml+1 -20 replies
25/30phy: qcom-qmp-pcie: drop pipe clock lane suffixdrivers/phy/qualcomm/phy-qcom-qmp-pcie.c+1 -30 replies
26/30phy: qcom-qmp-combo: drop unused lane resetdrivers/phy/qualcomm/phy-qcom-qmp-combo.c+0 -20 replies
27/30phy: qcom-qmp-combo: drop pipe clock lane suffixdrivers/phy/qualcomm/phy-qcom-qmp-combo.c+1 -30 replies
28/30phy: qcom-qmp-pcie-msm8996: drop pipe clock lane suffixdrivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c+1 -20 replies
29/30phy: qcom-qmp-pcie-msm8996: drop reset lane suffixdrivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c+1 -40 replies
30/30phy: qcom-qmp-usb: drop pipe clock lane suffixdrivers/phy/qualcomm/phy-qcom-qmp-usb.c+1 -30 replies

Reviews trailers per patch

All 30 patches have a Reviewed-by or Acked-by.

PatchKrzysztof KozlowskiDmitry Baryshkov
1/30R-b
2/30A-b
3/30R-b
4/30A-b
5/30A-b
6/30A-b
7/30A-b
8/30R-b
9/30R-b
10/30R-b
11/30R-b
12/30R-b
13/30R-b
14/30R-b
15/30R-b
16/30R-b
17/30R-b
18/30R-b
19/30R-b
20/30R-b
21/30R-b
22/30R-b
23/30R-b
24/30R-b
25/30R-b R-b
26/30R-b R-b
27/30R-b R-b
28/30R-b R-b
29/30R-b R-b
30/30R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/30] phy: qcom,qmp: fix dt-bindings and deprecate lane suffix

When adding support for SC8280XP to the QMP PHY driver I noticed that the PHY provider child node was not described by the current DT schema.

The SC8280XP PHYs also need a second fixed-divider PIPE clock ("pipediv2") and I didn't want to have to add a bogus "lane" suffix to the clock name just to match the current "pipe0" name so I decided to deprecate the unnecessary suffix in the current binding instead.

To be able to add the missing child-node schema and handle device specifics like additional PIPE clocks, it quickly became obvious that the binding needs to be split up.

This series clean up and fixes some issue with the current schema before splitting it up in separate schemas for PCIe, UFS and USB and adding missing parts like the child PHY provider nodes.

The MSM8996 PCIe PHY gets its own schema as this is the only non-combo PHY that actually provides more than one PHY per IP block. Note that the "lane" suffix is still unnecessary and misleading.

The final patches add support for the updated binding to the (recently split up) PHY drivers. Included is also a related combo PHY cleanup.

Johan

Changes in v4
- rebase on phy/next from 2022-08-30 (71351b0e5646 ("phy: move from strlcpy with unused retval to strscpy")) which included a new sc8280xp USB PHY binding
- add more tags from Krzysztof and Dmitry

Changes in v3
- rebase on linux-next which has a new binding for IPQ8074
- fix git-bisect breakage due to removal of an unused variable one patch too soon (Krzysztof)
- replace one Fixes tag with reference in commit message (Krzysztof)
- drop two redundant minItems (Krzysztof)
- fix two Fixes tags that lacked the actual tag
- add more ack and review tags from Krzysztof

Changes in v2
- squash split + cleanup + example patches (Krzysztof)
- deprecate clock-names instead of dropping suffix (Krzysztof)
- deprecate reset-names instead of dropping suffix (Krzysztof)
- flatten child reg if/then schemas (Krzysztof)
- add back optional vddp-ref-clk to all bindings even though it likely only applies to MSM8996/98 UFS (Krzysztof)
- add missing sc7180 schema to USB binding
- misc clean ups
- shorten or drop descriptions
- drop quotes around $id and $schema (Krzysztof)
- use maxItems with clock-output-names
- combine two USB clock+reset schemas
- add Reviewed-by/Acked-by tags

Johan Hovold (30):
dt-bindings: phy: qcom,qmp: fix bogus clock-cells property
dt-bindings: phy: qcom,qmp: sort compatible strings
dt-bindings: phy: qcom,qmp: drop redundant descriptions
dt-bindings: phy: qcom,qmp: fix child node description
dt-bindings: phy: qcom,qmp: clean up descriptions
dt-bindings: phy: qcom,qmp: clean up example
dt-bindings: phy: qcom,qmp: drop child-node comment
dt-bindings: phy: add qcom,msm8996-qmp-pcie-phy schema
dt-bindings: phy: qcom,msm8996-qmp-pcie: add missing child node schema
dt-bindings: phy: qcom,msm8996-qmp-pcie: deprecate PIPE clock names
dt-bindings: phy: qcom,msm8996-qmp-pcie: deprecate reset names
dt-bindings: phy: add QMP PCIe PHY schema
dt-bindings: phy: qcom,qmp-pcie: add missing child node schema
dt-bindings: phy: qcom,qmp-pcie: deprecate PIPE clock name
dt-bindings: phy: add QMP UFS PHY schema
dt-bindings: phy: qcom,qmp-ufs: add missing SM8450 clock
dt-bindings: phy: qcom,qmp-ufs: add missing SM8150 power domain
dt-bindings: phy: qcom,qmp-ufs: add missing child node schema
dt-bindings: phy: add QMP USB PHY schema
dt-bindings: phy: qcom,qmp-usb: add missing child node schema
dt-bindings: phy: qcom,qmp-usb: deprecate PIPE clock name
dt-bindings: phy: qcom,qmp-usb: add missing qcom,sc7180-qmp-usb3-phy
schema
dt-bindings: phy: qcom,qmp-usb3-dp: fix bogus clock-cells property
dt-bindings: phy: qcom,qmp-usb3-dp: deprecate USB PIPE clock name
phy: qcom-qmp-pcie: drop pipe clock lane suffix
phy: qcom-qmp-combo: drop unused lane reset
phy: qcom-qmp-combo: drop pipe clock lane suffix
phy: qcom-qmp-pcie-msm8996: drop pipe clock lane suffix
phy: qcom-qmp-pcie-msm8996: drop reset lane suffix
phy: qcom-qmp-usb: drop pipe clock lane suffix

 .../phy/qcom,msm8996-qmp-pcie-phy.yaml        | 189 +++++++
 .../bindings/phy/qcom,qmp-pcie-phy.yaml       | 296 ++++++++++
 .../devicetree/bindings/phy/qcom,qmp-phy.yaml | 504 ------------------
 .../bindings/phy/qcom,qmp-ufs-phy.yaml        | 239 +++++++++
 .../bindings/phy/qcom,qmp-usb-phy.yaml        | 388 ++++++++++++++
 .../bindings/phy/qcom,qmp-usb3-dp-phy.yaml    |   8 +-
 drivers/phy/qualcomm/phy-qcom-qmp-combo.c     |   6 +-
 .../phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c  |   8 +-
 drivers/phy/qualcomm/phy-qcom-qmp-pcie.c      |   4 +-
 drivers/phy/qualcomm/phy-qcom-qmp-usb.c       |   4 +-
 10 files changed, 1118 insertions(+), 528 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml
 create mode 100644 Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml
 delete mode 100644 Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
 create mode 100644 Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml
 create mode 100644 Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml
Signature · 1 line
2.35.1