phy: qcom,qmp: fix dt-bindings and deprecate lane suffix
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest30 patches 1 replyIn review
- v330 patches 19 repliesSuperseded
- v230 patches 36 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 43 patches | 45 replies | Superseded |
Changes in v4 from the cover letter
- rebase on phy/next from 2022-08-30 (71351b0e5646 ("phy: move from strlcpy with unused retval to strscpy")) which included a new sc8280xp USB PHY binding
- add more tags from Krzysztof and Dmitry
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/30 | dt-bindings: phy: qcom,qmp: fix bogus clock-cells propertyDocumentation/ | +0 | 0 replies | |
| 2/30 | dt-bindings: phy: qcom,qmp: sort compatible stringsDocumentation/ | +7 | 0 replies | |
| 3/30 | dt-bindings: phy: qcom,qmp: drop redundant descriptionsDocumentation/ | +25 | 0 replies | |
| 4/30 | dt-bindings: phy: qcom,qmp: fix child node descriptionDocumentation/ | +1 | 0 replies | |
| 5/30 | dt-bindings: phy: qcom,qmp: clean up descriptionsDocumentation/ | +3 | 0 replies | |
| 6/30 | dt-bindings: phy: qcom,qmp: clean up exampleDocumentation/ | +5 | 0 replies | |
| 7/30 | dt-bindings: phy: qcom,qmp: drop child-node commentDocumentation/ | +0 | 0 replies | |
| 8/30 | dt-bindings: phy: add qcom,msm8996-qmp-pcie-phy schemaDocumentation/ Documentation/ | +146 | 0 replies | |
| 9/30 | dt-bindings: phy: qcom,msm8996-qmp-pcie: add missing child node schemaDocumentation/ | +49 | 0 replies | |
| 10/30 | dt-bindings: phy: qcom,msm8996-qmp-pcie: deprecate PIPE clock namesDocumentation/ | +1 | 0 replies | |
| 11/30 | dt-bindings: phy: qcom,msm8996-qmp-pcie: deprecate reset namesDocumentation/ | +2 | 0 replies | |
| 12/30 | dt-bindings: phy: add QMP PCIe PHY schemaDocumentation/ Documentation/ | +205 | 0 replies | |
| 13/30 | dt-bindings: phy: qcom,qmp-pcie: add missing child node schemaDocumentation/ | +92 | 0 replies | |
| 14/30 | dt-bindings: phy: qcom,qmp-pcie: deprecate PIPE clock nameDocumentation/ | +1 | 0 replies | |
| 15/30 | dt-bindings: phy: add QMP UFS PHY schemaDocumentation/ Documentation/ | +148 | 0 replies | |
| 16/30 | dt-bindings: phy: qcom,qmp-ufs: add missing SM8450 clockDocumentation/ | +18 | 0 replies | |
| 17/30 | dt-bindings: phy: qcom,qmp-ufs: add missing SM8150 power domainDocumentation/ | +3 | 0 replies | |
| 18/30 | dt-bindings: phy: qcom,qmp-ufs: add missing child node schemaDocumentation/ | +72 | 0 replies | |
| 19/30 | dt-bindings: phy: add QMP USB PHY schemaDocumentation/ | +16 | 0 replies | |
| 20/30 | dt-bindings: phy: qcom,qmp-usb: add missing child node schemaDocumentation/ | +115 | 0 replies | |
| 21/30 | dt-bindings: phy: qcom,qmp-usb: deprecate PIPE clock nameDocumentation/ | +1 | 0 replies | |
| 22/30 | dt-bindings: phy: qcom,qmp-usb: add missing qcom,sc7180-qmp-usb3-phy schemaDocumentation/ | +22 | 0 replies | |
| 23/30 | dt-bindings: phy: qcom,qmp-usb3-dp: fix bogus clock-cells propertyDocumentation/ | +0 | 0 replies | |
| 24/30 | dt-bindings: phy: qcom,qmp-usb3-dp: deprecate USB PIPE clock nameDocumentation/ | +1 | 0 replies | |
| 25/30 | phy: qcom-qmp-pcie: drop pipe clock lane suffixdrivers/ | +1 | 0 replies | |
| 26/30 | phy: qcom-qmp-combo: drop unused lane resetdrivers/ | +0 | 0 replies | |
| 27/30 | phy: qcom-qmp-combo: drop pipe clock lane suffixdrivers/ | +1 | 0 replies | |
| 28/30 | phy: qcom-qmp-pcie-msm8996: drop pipe clock lane suffixdrivers/ | +1 | 0 replies | |
| 29/30 | phy: qcom-qmp-pcie-msm8996: drop reset lane suffixdrivers/ | +1 | 0 replies | |
| 30/30 | phy: qcom-qmp-usb: drop pipe clock lane suffixdrivers/ | +1 | 0 replies |
Reviews trailers per patch
All 30 patches have a Reviewed-by or Acked-by.
| Patch | Krzysztof Kozlowski | Dmitry Baryshkov |
|---|---|---|
| 1/30 | R-b | |
| 2/30 | A-b | |
| 3/30 | R-b | |
| 4/30 | A-b | |
| 5/30 | A-b | |
| 6/30 | A-b | |
| 7/30 | A-b | |
| 8/30 | R-b | |
| 9/30 | R-b | |
| 10/30 | R-b | |
| 11/30 | R-b | |
| 12/30 | R-b | |
| 13/30 | R-b | |
| 14/30 | R-b | |
| 15/30 | R-b | |
| 16/30 | R-b | |
| 17/30 | R-b | |
| 18/30 | R-b | |
| 19/30 | R-b | |
| 20/30 | R-b | |
| 21/30 | R-b | |
| 22/30 | R-b | |
| 23/30 | R-b | |
| 24/30 | R-b | |
| 25/30 | R-b | R-b |
| 26/30 | R-b | R-b |
| 27/30 | R-b | R-b |
| 28/30 | R-b | R-b |
| 29/30 | R-b | R-b |
| 30/30 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 00/30] phy: qcom,qmp: fix dt-bindings and deprecate lane suffix
When adding support for SC8280XP to the QMP PHY driver I noticed that the PHY provider child node was not described by the current DT schema.
The SC8280XP PHYs also need a second fixed-divider PIPE clock ("pipediv2") and I didn't want to have to add a bogus "lane" suffix to the clock name just to match the current "pipe0" name so I decided to deprecate the unnecessary suffix in the current binding instead.
To be able to add the missing child-node schema and handle device specifics like additional PIPE clocks, it quickly became obvious that the binding needs to be split up.
This series clean up and fixes some issue with the current schema before splitting it up in separate schemas for PCIe, UFS and USB and adding missing parts like the child PHY provider nodes.
The MSM8996 PCIe PHY gets its own schema as this is the only non-combo PHY that actually provides more than one PHY per IP block. Note that the "lane" suffix is still unnecessary and misleading.
The final patches add support for the updated binding to the (recently split up) PHY drivers. Included is also a related combo PHY cleanup.
Johan
Changes in v4
- rebase on phy/next from 2022-08-30 (71351b0e5646 ("phy: move from strlcpy with unused retval to strscpy")) which included a new sc8280xp USB PHY binding
- add more tags from Krzysztof and Dmitry
Changes in v3
- rebase on linux-next which has a new binding for IPQ8074
- fix git-bisect breakage due to removal of an unused variable one patch too soon (Krzysztof)
- replace one Fixes tag with reference in commit message (Krzysztof)
- drop two redundant minItems (Krzysztof)
- fix two Fixes tags that lacked the actual tag
- add more ack and review tags from Krzysztof
Changes in v2
- squash split + cleanup + example patches (Krzysztof)
- deprecate clock-names instead of dropping suffix (Krzysztof)
- deprecate reset-names instead of dropping suffix (Krzysztof)
- flatten child reg if/then schemas (Krzysztof)
- add back optional vddp-ref-clk to all bindings even though it likely only applies to MSM8996/98 UFS (Krzysztof)
- add missing sc7180 schema to USB binding
- misc clean ups
- shorten or drop descriptions
- drop quotes around $id and $schema (Krzysztof)
- use maxItems with clock-output-names
- combine two USB clock+reset schemas
- add Reviewed-by/Acked-by tags
Johan Hovold (30):
dt-bindings: phy: qcom,qmp: fix bogus clock-cells property
dt-bindings: phy: qcom,qmp: sort compatible strings
dt-bindings: phy: qcom,qmp: drop redundant descriptions
dt-bindings: phy: qcom,qmp: fix child node description
dt-bindings: phy: qcom,qmp: clean up descriptions
dt-bindings: phy: qcom,qmp: clean up example
dt-bindings: phy: qcom,qmp: drop child-node comment
dt-bindings: phy: add qcom,msm8996-qmp-pcie-phy schema
dt-bindings: phy: qcom,msm8996-qmp-pcie: add missing child node schema
dt-bindings: phy: qcom,msm8996-qmp-pcie: deprecate PIPE clock names
dt-bindings: phy: qcom,msm8996-qmp-pcie: deprecate reset names
dt-bindings: phy: add QMP PCIe PHY schema
dt-bindings: phy: qcom,qmp-pcie: add missing child node schema
dt-bindings: phy: qcom,qmp-pcie: deprecate PIPE clock name
dt-bindings: phy: add QMP UFS PHY schema
dt-bindings: phy: qcom,qmp-ufs: add missing SM8450 clock
dt-bindings: phy: qcom,qmp-ufs: add missing SM8150 power domain
dt-bindings: phy: qcom,qmp-ufs: add missing child node schema
dt-bindings: phy: add QMP USB PHY schema
dt-bindings: phy: qcom,qmp-usb: add missing child node schema
dt-bindings: phy: qcom,qmp-usb: deprecate PIPE clock name
dt-bindings: phy: qcom,qmp-usb: add missing qcom,sc7180-qmp-usb3-phy
schema
dt-bindings: phy: qcom,qmp-usb3-dp: fix bogus clock-cells property
dt-bindings: phy: qcom,qmp-usb3-dp: deprecate USB PIPE clock name
phy: qcom-qmp-pcie: drop pipe clock lane suffix
phy: qcom-qmp-combo: drop unused lane reset
phy: qcom-qmp-combo: drop pipe clock lane suffix
phy: qcom-qmp-pcie-msm8996: drop pipe clock lane suffix
phy: qcom-qmp-pcie-msm8996: drop reset lane suffix
phy: qcom-qmp-usb: drop pipe clock lane suffix
.../phy/qcom,msm8996-qmp-pcie-phy.yaml | 189 +++++++ .../bindings/phy/qcom,qmp-pcie-phy.yaml | 296 ++++++++++ .../devicetree/bindings/phy/qcom,qmp-phy.yaml | 504 ------------------ .../bindings/phy/qcom,qmp-ufs-phy.yaml | 239 +++++++++ .../bindings/phy/qcom,qmp-usb-phy.yaml | 388 ++++++++++++++ .../bindings/phy/qcom,qmp-usb3-dp-phy.yaml | 8 +- drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 6 +- .../phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c | 8 +- drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 4 +- drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 4 +- 10 files changed, 1118 insertions(+), 528 deletions(-) create mode 100644 Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml create mode 100644 Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml delete mode 100644 Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml create mode 100644 Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml create mode 100644 Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml
Signature · 1 line
2.35.1