Skip to content

sed-opal: keyrings, discovery, revert and key store

[email protected] keyrings linux-block llvm oe-lkp 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4block: sed-opal: Implement IOC_OPAL_DISCOVERYblock/sed-opal.c include/linux/sed-opal.h include/uapi/linux/sed-opal.h+43 -31 reply
2/4block: sed-opal: Implement IOC_OPAL_REVERT_LSPblock/opal_proto.h block/sed-opal.c include/linux/sed-opal.h +1 more+55 -10 replies
3/4block: sed-opal: keyring support for SED Opal keys.block/sed-opal.c include/linux/sed-opal.h include/uapi/linux/sed-opal.h+205 -40 replies
4/4arch_vars: create arch specific permanent storeinclude/linux/arch_vars.h lib/Makefile lib/arch_vars.c+49 -13 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] sed-opal: keyrings, discovery, revert and key store

From: Greg Joyce <[email protected]>

The current TCG SED Opal implementation in the block driver requires that authentication keys be provided in an ioctl so that they can be presented to the underlying SED Opal capable drive. Currently, the key is typically entered by a user with an application like sedutil or sedcli. While this process works, it does not lend itself to automation like unlock by a udev rule.

Extend the SED block driver so it can alternatively obtain a key from a sed-opal kernel keyring. The SED ioctls will indicate the source of the key, either directly in the ioctl data or from the keyring.

Two new SED ioctls have also been added. These are:
1) IOC_OPAL_REVERT_LSP to revert LSP state
2) IOC_OPAL_DISCOVERY to discover drive capabilities/state

Also, for platforms that have a permanent key store, the platform may provide unique platform dependent functions to read/write variables. The SED block driver has been modified to attempt to read a key from the platform key store. If successful, the key value is saved in the kernel sed-opal keyring. If the platform does not support a permanent key store, the read will fail and a key will not be added to the keyring.

Greg Joyce (4):
block: sed-opal: Implement IOC_OPAL_DISCOVERY
block: sed-opal: Implement IOC_OPAL_REVERT_LSP
block: sed-opal: keyring support for SED Opal keys.
arch_vars: create arch specific permanent store

 block/opal_proto.h            |   4 +
 block/sed-opal.c              | 274 +++++++++++++++++++++++++++++++++-
 include/linux/arch_vars.h     |  23 +++
 include/linux/sed-opal.h      |   5 +
 include/uapi/linux/sed-opal.h |  24 ++-
 lib/Makefile                  |   2 +-
 lib/arch_vars.c               |  25 ++++
 7 files changed, 350 insertions(+), 7 deletions(-)
 create mode 100644 include/linux/arch_vars.h
 create mode 100644 lib/arch_vars.c
Signature · 1 line
[email protected]