Skip to content

ALSA: hda: Codec-reload bug fixes and cleanups

Cezary Rojewski alsa-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 17 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9ALSA: hda: Do not unset preset when cleaning up codecsound/pci/hda/hda_codec.c+0 -19 replies
2/9ALSA: hda: Fix null-ptr-deref when i915 fails and hdmi is denylistedsound/pci/hda/hda_bind.c+7 -00 replies
3/9ALSA: hda: Make device usage_count consistent across subsequent probingsound/pci/hda/hda_codec.c+7 -10 replies
4/9ALSA: hda: Fix put_device() inconsistency in error pathsound/pci/hda/hda_codec.c+11 -120 replies
5/9ALSA: hda: Skip event processing for unregistered codecsinclude/sound/hda_codec.h include/sound/hdaudio.h sound/hda/hdac_bus.c +2 more+9 -92 replies
6/9ALSA: hda: Fix page fault in snd_hda_codec_shutdown()sound/pci/hda/hda_codec.c+20 -213 replies
7/9ALSA: hda: Reset all SIE bits in INTCTLsound/hda/hdac_controller.c+2 -50 replies
8/9ALSA: hda: Remove unused macro definitionsound/hda/ext/hdac_ext_controller.c+0 -70 replies
9/9ALSA: hda/realtek: Remove redundant init_hook() in alc_default_init()sound/pci/hda/patch_realtek.c+0 -32 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/9] ALSA: hda: Codec-reload bug fixes and cleanups

Total of 6 fixes and 3 cleanups - cleanups are last.

All of the fixes address problems that present themselves in situation when user engages in codec driver reload. Second condition to reproduce is two-step initialization of HDAudio codec - this is the case only for ASoC HDAudio bus driver as snd_hda_intel calls only compound function snd_hda_codec_new(). Once these conditions are met, several reload/unload scenarios end with null-ptr-deref and page faults. Goal of the series is to allow codec/bus driver reloading without any errors.

Amadeusz Sławiński (2):
ALSA: hda: Reset all SIE bits in INTCTL
ALSA: hda: Remove unused macro definition

Cezary Rojewski (7):
ALSA: hda: Do not unset preset when cleaning up codec
ALSA: hda: Fix null-ptr-deref when i915 fails and hdmi is denylisted
ALSA: hda: Make device usage_count consistent across subsequent
probing
ALSA: hda: Fix put_device() inconsistency in error path
ALSA: hda: Skip event processing for unregistered codecs
ALSA: hda: Fix page fault in snd_hda_codec_shutdown()
ALSA: hda/realtek: Remove redundant init_hook() in alc_default_init()

 include/sound/hda_codec.h           |  1 -
 include/sound/hdaudio.h             |  1 +
 sound/hda/ext/hdac_ext_controller.c |  7 ---
 sound/hda/hdac_bus.c                |  2 +-
 sound/hda/hdac_controller.c         |  7 +--
 sound/pci/hda/hda_bind.c            |  7 +++
 sound/pci/hda/hda_codec.c           | 83 +++++++++++++++--------------
 sound/pci/hda/patch_realtek.c       |  3 --
 sound/soc/codecs/hda.c              |  4 +-
 9 files changed, 56 insertions(+), 59 deletions(-)
Signature · 1 line
2.25.1