iavf: Fix close path on shutdown and remove in iavf driver.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest2 patches 6 repliesIn review
- v12 patches 1 replySuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | iavf: Fix shutdown pci callback to match the remove onedrivers/ | +12 | 1 reply | |
| 2/2 | iavf: Fix race condition between iavf_shutdown and iavf_removedrivers/ | +10 | 5 replies |
Reviews trailers per patch
None of the 2 patches has a Reviewed-by or Acked-by.
| Patch | Marek Szlosek |
|---|---|
| 1/2 | T-b |
| 2/2 | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Intel-wired-lan] [PATCH net v2 0/2] iavf: Fix close path on shutdown and remove in iavf driver.
From: Slawomir Laba <[email protected]>
iavf_shutdown was implementing an incomplete version of iavf_remove. It misses several calls to the kernel like iavf_free_misc_irq, iavf_reset_interrupt_capability, iounmap that might break the system on reboot or hibernation.
Fix a deadlock introduced by commit974578017fc1f ("iavf: Add waiting so the port is initialized in remove") due to race condition between iavf_shutdown and iavf_remove, where iavf_remove stucks forever in while loop since iavf_shutdown already set __IAVF_REMOVE adapter state.
---
v2: Fixed author
---
SlawomirX Laba (2):
iavf: Fix shutdown pci callback to match the remove one
iavf: Fix race condition between iavf_shutdown and iavf_remove
drivers/net/ethernet/intel/iavf/iavf_main.c | 59 ++++++++------------- 1 file changed, 22 insertions(+), 37 deletions(-)
Signature · 6 lines
2.27.0 _______________________________________________ Intel-wired-lan mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/intel-wired-lan