Skip to content

ftdi_sio driver improvements

Marek Behún linux-usb stable 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 29 repliesIn review
  2. v17 patches 22 repliesSuperseded

Changes in v2 from the cover letter

- addressed issues pointed out by Greg: better commit messages, fixed checkpatch warning, dropped usage of (u32)-1

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7USB: serial: ftdi_sio: Fix divisor overflowdrivers/usb/serial/ftdi_sio.c+6 -01 reply
2/7USB: serial: ftdi_sio: Add missing baud rate validationdrivers/usb/serial/ftdi_sio.c+3 -32 replies
3/7USB: serial: ftdi_sio: Extract SIO divisor code to functiondrivers/usb/serial/ftdi_sio.c+21 -155 replies
4/7USB: serial: ftdi_sio: Do not reset baud rate to 9600 Baud on errordrivers/usb/serial/ftdi_sio.c+26 -123 replies
5/7USB: serial: ftdi_sio: Fix baud rate rounding for ASYNC_SPD_CUSTdrivers/usb/serial/ftdi_sio.c+1 -11 reply
6/7USB: serial: ftdi_sio: Fix custom_divisor and c_*speed for ASYNC_SPD_CUSTdrivers/usb/serial/ftdi_sio.c+16 -012 replies
7/7USB: serial: ftdi_sio: Fill c_*speed fields with real baud ratedrivers/usb/serial/ftdi_sio.c+83 -05 replies

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by.

PatchMarek Behún
1/7T-b
2/7T-b
3/7T-b
4/7T-b
5/7T-b
6/7T-b
7/7T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/7] ftdi_sio driver improvements

Hi guys,

Pali has worked out some improvements for the ftdi_sio USB serial driver and I have reviewed and tested them.

Changes since v1:
- addressed issues pointed out by Greg: better commit messages, fixed checkpatch warning, dropped usage of (u32)-1

Pali Rohár (7):
USB: serial: ftdi_sio: Fix divisor overflow
USB: serial: ftdi_sio: Add missing baud rate validation
USB: serial: ftdi_sio: Extract SIO divisor code to function
USB: serial: ftdi_sio: Do not reset baud rate to 9600 Baud on error
USB: serial: ftdi_sio: Fix baud rate rounding for ASYNC_SPD_CUST
USB: serial: ftdi_sio: Fix custom_divisor and c_*speed for
ASYNC_SPD_CUST
USB: serial: ftdi_sio: Fill c_*speed fields with real baud rate

 drivers/usb/serial/ftdi_sio.c | 187 ++++++++++++++++++++++++++++------
 1 file changed, 156 insertions(+), 31 deletions(-)
Signature · 1 line
2.35.1