Skip to content

ovl: acl fixes

Christian Brauner linux-fsdevel linux-unionfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest3 patches 4 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3acl: move idmapped mount fixup into vfs_{g,s}etxattr()fs/ksmbd/vfs.c fs/ksmbd/vfs.h fs/overlayfs/overlayfs.h +4 more+143 -641 reply
2/3acl: make posix_acl_clone() available to overlayfsfs/posix_acl.c include/linux/posix_acl.h+3 -11 reply
3/3ovl: handle idmappings in ovl_get_acl()fs/overlayfs/inode.c+78 -81 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchSeth Forshee
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] ovl: acl fixes

From: "Christian Brauner (Microsoft)" <[email protected]>

Hey everyone,
Hey Miklos,

This is the series I described and announced in the commit message to the patch I sent yesterdat (see [1]). It enables POSIX ACLs for overlayfs on top of idmapped layers. It encompasses everything that is needed to make this work correctly. There is a detailed explanation in the first patch of this series so I won't repeat it all here in the cover letter.

My plan would be to get this ready for the next merge window. Once Miklos has merged the temporary fix I sent out yesterday in [1] and it shows up in mainline I will rebase this series on top of the next mainline rc. I will then add a revert of the fix in [1] to this series reenabling POSIX ACL support for overlayfs on top of idmapped layers.

I will also merge in the vfs{g,u}id_t work that is in -next replacing the old idmapped mount helpers with the new type safe idmapping helpers.

This survives LTP and xfstests:
sudo ./runltp -f fs_perms_simple,fs_bind,containers,cap_bounds,cve,uevent,filecaps sudo ./check -g quick
sudo ./check -g overlay/union -overlay
sudo ./check -g quick -overlay
sudo ./check -g overlay/union -overlay # export IDMAPPED_MOUNTS=true sudo ./check -g quick -overlay # export IDMAPPED_MOUNTS=true

Note that I'll be on vacation next week and so will be looking at mail less frequently.

Thanks!
Christian

[1]: https://lore.kernel.org/linux-unionfs/[email protected]

Christian Brauner (3):
acl: move idmapped mount fixup into vfs_{g,s}etxattr()
acl: make posix_acl_clone() available to overlayfs
ovl: handle idmappings in ovl_get_acl()

 fs/ksmbd/vfs.c                  |   2 +-
 fs/ksmbd/vfs.h                  |   2 +-
 fs/overlayfs/inode.c            |  86 +++++++++++++++++--
 fs/overlayfs/overlayfs.h        |   3 +-
 fs/posix_acl.c                  | 142 ++++++++++++++++++++++----------
 fs/xattr.c                      |  25 ++++--
 include/linux/posix_acl.h       |   1 +
 include/linux/posix_acl_xattr.h |  34 +++++---
 include/linux/xattr.h           |   2 +-
 9 files changed, 224 insertions(+), 73 deletions(-)

base-commit: 88084a3df1672e131ddc1b4e39eeacfd39864acf

Signature · 1 line
2.34.1