adp5588-keys refactor and fw properties support
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest10 patches 6 repliesIn review
- v310 patches 9 repliesSuperseded
- v210 patches 5 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 10 patches | 22 replies | Superseded |
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | input: keyboard: adp5588-keys: support gpi key events as 'gpio keys'drivers/ drivers/ include/ | +144 | 2 replies | |
| 2/10 | gpio: gpio-adp5588: drop the driverMAINTAINERS drivers/ drivers/ +1 more | +0 | 3 replies | |
| 3/10 | input: keyboard: adp5588-keys: bail out on returned errordrivers/ | +38 | 0 replies | |
| 4/10 | input: keyboard: adp5588-keys: add support for fw propertiesdrivers/ drivers/ include/ | +288 | 0 replies | |
| 5/10 | dt-bindings: input: adp5588: add bindingsDocumentation/ MAINTAINERS | +112 | 0 replies | |
| 6/10 | input: keyboard: adp5588-keys: do not check for irq presencedrivers/ | +0 | 0 replies | |
| 7/10 | input: keyboard: adp5588-keys: fix coding style warningsdrivers/ | +48 | 0 replies | |
| 8/10 | input: keyboard: adp5588-keys: add optional reset gpiodrivers/ | +12 | 0 replies | |
| 9/10 | input: keyboard: adp5588-keys: add regulator supportdrivers/ | +19 | 0 replies | |
| 10/10 | input: keyboard: adp5588-keys: Use new PM macrosdrivers/ | +4 | 0 replies |
Reviews trailers per patch
All 10 patches have a Reviewed-by or Acked-by.
| Patch | Andy Shevchenko | Bartosz Golaszewski | Linus Walleij | Krzysztof Kozlowski |
|---|---|---|---|---|
| 1/10 | R-b | R-b | ||
| 2/10 | R-b | A-b | ||
| 3/10 | R-b | |||
| 4/10 | R-b | |||
| 5/10 | R-b | |||
| 6/10 | R-b | |||
| 7/10 | R-b | |||
| 8/10 | R-b | R-b | ||
| 9/10 | R-b | |||
| 10/10 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v4 00/10] adp5588-keys refactor and fw properties support
The main goal of this patchset is to remove platform data and replace it by firmware properties. Original discussion in [1].
While in here, some refactor was done to the driver. The most noticeable one is to replace the GPIs events handling by irqchip support so that this gpi keys can be "consumed" by the gpio-keys driver (also as suggested in [1]). With this, the gpio-adp5588 can be removed. This change comes first so that we can already remove some platform data variables making it easier to completly replace it by firmware properties further down in the series.
As there's no users of the platform data, I just replace it in a single patch as there's no point in having support for both (even though it might be harder to review the patch as-is).
Special note to the gpio-adp5588 driver removal. I'm aware of some changes to the driver in [2]. These changes are in the gpio tree and this patchset is naturally based on the input tree which means that patch 2 will not apply. So, I'm not really sure how to handle this. I guess in this case the conflict is easy to handle :) but just let me know on how to proceed in here if there's anything for me to do.
[1]: https://lore.kernel.org/linux-input/[email protected]/
[2]: https://lore.kernel.org/linux-gpio/[email protected]/
v2 changes:
[1/10]
* Turn hwirq signed so we can compare < 0;
* Replace WARN_ON with dev_warn();
* Do not set of_node on gpiochip;
* Moved to use a const irqchip within the gpiochip;
* Set default handler to 'handle_bad_irq()' and change it
in irq_set_type;
[4/10]
* Dropped "-keys" from compatible and added vendor prefix;
* Fix -Wformat complains;
* Don't use abbrev in comments (fw -> Firmware).
[5/10]
* Be consistent on $refs;
* Drop "-keys" from compatible.
[7/10]
* Include bits.h;
* Use GENMASK();
* Use BIT() in KP_SEL();
* Reflect code changes in the commit message.
[9/10]
* One line for regulator_disable action.
v3 changes:
[1/10]
* Use 'irqd_to_hwirq()' helper;
* Use INVALID_HWIRQ to signal hwirq not found;
* Just compare irq against 0 in 'irq_find_mapping()';
* Renamed irq_data *desc to *irqd to avoid confusion.
[5/10]
* Dropped the -keys suffix on the filename;
* Compatible enum in alphabetical order;
* Improved 'adi,unlock-keys' description;
* 4 spaces indentation for dts example;
* Renamed device node to a generic name and fixed the
compatible property in the example.
v4 changes:
[1/10]
* Use local 'INVALID_HWIRQ' macro;
* Explicitly define a local variable to hold 'irqd_to_hwirq()'
Nuno Sá (10):
input: keyboard: adp5588-keys: support gpi key events as 'gpio keys'
gpio: gpio-adp5588: drop the driver
input: keyboard: adp5588-keys: bail out on returned error
input: keyboard: adp5588-keys: add support for fw properties
dt-bindings: input: adp5588: add bindings
input: keyboard: adp5588-keys: do not check for irq presence
input: keyboard: adp5588-keys: fix coding style warnings
input: keyboard: adp5588-keys: add optional reset gpio
input: keyboard: adp5588-keys: add regulator support
input: keyboard: adp5588-keys: Use new PM macros
.../bindings/input/adi,adp5588.yaml | 111 +++ MAINTAINERS | 2 +- drivers/gpio/Kconfig | 14 - drivers/gpio/Makefile | 1 - drivers/gpio/gpio-adp5588.c | 446 ----------- drivers/input/keyboard/Kconfig | 3 + drivers/input/keyboard/adp5588-keys.c | 724 ++++++++++++------ include/linux/platform_data/adp5588.h | 171 ----- 8 files changed, 594 insertions(+), 878 deletions(-) create mode 100644 Documentation/devicetree/bindings/input/adi,adp5588.yaml delete mode 100644 drivers/gpio/gpio-adp5588.c delete mode 100644 include/linux/platform_data/adp5588.h
Signature · 1 line
2.37.2